From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0073.outbound.protection.outlook.com [104.47.41.73]) by dpdk.org (Postfix) with ESMTP id B9CAD293B for ; Mon, 6 Feb 2017 09:22:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=T+q0JW4qieonIflsO1qe3x4hrv/xcgmI0xg0lq70YoE=; b=kM6mnryv60CI1U+G1+8/mWaYSGVEWRfQ9RSt+YyuSyKf/3o1TsT1VPmrnuocvm7qLxOq4yfUb+4d0VDbbOMWIv1XZWN4F2lznKrteuMDPalfuRb+gAeAZFSzsr4tYYMuQ1MtHr53G7/2qQsDj/nwbvQ4gTGzQIxX8sRvPc5iHgQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.171.53.66) by BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Mon, 6 Feb 2017 08:22:54 +0000 Date: Mon, 6 Feb 2017 13:52:34 +0530 From: Jerin Jacob To: Harry van Haaren CC: , Bruce Richardson Message-ID: <20170206082232.GC25242@localhost.localdomain> References: <1484580885-148524-1-git-send-email-harry.van.haaren@intel.com> <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com> <1485879273-86228-3-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1485879273-86228-3-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.171.53.66] X-ClientProxiedBy: BM1PR01CA0084.INDPRD01.PROD.OUTLOOK.COM (10.174.208.152) To BN3PR0701MB1720.namprd07.prod.outlook.com (10.163.39.19) X-MS-Office365-Filtering-Correlation-Id: b102cf0d-26c1-4023-64e9-08d44e695a6e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 3:RuwYS2QcO2tZrIRFucj2jYTB5vaKY60Yc4J904kLayqy2jOWp/BqAxb9ZZPjzoClZ5BVu9nZcPzSXjaSDjrPOA2caDmQlc+d4XrEvPG6EbjRWzJVq4MGFkrZBDYmRS8TgWz2Gml4fK9mZS0fQPS3PATtoesZthLJkYMy2oBBFHUpPGVvFmLMhuMdusjneP+E36f9Og7F0rXaHaescx4+T1Pmr9TBGPvPjxN9MPBPgLkOiF0GZ0nJQVcCqWTkRUeQjQlbrpq5EAPMiKmKFTskGw==; 25:KTH+lRqeJDsaM3VbF6+60d7rKPO9JehNVqZ6ZUV4MIkU/brTACG5PukLcezKWc7gwL8hnWz0lC/xHUELdZ4QYKI+r5vIztkLLmqZqxutkp6xRFZ7hrL15WC0x4Y3kkHAxB++IDGZ02RaUnjQSydRqJdqk9cxeQciRrCXE0itghReFMo76q9uxcpaGlwzUcKnHpir66PxQb0XgB+E0YR19jwHjs4x/ziiKbK/trIxesvEXJqRsWXktrHTiV+fq1FPcR2Wll3WGDCkSYMmPfSrdGicPbjprhNImezeIpPpHHVlj7mv05u4VtVQNspIUgt7JPyFiqlxsQNkZWbRZqSSqfGQQxXCtxUUNJ7z4mf5OMq1Mu2U8UnPFonKJEP97z4qkPcxhAOx5M234a4RgHQ12VplreY9FeBzXRDEeg7OgE5/xUOPcmFPpsfbAyoD5XXo X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 31:L0usYC57nEs+gNAKmASjZQd0uQBhYPOwoL0NdJ6nJy0+m4EFvSi0KsEbSbtQd1shx82LGPWNzyeWrwfab0//TBaKbO/u6xLD1QUdqfJdzfs7rtAkwC0sGinmwnC+sgWT+Fpqu597bd2i9OldKEAx6NujlK0W/4N39TPfTlJG6F9PFxRDhIUW+DZKKbAhKxSeHVQA4Vv/my9CK/UQNIEIA7bHHIGq6UvhcKZba/zBD9c/r+fjPW2ugMPISDDbmJCrQ5r2fJE1iGJVkibsr2e5e1cZCUY+0uHr5tHFpe0f6zY=; 20:AMRQco7xlD8w8BQZwgy7Lle9ZkLhxQycbNrAU/XoY6xDuk7cW/r6HscqJ01y/JC+veLofbev79kt2efWVFq1lSiFk2qM9J0DT1yiunX2bplCQMdq0Pq9i5KHOQvBf5Q2zFkfpTUC0WyGCKhpTqTmlGrA+7Xa28BkIln6cvJ/NqkOJXIG79LcBoQBgiuzuEju4NMkLgfNDvnUskMwl4SHpLVMdvD2r5+JWsRMU0+roiPTvbH/SLFvqTBagLhQBTE0fzfD1wRxro8C5AE5mf5PuXHVdhwIqNjwF7gcHNteHu7KJOxWV/OnlMbG8wkMqPsgfmkJ8sHhiZjD7m7HPl0yVc9ugj42UMqUSaHj6k0l2LvX6EZhXcECypPjqSrPvNCaA85nGHeZ2oAg7kUuUe4/pPeWHk5URF/Q0u4VUu0i4onrAYJGrdDfpGFnQyEc0G20cmcajf3/M7j83PMMkM4lx30oLvDn6gOYhFulzypIROoDzunvZfBG62TTLHymsn2GiVgQANd3el1tOm0uKxJsO2aevf4H5t1YkLzdOylvX9bKg/Mt0c09h5hHdlpqfDWG7FO/p1gHMvuZxbjYYpKnSQd4FXjUrxhehKquqJ7XFrg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(20170203043)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123558025)(20161123555025)(6072148); SRVR:BN3PR0701MB1720; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1720; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 4:oknfhZZoM16J2pTwgUHK0n2miJ84cAAXUVvP/OgJXnG85XQdtrPlpEC8Mviy3sGsOzrCgP9llew8cnjlshDsxkRVtZwI5VXChhGxZpuJaGNRjL0ULDQ+Ue2crXmN1dYtKcyj+xgWqsS/6ifn/wk6gJw6mky+w2E78HeoEDBqYloQN0PLLcIClMdckDo3Q3k3qhj+JiHiGSR78WYD7mwxG1DmG9FbIi5Ml0sI7r+viFevLR3EYVU5u6AyJhq3vRSz4kruPDOyI0PZuJPxiFvKne6kNunDu6SloKk5dkjz0XMSZRTv4r4qb0YIUPp8GGYvAjW8m0Yec8/ufjbxpVmExfxUUywViojod1Wx8tfEbEuBcnGykXNtd0mN7feTr70ZPpKJff2IYe8ZxtijynnZOKXH3hbPGtM9eUcFbQJuWgSNs7A7jvMGYWx/YbQPMY30k/mJBZg+62amFZ11qHDOLC/aN0hdKBSlz+uKJrnH2LpsJX5gJ2KM9iFpfmiz0pTkiZZiMJFMYz6Surug54dFYq5UUJM9icb0q5Lm7JUiBncUpC1ygQuCskTOdtBmMYDhhmm3v1UGdD+HZugdd9nk5JvN1zBc2yrhLGF0nO2D90Qi6uOxHIP+7Zla6J5lZ4aqDKbnu/dQztFK2FS3DBk9D8gOUFjq84c80KeaPecPAy4= X-Forefront-PRVS: 0210479ED8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(24454002)(189002)(199003)(33656002)(68736007)(92566002)(101416001)(97756001)(53936002)(54356999)(50466002)(76176999)(50986999)(46406003)(105586002)(81156014)(81166006)(8676002)(42186005)(106356001)(66066001)(61506002)(47776003)(189998001)(54906002)(4001350100001)(38730400001)(229853002)(55016002)(42882006)(6916009)(1076002)(2950100002)(97736004)(6666003)(110136003)(2906002)(6506006)(83506001)(4326007)(6246003)(5660300001)(7736002)(305945005)(9686003)(25786008)(3846002)(6116002)(23726003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1720; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1720; 23:cofl16w8qvYC5iyULOoJkSLOmk8Cc1ig1QBHWLR?= =?us-ascii?Q?VH4MqHq7KLBth8a+lerV/LlhIm3PVviyhnona8s51e4bjbwIZ+rSYH7Ji1H1?= =?us-ascii?Q?JDkkvZxvG72C8EKjb7SN1asD6/Q0j7afKqg+ZrmGDlk7upx0y3c3q5o5kOeY?= =?us-ascii?Q?rvAEG7uG3fBvVWcz+airbp6YYiihsYi21ZBoMMCuapPrkbHECIEWrrB4k0CV?= =?us-ascii?Q?zguN0j8R5DUKl/uzYBBPwONZHY08oiAH7/ajjChR1k0rJJmCmffpHWBEb71o?= =?us-ascii?Q?laEEQH7/pgePYv+4t1wCrkoomKxn45KiJy/P/+Sh4eXZT7EXKnKfTGrPDfOf?= =?us-ascii?Q?aQIasaQ2GnMO+ndtESfHA9DZ0MtzGKjSazoqu8iIm/CGA1abK34VnPu5aZvZ?= =?us-ascii?Q?mAuQfsL6ew4YGQF8/qTKoY8xCUurK8LPfF7GBbtX9FH3Kwd0Tg2PYGHxC683?= =?us-ascii?Q?vBUmwqGgNZH68T7G27aK5ec5h25hHIZjItNz9c7EpZKhdL3djBaA99OFfoDu?= =?us-ascii?Q?JjV3poeDiIX3pL+gqjS26RTrOB/IqLxDwXOdWpPpvhLaewNyB5qIcAZs0lrF?= =?us-ascii?Q?gVKmcQzvjN4raMHJ5E2OXua8dLWSIxND2A7d00dBaMWWHIioSQVAsY2ql6ei?= =?us-ascii?Q?+GfhC47cCiNbGF5tZPX19tjFhh/PC+9r6vvvddsciDNUXcYbAUqjJzHANDkG?= =?us-ascii?Q?XHGk11mBufzsMes4dWRYnmrk580OcQLZkqDMUk1zyvTwaZDORcjKObp2QDru?= =?us-ascii?Q?v28NcQPkr1Yfk0GNVg0eliOOUbeU3nHmKVKm7fHv88+E6D0+A0TQabdoPyRF?= =?us-ascii?Q?4WzkJfrk/RCRXImvbC+ZgLYIU+l/A03uJwwWNTOliLL0P0qdNTycXYVnlHYO?= =?us-ascii?Q?Mg9RKOVKrNXS6mfYBRO+puTKsG3cHiUrxXQAHrfWXl4KqGZDd7rRqtA8+sjP?= =?us-ascii?Q?VFSZSPbxMxOhAJdC53dlwX5Id9KYCwbZyLymlVWgllR1iKzyrkCqvIlpX4FK?= =?us-ascii?Q?BOQjzJiOOvigYRRMTWscmZPzHImhIutz2XU7pjKSY/RONShktwpdLS1XLdLN?= =?us-ascii?Q?FNsQ74E+wT3yR/3VWoBBveJiwyJqc4fZgbuquLoJMfJG6BLhE6W4M7UlIrR8?= =?us-ascii?Q?Gtj+N6gOHS+lACxQ1sRKMyclc5fu0VRwzcn6iX1DJw2axgP/wrZYAERPL9Vx?= =?us-ascii?Q?erHjvuUOMKM7/InLUIZ53+Azf+Y5fXsZI8zfG+ATMYjpF/iAfAqBu3PlHzUE?= =?us-ascii?Q?q/TKwyS1RlOAfT5L3V2XWLpOnIeUS9AudsXFdOQieaUUZlxbflbKx46kMjnR?= =?us-ascii?Q?9qwe8VhKRuG0kpW/aEla77zg=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 6:S0LcuJWl+eadMXZ0NZmS81cd6p+Ft3BYr5brmMtxrOgJLPlz4RZp1FZSVcn6scQtxkqQWUdzIB6pin6psYbkNL/78izky6qZG+gFsdhL5kI0ZPWG35KsawwQ7VAETblgms22YML8lR4EjeN61Ym1Qpvb3lB7FrmspZLptsu2bA/q7QMrKJMZbjXRUTFJaw2Cf80yE562Nm+y9BiGUvyWbvl/a2KAoOLeh6YjZurB4khdtJwxTkWcvURX/YORKTRMIc1a5IEaoxk0XvHfTonIeEohNu5VC4azj9UxjsL2ADt92TjmVilVaV738uCjdFP/2CsTsaOWcJH0QnH92boqaPLfAqTjNVsrDfipz5vTkv/txOjRIeZzp1nc/eaHYsg6EGgmEQ6EzpBRy55X2wKbGQ==; 5:TbeZg0c80HeS3ACHQ5KJ4oBlmFXUas4xNjiZRbiVO7PIgyeZUz1cWbPyzPEDb532XzIDrpAasI9Wn9wbPEEt7eL55ZiU7TPK8rWWfiJr/yc144IQATXHbnPb4rQ8AARyw7gZAv0xgNsPWrpi9bkg3Q==; 24:cUn8umJYOAzgGQH3AL8R7YHLiUb0hfRV+CTZhcnOXGmkW3ALf5x5DPm7AWnTJxzlfzv8tm4UDZ0uN71fYmCIwJITRTqPCEe9Ql6dVaINgm8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1720; 7:TTBm1FL0I6jUS8rZN0VoFY9hXhd38tKNysWp5eHsNkauOTX/AoOM3WOTYanDGmNYBP57MR3aqwVQEW8/oY0M9fR2n8P7t704mMzr1aWJQXkMCNSyP7esse79dWVrs8xGGlGp+tyWwGFJdYQhEL0wzEYMic7QDL+FCtb1Ny2g4e4t+nnrxlobU2gia/13/vQDaG0r35ubQZA69zQV6G7by4cJr/GBhBv/ODvDxNKHicdxoaraJzZn8uxsywNJ1rz8PTI9P5y1DbhJNZ03e87Lp6122AjdEifv8Ge/dL/jG8rYSoz/1eoX2dUL0ibPpNHJlyrGrXXlL7nHPxaMygI3SSmd/moEbLxp5Hzhx89/xnB7M6wrH1Rac8CkLw2JlCvb21uD6NHZ6B5RisAtGvLm7zkcVrDV4e6BfMZO9zLZHuSqAv/d43ZpU5D2UCXvFxCajbuxcOumPuQb3LeoUZk37LjCa/aKBTEate9ZIVdCxBXQX2dGKFydJeuWszwnoRB5LlhsltSP40NTlJ0f8OI57A== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2017 08:22:54.7557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1720 Subject: Re: [dpdk-dev] [PATCH v2 02/15] eventdev: add APIs for extended stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 08:22:59 -0000 On Tue, Jan 31, 2017 at 04:14:20PM +0000, Harry van Haaren wrote: > From: Bruce Richardson > > Add in APIs for extended stats so that eventdev implementations can report > out information on their internal state. The APIs are based on, but not > identical to, the equivalent ethdev functions. The APIs Looks good. One minor comment though, Can you add statistics specific to per event queue and event port?, To improve the cases like below in the application code(taken from app/test/test_sw_eventdev.c). IMO, it is useful because, - ethdev has similar semantics - majority of the implementations will have port and queue specific statistics counters + for (i = 0; i < MAX_PORTS; i++) { + char name[32]; + snprintf(name, sizeof(name), "port_%u_rx", i); + stats->port_rx_pkts[i] = rte_event_dev_xstats_by_name_get( + dev_id, name, &port_rx_pkts_ids[i]); + for (i = 0; i < MAX_QIDS; i++) { + char name[32]; + snprintf(name, sizeof(name), "qid_%u_rx", i); + stats->qid_rx_pkts[i] = rte_event_dev_xstats_by_name_get( + dev_id, name, &qid_rx_pkts_ids[i]);