DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org, helin.zhang@intel.com, "Ananyev,
	Konstantin" <konstantin.ananyev@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags
Date: Mon, 6 Feb 2017 11:26:37 +0100	[thread overview]
Message-ID: <20170206112637.5a011a7a@platinum> (raw)
In-Reply-To: <1486179375-133509-3-git-send-email-jingjing.wu@intel.com>

Hi Jingjing,

On Sat,  4 Feb 2017 11:36:12 +0800, Jingjing Wu <jingjing.wu@intel.com>
wrote:
> Some Tx offload flags are missed in bitmask of all supported packet
> Tx flags by i40e.
> This patch fixes it.

Could you detail which flag was missing?
Is it PKT_TX_TUNNEL_MASK?
If yes, shouldn't we have a "Fixes:" line?

I think most of the patchset should be merged in one patch, because
changing only the mbuf part (PKT_TX_OFFLOAD_MASK) would break the
drivers that checks the offload bits at init, and this is not suitable,
especially if we want to be able to do git bisect.


My suggestion is to have:

1- fix i40 (add missing tunnel mask?)
2- fix missing MACSET in TX_OFFLOAD_MASK
3- change TX_OFFLOAD_MASK to include all flags (this impacts all
   drivers using TX_OFFLOAD_MASK)


Regards,
Olivier

  parent reply	other threads:[~2017-02-06 10:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 11:50 [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-01-24 11:50 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix bitmask of supported Tx flags Jingjing Wu
2017-01-26 14:19 ` [dpdk-dev] [PATCH 1/2] mbuf: fix bitmask of Tx offload flags Ferruh Yigit
2017-02-04  3:36 ` [dpdk-dev] [PATCH v2 0/5] fix bitmask of supported Tx flags Jingjing Wu
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 1/5] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags Jingjing Wu
2017-02-05 10:28     ` Ferruh Yigit
2017-02-06  3:02       ` Wu, Jingjing
2017-02-06 10:28         ` Olivier Matz
2017-02-07  2:30           ` Wu, Jingjing
2017-02-06 10:26     ` Olivier Matz [this message]
2017-02-07  2:30       ` Wu, Jingjing
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 3/5] net/ixgbe: " Jingjing Wu
2017-02-05 11:59     ` Ananyev, Konstantin
2017-02-05 12:10       ` Ananyev, Konstantin
2017-02-06  8:53         ` Wu, Jingjing
2017-02-06 12:11           ` Ananyev, Konstantin
2017-02-07  2:29             ` Wu, Jingjing
2017-02-08  0:34               ` Ananyev, Konstantin
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 4/5] net/e1000: " Jingjing Wu
2017-02-04  3:36   ` [dpdk-dev] [PATCH v2 5/5] net/fm10k: " Jingjing Wu
2017-02-07  3:22   ` [dpdk-dev] [PATCH v3 0/4] " Jingjing Wu
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 1/4] net/i40e: " Jingjing Wu
2017-02-07 13:48       ` Ferruh Yigit
2017-02-07 15:45         ` Wu, Jingjing
2017-02-07 16:01           ` Ferruh Yigit
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 2/4] net/ixgbe: " Jingjing Wu
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 3/4] net/e1000: " Jingjing Wu
2017-02-07  3:22     ` [dpdk-dev] [PATCH v3 4/4] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-08  5:05     ` [dpdk-dev] [PATCH v4 0/4] fix bitmask of supported Tx flags Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 1/4] net/i40e: " Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 2/4] net/ixgbe: " Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 3/4] net/e1000: " Jingjing Wu
2017-02-08  5:05       ` [dpdk-dev] [PATCH v4 4/4] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-08 16:27         ` Olivier MATZ
2017-02-08 16:32       ` [dpdk-dev] [PATCH v4 0/4] fix bitmask of supported Tx flags Ferruh Yigit
2017-02-09  1:13         ` Wu, Jingjing
2017-02-08 16:46       ` Ananyev, Konstantin
2017-02-09 14:37         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206112637.5a011a7a@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).