From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 8A31B14EC for ; Mon, 6 Feb 2017 11:26:40 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id c85so113496205wmi.1 for ; Mon, 06 Feb 2017 02:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d0sOyOlx1tPdbm1v1s9wXbv2/uiuMnV5K3OYbadpYNE=; b=j3eI4N0SPDR/wXvX/jcLGwuyeFYPSYn3fb1RMcSeZNPq6CQQgQNBi339TG5TDhe38O BM2uuz9hIOs/wNgxBisJtKFCQcA681NV3xL58v0cW2Vkvp1fWbFafmxJj3lEhCHzH/V8 /QwKaXClX2b6P7pcGYwTL9l1xo8gjYUZdiLAElcJU4QL5Mhos93wmFUA7ANIqiTUKtNM arzSsBkPTNwTOCAdzFGMwlIVldzRKmwT14u6LZyP/aV5k+TWIoH9wazZ7jE6rF6RMwI8 WnZQNZISM4fMDTSYu5MJ6av4LHNhe5wUm/XOqh8vTcqXYPhpo8bYYcjqApe64cXdx3Y/ UTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d0sOyOlx1tPdbm1v1s9wXbv2/uiuMnV5K3OYbadpYNE=; b=geIp7Rm3SKb43Ag3HfR3dUuX5cHAWISBKunu+Zw/RuRjldRpQRQdu9e/llkOTmKCOA gWaSOjYgHS8zJJ8pQ/hY7dQaPjESQczeGdzmvmTckq/EK3sso6M9Jar4JOUydpjZZVZ5 0urIBQaB1lW3QRxh/hfrZYxIsQj0AImUys/83cr22pvUaRCu5E2so/MqnkJ7XS+435Kw OeFchS5I8WoaVD5VfkoDHrchWcL0kusPR8llByuVWsZejSSV40salvMfhy5IGrqPhayk M+kbdtnLesXrDhojhRUX65Li9D4GAAOqAuENTKbm2PEkjDBueNJ8hMWRZnpKN0MbGAFu hr1A== X-Gm-Message-State: AMke39mtZlyaKL8lRttdNwez4f9ofHQhr8mLvE/yOpjkpeUhRev+8dIQTMEABBJlrnx/P4v4 X-Received: by 10.28.38.2 with SMTP id m2mr7581197wmm.44.1486376800160; Mon, 06 Feb 2017 02:26:40 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 186sm11988812wmw.24.2017.02.06.02.26.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Feb 2017 02:26:40 -0800 (PST) Date: Mon, 6 Feb 2017 11:26:37 +0100 From: Olivier Matz To: Jingjing Wu Cc: dev@dpdk.org, helin.zhang@intel.com, "Ananyev, Konstantin" , Ferruh Yigit Message-ID: <20170206112637.5a011a7a@platinum> In-Reply-To: <1486179375-133509-3-git-send-email-jingjing.wu@intel.com> References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-3-git-send-email-jingjing.wu@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 10:26:40 -0000 Hi Jingjing, On Sat, 4 Feb 2017 11:36:12 +0800, Jingjing Wu wrote: > Some Tx offload flags are missed in bitmask of all supported packet > Tx flags by i40e. > This patch fixes it. Could you detail which flag was missing? Is it PKT_TX_TUNNEL_MASK? If yes, shouldn't we have a "Fixes:" line? I think most of the patchset should be merged in one patch, because changing only the mbuf part (PKT_TX_OFFLOAD_MASK) would break the drivers that checks the offload bits at init, and this is not suitable, especially if we want to be able to do git bisect. My suggestion is to have: 1- fix i40 (add missing tunnel mask?) 2- fix missing MACSET in TX_OFFLOAD_MASK 3- change TX_OFFLOAD_MASK to include all flags (this impacts all drivers using TX_OFFLOAD_MASK) Regards, Olivier