From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: add known issue for virtio TSO with clones
Date: Mon, 6 Feb 2017 15:10:47 -0800 [thread overview]
Message-ID: <20170206151047.155aa0aa@xeon-e3> (raw)
In-Reply-To: <1486387013-1706-1-git-send-email-olivier.matz@6wind.com>
On Mon, 6 Feb 2017 14:16:53 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:
> +**Implication**:
> + In this situation, the shared data will be modified by the driver,
> + potentially causing race conditions with the other users of the mbuf
> + data.
This is a driver bug! The driver must check for refcount and not modify
mbuf's whose refcnt > 1. For those mbuf's it should copy the mbuf and modify
the copy.
It is not good to force buggy refcnt handling back onto the application.
It is acceptable to document the performance impact.
next prev parent reply other threads:[~2017-02-06 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 13:16 Olivier Matz
2017-02-06 23:10 ` Stephen Hemminger [this message]
2017-02-09 15:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206151047.155aa0aa@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=olivier.matz@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).