From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43])
 by dpdk.org (Postfix) with ESMTP id EC26F293B
 for <dev@dpdk.org>; Tue,  7 Feb 2017 00:10:55 +0100 (CET)
Received: by mail-pg0-f43.google.com with SMTP id 14so32323160pgg.1
 for <dev@dpdk.org>; Mon, 06 Feb 2017 15:10:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=H8yAEUz80640TC5ZrE5tZdNU5BvE6APu9C2IX9Ux3TI=;
 b=K+ERSpZ63rpknzinRV/C94TTKLuC8Csd7CdPyhoqEqXUiuFY3IdMTYFnlbv1Q8aAnV
 RTr0uz2YncAaqQFRNEgGjqHOHmYR6Moj9bBD+8Ru+79zRxdvSbrpF6ssk5lDUtXwnYbq
 /kLGYLdF8Wh/8gsJUchZQOlqv+HK6WOKswBiRx/ELxcdRB0SG2P1d0vAPzMvy3lPy1Vf
 dtFF5ycTWFuTuDlPamskJS+d+0vc/c+3R6SmlgDQsHXLg3eNU0ypDFqn9XU+lb6vf1xT
 stlZ8U3/6eIUvGrQlHjDhTKGS1Ix2DatAu3bTdrl2SN5Of8KYww/JcpsFFJti7byYPbZ
 o0Rw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=H8yAEUz80640TC5ZrE5tZdNU5BvE6APu9C2IX9Ux3TI=;
 b=s6opu6UifdUx4v1IZwuK/iucCnRi0oEAjr/WvVOt9sGc3CNaCf5ocfKcdhvIFwgdgs
 YqJtIHPS1jgin0qEtnIYZM3U4GG5ahjOry8Eb9wBNYpxQK2kUJ7BjzT3zMez50tkXbga
 70yTUeFbUG2TDxWjbRrz+LkrneVT7bySSJxmfsIYRkISX5H7x/LhjB+PvuYmPTTzDv7r
 yzQG9D39MDVV6BVc6mQpprhOJ4N3LxhWSoIlR4/1pxOAcPkI/W9Gyn6tMXToSL2ICUMN
 TtTIvSE6Ads0G+BCLDJYiM0nhYEZ1mEkpWikYSArDtMfdflefENGXdefr44hmqUAfAA+
 lskw==
X-Gm-Message-State: AIkVDXJ1UOzucv17eBH1NBeAHn893BjVcG4rQLs8Iv7pOBhYGAqHcuj6B8WmxutYcv6DKQ==
X-Received: by 10.98.70.12 with SMTP id t12mr16195193pfa.47.1486422655076;
 Mon, 06 Feb 2017 15:10:55 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id e129sm5295732pfe.8.2017.02.06.15.10.54
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 06 Feb 2017 15:10:54 -0800 (PST)
Date: Mon, 6 Feb 2017 15:10:47 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, john.mcnamara@intel.com
Message-ID: <20170206151047.155aa0aa@xeon-e3>
In-Reply-To: <1486387013-1706-1-git-send-email-olivier.matz@6wind.com>
References: <1486387013-1706-1-git-send-email-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] doc: add known issue for virtio TSO with
 clones
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2017 23:10:56 -0000

On Mon,  6 Feb 2017 14:16:53 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> +**Implication**:
> +   In this situation, the shared data will be modified by the driver,
> +   potentially causing race conditions with the other users of the mbuf
> +   data.

This is a driver bug! The driver must check for refcount and not modify
mbuf's whose refcnt > 1. For those mbuf's it should copy the mbuf and modify
the copy. 

It is not good to force buggy refcnt handling back onto the application.
It is acceptable to document the performance impact.