From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) by dpdk.org (Postfix) with ESMTP id E3DCBFAE9 for ; Thu, 9 Feb 2017 23:37:03 +0100 (CET) Received: by mail-pg0-f48.google.com with SMTP id v184so4191989pgv.3 for ; Thu, 09 Feb 2017 14:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XC5JJW483IzA5aRnHWqsePxVOuh6OigifdGfEqJJweE=; b=xoMvUxqhEnWkoonEh5UsWxj10AEyEuqN1em80r6CYSqrJeM1MN8ZAJIoT10989p99B vMMrJNbQmwauuyVx8yhJKOUF2KEWc34svlsCt7Ecdivq+CrFKoow6yMnr+LzcxrbfsvB qOoBsDQHGTxPWko850t/9DfEarhNmnUvmgDuQFhQFnC3RZB86ZaYSEjQlclePFxmOeJQ Z0qViULyI5CkfpH/KkQ5aaRbNWabVouVb2tYZBmq0uUXCtoIHp/jAgm28Vwv+IuR/aH5 dztB7lQMu9CJ0D9uXtSfmUZwjz9nWkrvzlKmiGPg7RrogetqXwuVy5d1sbSz7WiciNR5 zUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XC5JJW483IzA5aRnHWqsePxVOuh6OigifdGfEqJJweE=; b=K8PDoSjDmRVmc3jxk4+STMYepjyESMtnaf/03xC9GvgKd2AYbbgyNuklQ0BLpZLFBO frjrXwMz4IMy1C/YyPMekZXHM4S3C78DVDw/BqohySXUA18AF1xV0TnpRD3k1SCZe0e8 eOYtMGRyDJEI5wn65BaRX6mAfCE5u8wyxwT7t4o+nN587zJjkvgUf7BwWjX1peUe7QNu Z/EpTu2/Q8nac48shJmGbl4CQAtTJof7piOaf/mIv3ms9T/Mi00992YLwt7OZ9KZaAuE RQoDm/7Ka7HikPP932zMkxpxnibNmKsPlQxPuc8KoBLFW09KgXUpzt0FRoZb6Bny33KC 6DEg== X-Gm-Message-State: AMke39mATYXpwMvqrzVjXDovf3tYEzx6G4Rf5yUj9aBWw42/MuSfJoiHNsCpePLciN5apg== X-Received: by 10.84.169.36 with SMTP id g33mr7095601plb.36.1486679823129; Thu, 09 Feb 2017 14:37:03 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id c11sm31466991pfk.14.2017.02.09.14.37.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Feb 2017 14:37:02 -0800 (PST) Date: Thu, 9 Feb 2017 14:37:01 -0800 From: Stephen Hemminger To: Aaron Conole Cc: dev@dpdk.org, Bruce Richardson Message-ID: <20170209143701.5e01fe9c@xeon-e3> In-Reply-To: <20170209142953.8167-26-aconole@redhat.com> References: <20170208185142.28678-1-aconole@redhat.com> <20170209142953.8167-1-aconole@redhat.com> <20170209142953.8167-26-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 25/25] rte_eal_init: add info about rte_errno codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 22:37:04 -0000 On Thu, 9 Feb 2017 09:29:53 -0500 Aaron Conole wrote: > + * The error codes returned via rte_errno: > + * EACCES indicates a permissions issue. > + * > + * EAGAIN indicates either a bus or system resource was not available, > + * try again. > + * > + * EALREADY indicates that the rte_eal_init function has already been > + * called, and cannot be called again. > + * > + * EFAULT indicates the tailq configuration name was not found in > + * memory configuration. > + * > + * EINVAL indicates invalid parameters were passed as argv/argc. > + * > + * EIO indicates failure to setup the logging handlers. This is usually > + * caused by an out-of-memory condition. > + * > + * ENODEV indicates memory setup issues. > + * > + * ENOTSUP indicates that the EAL cannot initialize on this system. > + * > + * EUNATCH indicates that the PCI bus is either not present, or is not > + * readable by the eal. > */ You might want to be less restrictive about wording in the comment. In future more errors might be returned, and also for out of memory ENOMEM is better.