From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Gage Eads <gage.eads@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, hemant.agrawal@nxp.com,
harry.van.haaren@intel.com, nipun.gupta@nxp.com
Subject: Re: [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description
Date: Sat, 11 Feb 2017 11:59:42 +0530 [thread overview]
Message-ID: <20170211062941.GA9218@localhost.localdomain> (raw)
In-Reply-To: <1486753473-26330-1-git-send-email-gage.eads@intel.com>
On Fri, Feb 10, 2017 at 01:04:33PM -0600, Gage Eads wrote:
> This commit clarifies the usage of nb_unlinks when passing a NULL pointer
> as the queues argument.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
> lib/librte_eventdev/rte_eventdev.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index c2f9310..7b64532 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1336,7 +1336,8 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
> * event queue(s) from the event port *port_id*.
> *
> * @param nb_unlinks
> - * The number of unlinks to establish
> + * The number of unlinks to establish. This parameter is ignored if queues is
> + * NULL.
Add similar description to rte_event_port_link too, With that,
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> *
> * @return
> * The number of unlinks actually established. The return value can be less
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-02-11 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 19:04 Gage Eads
2017-02-11 6:29 ` Jerin Jacob [this message]
2017-02-13 15:52 ` [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and " Gage Eads
2017-02-14 4:05 ` Jerin Jacob
2017-02-16 10:34 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211062941.GA9218@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).