From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0057.outbound.protection.outlook.com [104.47.40.57]) by dpdk.org (Postfix) with ESMTP id B08C8282 for ; Mon, 13 Feb 2017 12:48:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2yx4A5b67xi6/0CFNQGOo/ulqz/sOJsuSx3XS+Lj32I=; b=QrjmEATRfQqa2wvwecyNUboEaGNhN0+MDNmOe03Ec2Eu6GvaMLkmTowhXObrnTRAa0kC+UTw8H/jLnsnGngRk3lMYCIt2v9vxHgstwhA5+pzX1VXKqb29qY6i3gsqxwm5S0MuT9ZP1FoFa9wit+qzgqUYuLi4zvbFbg4yZHcZgE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (122.167.151.246) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Mon, 13 Feb 2017 11:48:24 +0000 Date: Mon, 13 Feb 2017 17:18:11 +0530 From: Jerin Jacob To: Bruce Richardson Cc: Gage Eads , dev@dpdk.org, hemant.agrawal@nxp.com, harry.van.haaren@intel.com, nipun.gupta@nxp.com Message-ID: <20170213114810.GA32617@localhost.localdomain> References: <1486760541-12568-1-git-send-email-gage.eads@intel.com> <20170213103854.GB377356@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170213103854.GB377356@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [122.167.151.246] X-ClientProxiedBy: PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (10.174.144.144) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: 14e7fbd7-e424-47d1-d126-08d454063954 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 3:UafuATyU19UI3Bckvg+nW3GGTNuzNeuUCH3JyYrqQKAznbEQNHzQ30mH1O5uZN91sHcLiJMeDWwZtJNPfRbaabDf9HVYZmgsi7S0RbUaUzRNug5+AEavUz05Zbp6mNvEiJSokOeJwdY7GIo5tMXezErXue12DdM4TyyMtyOWXbNDw0oCu3WQiYqY/XqXcAqH5FUG26jkaoiW7PTh4fQ5ygZxScun5WptRWnXJ3WY1lggZwDRiuLqodD9+jBtSk+/F+FP0aediuMOQyOLz0zZPA==; 25:K9kWJRdMV4xlAff4FX2c+Su4gtAyL4uheFEOz7jal624kmrRUi+tQK7A/q8bbVq+ytThWxtR7Run+X2FR8IwobMpv5wr8oksprOcDNI9B7SqfPohpQCez2Ur49A5s8+AwIK7HGzwCHNBRY38uNKrwImE4OOjZsfxRtX2uOrLt7rApMSxdCP+V+vRqT5Knb1o7YmEAlkp8nvhDcsZSqAnKE3r2S2l4aWXpxYi2V4fcKlERmaPV+w3ODVaxuFy54k1XzzKGnNLacbdZlIFkGSCSNNXc0OyWLETdg/k3+hS9EGW8rKU5Qs9LcXs4JgLQAvze9KW5arszYDgB6WRqxE0qDFdbTHfVUbM05YS8QxRsySZVzKKujCos9L8FY3RcAv4Vb6yg6h1crWvSD6re27CCfw2IH9Uo0h4IQNPCJ/5wUH2XTUnySf6gNzLi1cKtHq2am2HmFBror11m6b3r3X+Ow== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:4F1x2ghBHKFXNUwAuFGFxVk9BzDEvHJVtM1MOUV3jIBszFyWFn/KY/BXg1s5ghK+rINpwyzlj6NP2U7vUj0mcouV8l24ZH5H1agbReL3SxBPoXfjhqGqxbjF09Spb4rs8EVCkfUGmPta8uCnQi0U/iQEGhp8S+oz221Jl6/Pger2CPxgYfMtkQPuP1AQOFdCdJEKm0oyrSbwnBM8rbfWGTocDtw0sa2y8n5cPfL/G8EszV2ugc7wxR7Y4OS1R5AL0FZ/u1SfMCyAwNwP/5gXHQ==; 20:NLC5qjgH7nhcxynUlZpQCTBizSmRQMWfQiIWvqN6XxuLA67vd1Et7L9L58oUQByYZGR9PGJ8lb6K/4dBRUpDVGRaFYi/0DQZttID0CUDI6Cn/F4ruGffLmyraPbbzMAqS6STa3lGrs0hLRddt27c0vXalkJc3UrONCDSynNeK0NtTLJhOvSvGBEHHOhn1BLGOMQPfxm/D8oXDfNgG66GInsAFuJq3RiiXV/PbRC0b19Q/+1im1qPSCMEkC6NAPrfW7Z/mdSBD3J4tQF9FNGz4C/+YwlSM1yezlZxFbhV5f0rRzw3PoDe+tZ9RKCmKpU9kv3L3Vrezra/+bVcBW8x+e/gcC1VFVHY84kvjg1FDbPz/jgOtB/ugPx8/8AyD5xVgbpl5MIdbGysrNaWjqHlOPTnwUxK+qke0DTgi44g0jWD+AkpARa2xjyWuvHxDUAJXmDXvTXrZS4R6+SPlX3LJblvSeb04Swet1d+j7VdyxsWbdjwAToCZp5OSSBfU2srn4OYng1O6+snDEI+OJBcIZosAoB/e7XlkYSqrWAQ0fDBra3JxmKpHNFZvuG4bTJkclOCq+quxKO7waalc9WxsOYUOwII8uchZ7hCW24BBpM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123558025)(20161123560025)(20161123562025)(6072148); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:VtEybnPMv2bn5SYFPFhR5xC6OmcYFRB3zrRxz/0YBlCmTaPD+WRhURKBmw/gTZoSSmiygdeHDLKpyWWvkz5nfmVCa72xy0rG5IU/cQ3hOxmqZGUENwXPRxnW2HbL58bwTWCX5mm+IKdUW3Yv/COr9LX0+pZOCBnlcJaxtSfiZ/SMqTJifk9iBrGttGy6qOzTFajz/IAG8EVyG/MWvXOWN/HYlsAqTN3ddlI3bSkEwxUou5n1f3mzDnpC0mGdtXlO/igbPMKA2/6G9eJlgkTkVykCt98J3iTuWd542lM7RuypZVL5x2L1zA4vBYirG/KLz8QuYc2DyR5wXc1m6bvJBCtK/bcgR4BxGxTsST0Dua2qwvQMllwIm+G6QbrbuztT4Ggxv9fOUzbhQQ3ksqZNfRxWIgtELWpjHJveXoq9VXHB5dfRrWq6nKIj1jOSSWkID5u0M1nOoD0LNxVcx90s++v6SEKyyBbyoue3XAjFiOmwPhy8e67TO81msLqjx9ZTjLhGCsyIU2YjQVsqv303Y9bRGj5hPA5bzO+UkIaMnL/KO1wGjDPJHXoCgR3HfTpW2gK34YnGtWQHJtqshOPdFFIRqhwOAyg7MwCU/o0KGoB+WvYyGfn9NXzgdDfbwHfgwYvuE+y324lCYgDiIn8PbA== X-Forefront-PRVS: 02176E2458 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(199003)(24454002)(189002)(50466002)(1076002)(47776003)(8656002)(6246003)(23726003)(66066001)(61506002)(38730400002)(6116002)(3846002)(53936002)(83506001)(68736007)(6916009)(42882006)(92566002)(2950100002)(33656002)(97736004)(4001350100001)(6666003)(25786008)(9686003)(6506006)(229853002)(55016002)(54356999)(105586002)(189998001)(76176999)(50986999)(110136004)(5660300001)(106356001)(305945005)(2906002)(81156014)(8676002)(81166006)(7736002)(42186005)(101416001)(4326007)(7099028)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:O/xHigz2y9Kh9yYvDL6SgdVWm/ZQQXrV42j+3Zj?= =?us-ascii?Q?C3YiFoT2xZG/HAJZYHjfqRQr5eQkxa/CPkmVszs3wKf9j8KNmGSC+yp0Cv6Y?= =?us-ascii?Q?iEQoONX8iYgBCaiNZAw+H7Z4HP1CS2Af65E1E2exnLTHohBJhfVzjteYpTb4?= =?us-ascii?Q?lqZNSlKPui9HxmPIDDb1GZYPLbaUGp+urGpaR/NV7Q7EBqrTLNvPKPEbld3o?= =?us-ascii?Q?x/tJYZGCLXK5uIk71i2S3pYgJ1VBuc0cjHAZp51ZonXIFQqAThe8HdJ4vXTU?= =?us-ascii?Q?4JAEtdblr4i8QFZHu1TupiaA9LwkN7FPexjhpwsvXLPwOmuQVxeJzWqJ6xF3?= =?us-ascii?Q?LZWWEjP/3enSLPvLrEWKtmkQn28OSNty/GQCir3F3tVHKE9NJwWPGCAXAcAj?= =?us-ascii?Q?DTFrmewd+zU06e2lO72c33UuKZnKgz6JAm6c5QhhuNyuZTWTEHwmtpz7X67V?= =?us-ascii?Q?qiYrLP5MaVFqkdYVMvTwfcjqzVdorY7j9lGusEP2C1NaFJN+9fZQ5QidvMts?= =?us-ascii?Q?fuyXDQjIic6lBCiefH2LiczP4tSWKplxyK6Vjm4EY4L85Pi5eQpGLaVNLg+M?= =?us-ascii?Q?wH2YcC0Bmti+v4d2LgQIxqSmkZP6nLKxb5JCaSOKMMl9iJ1bhd4uYaXgYNji?= =?us-ascii?Q?oOpD8m6YRR3oUuEUs6Y1pp5rreIUEtm3zIdXZUyELaYv7cDYOUbN08YTjq+O?= =?us-ascii?Q?hith7buH7bpDMOzHOwtWRpVQeWVC39xPG/Ye1rq1KW6CL3ehaj401VnVWg6e?= =?us-ascii?Q?EjsaK0/pjkvv9dVQsEYEweYnX5UgOTCRbx2vuJk0x++VRdfmBkL+ITc00Zy5?= =?us-ascii?Q?gBwn70ZYxIccGLPhJOWOzonTVvbOfY44RmQjrOChrCFSW0dBC2FVAEWD32M3?= =?us-ascii?Q?M4yKdHmGMkmMjqNYO9n0KPu9MLPTBszKyXtnp7rNJ6OCisFgfaG/Ctr/g4ws?= =?us-ascii?Q?AFUbCHmtaHKW+wAAG+dFQxFkka7wS65DdKbilasJIrBVSzJBCIuoWIBW0JWA?= =?us-ascii?Q?44Wg/PXCGcdmsxacjqY0qO5fDMOFeRIumxj8z82ZSx/dLpWpJnkmoKKNag+H?= =?us-ascii?Q?iPkWm1i/LxeGCf2pjohcJCEuaJG9GnRY+HVvaksBlX+78a9K4VBkoERLTKxG?= =?us-ascii?Q?hwa27CAvvKIQytXV79WbUPNFcxds8TvV2ln5ScqqcRt2/7BHsx3L8jD193+6?= =?us-ascii?Q?rKinEzaWZaHb8iCYFIjW0aNPa9A5V2UzPF2zu38ZkdyhtC/0PN/IY4V4YuNi?= =?us-ascii?Q?vvX/OSGPm8Qj6T3UR2xwXHrvbn+DXa03KL0S4s/VzNkPViO0HtPxdE3Cv+qM?= =?us-ascii?Q?J7A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:1VZBQT9t136yIQymCcR/iqbkWN4cMES5d8UR0hS0fYKZHQNWxc/uK30JtepxxwoSNJRUS0WcQOyeY+z9FGTYmzmZ5VTsB33yLH5MMv2uUTILdPP7o7R2jxkM9Sv4VPdYQccpDzymB9JK+U5suY4fhh/ZuUXvCIWPyRvNahKWjUbHINLrbNsfpa6zyl7uK37kkCgYfE1ySwyAR4dmE5Adqt66ZGk8HYW0WymwgXI7bnGK5ZawiJigXNbwVQZsNKoJ3tpFFZ4nyDBPvd6YDFgT3R/QUFkoJeTMZUDGlOMOZzIfC0ULZs/fUF5IYZ8qGTxry4MDP/rVZfVuq/5JiQ2vJJncO3416OKgItfsBZL6SkI/8Zb7twrniZs6GORBHbUhirwJBpebAq2aN6SAePylAQ==; 5:GRNZMcYjmfL1eicCExBjxkR/HYxC8k9C7vQ8GRH7Uw6VZVgr0cGXAjgtGNyjmTpzuszmnhKdQyKMp4l3PZD084EeXrjFbxcOKJYHmwvmtZh3N0nyTQuhpixpd37fI7jiXlo6i8fZ2T9gFg07IiMXhw==; 24:gfkc2tm95gdL0CUOOE0D9TjkJU5dbs1t64UMw2BWIXsf0mS8NdagvLbQy6Kf0Sz966Mb87S17IhZ2Ng71h0zzgpYE1nXp4NQQlutf/7Pf3U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:NsbJc2RfzAINxTUT7iPC7Nx+F14QNnbrvUcHWY6Dr2NFEgydPYTNLU5cXiivQgRyi0cThocSTVFv0oXnYKu3wU4fBnPaHS2xo4s7juHjE77sv1cHq5dOiuhSmAHC2TurOO0i1qGQyau/YF3s7QooLeJWrG112AAMbifsmHue/mfOjq+fr2adi6NI4jGpcVpel1ZM50bnmMRzOu59MwWj9CkbPUB+dNZjX/+CaET79MKxK5MmWqfNvKraAsbJsGPOP4bU4YRIqCCCek3BjgMZAC6+Fhqh0VWHWCKh5dL+APVg8Q6udGHcvbUbpCz78dTBGmyk3/73oMugW+eGT3tT4uY5Nh2DX2MJbQ2mH6rtyNjoxuqon9vsmpsMNTa6x6USpUSKC3lwn5c8GvIUmuaBQhzl6rf02w2AUPMAUTsO6ve7DQtNybkiZadGIfSfPvRa1x4e/9YIQBoy19p9eWXBPdG9zx2Ntz7usVmMvIYk/B5daMDinZsLI0hO3o/Y8URYiHFVbq4gV9etMrrLChrwBg== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2017 11:48:24.6694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH] eventdev: Add rte_errno return values to the enqueue and dequeue functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 11:48:30 -0000 On Mon, Feb 13, 2017 at 10:38:55AM +0000, Bruce Richardson wrote: > On Fri, Feb 10, 2017 at 03:02:21PM -0600, Gage Eads wrote: > > This change allows user software to differentiate between an invalid argument > > (such as an invalid queue_id or sched_type in an enqueued event) and > > backpressure from the event device. > > > > The port and device ID checks are placed in RTE_LIBRTE_EVENTDEV_DEBUG header > > guards to avoid the performance hit in non-debug execution. > > > > Signed-off-by: Gage Eads > > --- > > Do we have some idea of the performance hit from these? It may be too > soon to know, given we don't have many drivers to test with, but if > there is no perf hit seen with the SW driver, I think we should look to > just always do this, rather than having it compile-time off. If it does IMO, It is better put to under compile-time like ethdev. It is difficult predict the performance regression on wide range of cores that DPDK runs now. I think we need to add following additional checks based on Gage header file change 1) Per event queue ID is valid or not? 2) Per event's sched type doesn't match the capabilities of the destination queue. > prove to be a performance problem we can look to #ifdef it out later. > > /Bruce