* [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description
@ 2017-02-10 19:04 Gage Eads
2017-02-11 6:29 ` Jerin Jacob
2017-02-13 15:52 ` [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and " Gage Eads
0 siblings, 2 replies; 5+ messages in thread
From: Gage Eads @ 2017-02-10 19:04 UTC (permalink / raw)
To: dev
Cc: jerin.jacob, bruce.richardson, hemant.agrawal, harry.van.haaren,
nipun.gupta
This commit clarifies the usage of nb_unlinks when passing a NULL pointer
as the queues argument.
Signed-off-by: Gage Eads <gage.eads@intel.com>
---
lib/librte_eventdev/rte_eventdev.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index c2f9310..7b64532 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -1336,7 +1336,8 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
* event queue(s) from the event port *port_id*.
*
* @param nb_unlinks
- * The number of unlinks to establish
+ * The number of unlinks to establish. This parameter is ignored if queues is
+ * NULL.
*
* @return
* The number of unlinks actually established. The return value can be less
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description
2017-02-10 19:04 [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description Gage Eads
@ 2017-02-11 6:29 ` Jerin Jacob
2017-02-13 15:52 ` [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and " Gage Eads
1 sibling, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2017-02-11 6:29 UTC (permalink / raw)
To: Gage Eads
Cc: dev, bruce.richardson, hemant.agrawal, harry.van.haaren, nipun.gupta
On Fri, Feb 10, 2017 at 01:04:33PM -0600, Gage Eads wrote:
> This commit clarifies the usage of nb_unlinks when passing a NULL pointer
> as the queues argument.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
> lib/librte_eventdev/rte_eventdev.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index c2f9310..7b64532 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1336,7 +1336,8 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
> * event queue(s) from the event port *port_id*.
> *
> * @param nb_unlinks
> - * The number of unlinks to establish
> + * The number of unlinks to establish. This parameter is ignored if queues is
> + * NULL.
Add similar description to rte_event_port_link too, With that,
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> *
> * @return
> * The number of unlinks actually established. The return value can be less
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and nb_unlinks description
2017-02-10 19:04 [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description Gage Eads
2017-02-11 6:29 ` Jerin Jacob
@ 2017-02-13 15:52 ` Gage Eads
2017-02-14 4:05 ` Jerin Jacob
1 sibling, 1 reply; 5+ messages in thread
From: Gage Eads @ 2017-02-13 15:52 UTC (permalink / raw)
To: dev
Cc: jerin.jacob, bruce.richardson, hemant.agrawal, harry.van.haaren,
nipun.gupta
This commit clarifies the usage of nb_links and nb_unlinks when passing
a NULL pointer as the queues argument.
Signed-off-by: Gage Eads <gage.eads@intel.com>
---
Changes for v2:
- Clarify nb_links as well
lib/librte_eventdev/rte_eventdev.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index c2f9310..eaf9dc6 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -1291,7 +1291,8 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[],
* with RTE_EVENT_DEV_PRIORITY_NORMAL servicing priority
*
* @param nb_links
- * The number of links to establish
+ * The number of links to establish. This parameter is ignored if queues is
+ * NULL.
*
* @return
* The number of links actually established. The return value can be less than
@@ -1336,7 +1337,8 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
* event queue(s) from the event port *port_id*.
*
* @param nb_unlinks
- * The number of unlinks to establish
+ * The number of unlinks to establish. This parameter is ignored if queues is
+ * NULL.
*
* @return
* The number of unlinks actually established. The return value can be less
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and nb_unlinks description
2017-02-13 15:52 ` [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and " Gage Eads
@ 2017-02-14 4:05 ` Jerin Jacob
2017-02-16 10:34 ` Bruce Richardson
0 siblings, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2017-02-14 4:05 UTC (permalink / raw)
To: Gage Eads
Cc: dev, bruce.richardson, hemant.agrawal, harry.van.haaren, nipun.gupta
On Mon, Feb 13, 2017 at 09:52:53AM -0600, Gage Eads wrote:
> This commit clarifies the usage of nb_links and nb_unlinks when passing
> a NULL pointer as the queues argument.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> Changes for v2:
> - Clarify nb_links as well
>
> lib/librte_eventdev/rte_eventdev.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index c2f9310..eaf9dc6 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1291,7 +1291,8 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[],
> * with RTE_EVENT_DEV_PRIORITY_NORMAL servicing priority
> *
> * @param nb_links
> - * The number of links to establish
> + * The number of links to establish. This parameter is ignored if queues is
> + * NULL.
> *
> * @return
> * The number of links actually established. The return value can be less than
> @@ -1336,7 +1337,8 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
> * event queue(s) from the event port *port_id*.
> *
> * @param nb_unlinks
> - * The number of unlinks to establish
> + * The number of unlinks to establish. This parameter is ignored if queues is
> + * NULL.
> *
> * @return
> * The number of unlinks actually established. The return value can be less
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and nb_unlinks description
2017-02-14 4:05 ` Jerin Jacob
@ 2017-02-16 10:34 ` Bruce Richardson
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2017-02-16 10:34 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Gage Eads, dev, hemant.agrawal, harry.van.haaren, nipun.gupta
On Tue, Feb 14, 2017 at 09:35:13AM +0530, Jerin Jacob wrote:
> On Mon, Feb 13, 2017 at 09:52:53AM -0600, Gage Eads wrote:
> > This commit clarifies the usage of nb_links and nb_unlinks when passing
> > a NULL pointer as the queues argument.
> >
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
Applied to dpdk-next-eventdev
/Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-16 10:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 19:04 [dpdk-dev] [PATCH] eventdev: clarify nb_unlinks description Gage Eads
2017-02-11 6:29 ` Jerin Jacob
2017-02-13 15:52 ` [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and " Gage Eads
2017-02-14 4:05 ` Jerin Jacob
2017-02-16 10:34 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).