From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 6BD7F98 for ; Thu, 16 Feb 2017 17:49:25 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id r141so19850792wmg.1 for ; Thu, 16 Feb 2017 08:49:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tGC7NsXUP5hDUfav5vZia9vfwCfsVSyg/+CkMXp1lhE=; b=qig4dzsE9VCHYmjPwzvTWp2fwy7FhHoHBvpWyZPJ3LPBfqlxln34BBLEBMsq5YxFft phnicggTisH4YqKaHf5K1gD/V6s1MTcXn4ZBOaw9mk7Ad+EWUPEoFnPCl8/PoXPe2RDT XNppf6NNIAZ9KFaPCX+ElmbRCMyZkY8YECEivcVxHcYhTus+yvMVbATrrVpXafW/58p7 NOb9BjtF35BPVtO39sd2NmeN6Q0Zs6FBtnHr9BFPD8zry7WccmhyBsj81KWa/OwqOncN WqDRn5p+nzEWCl43rb24ocRnNhTIgon5HhUHjFp01WqyuED28oLnE1MEj4eYClauJMST 7/nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tGC7NsXUP5hDUfav5vZia9vfwCfsVSyg/+CkMXp1lhE=; b=OMm/eHb/pEqeIu+p3Pwd1lABjcdBwtQY76cotseOt9QuBKZdbtshJURkmSSZ3OslaA Rg3ezt4+6qS++Kjir7+1U0YJTYQHdq8ezsI5Kddyh1ljB2Uc6ET7LxSD4vSgq+LMH4al 3gFnslTDvPKqkTPIhDCupN5LbYU4VPyzyE+0TktWiA0sJZMhmjKWrP7ID0vt+9IzA8h9 agtZgwMM4JNwjJcUlpvsnyj9k7c18HA3XhrH8E1GEzBGESOPx6grycDpZvbPN3z2APyv VinfhMuuHCacHEkCpF2NaS+XXYgvGw6N7GOO7lwP7zisU4t/vOgytNKF1uJXr9c8TKur oOlw== X-Gm-Message-State: AMke39mK6HRK4wjot1QSj2umckipVBjDihORXfGgn3nuQbuGz+EBccqhF9jimq5171F1sX/+ X-Received: by 10.28.153.196 with SMTP id b187mr12753139wme.53.1487263765191; Thu, 16 Feb 2017 08:49:25 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id i29sm9657063wrc.25.2017.02.16.08.49.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Feb 2017 08:49:25 -0800 (PST) Date: Thu, 16 Feb 2017 17:49:22 +0100 From: Olivier Matz To: "Dai, Wei" Cc: "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" , Guo Fengtian , "stable@dpdk.org" Message-ID: <20170216174922.720f83b9@platinum> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170206145858.41447b6e@platinum> <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 16:49:25 -0000 Hi Wei, On Thu, 9 Feb 2017 14:50:05 +0000, "Dai, Wei" wrote: > > -----Original Message----- > > From: Dai, Wei > > Sent: Thursday, February 9, 2017 10:38 PM > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > Helin ; Ananyev, Konstantin > > > > Cc: Guo Fengtian ; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after > > a PF reset > > > > The stats register can rewind to zero when the port is running for > > a long period. So I am afraid that this check is not always correct. > > Why not introduce a variable to directly indicate whether the > > resulted stats should be updated or not. > > Another way is to clear > hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same > time PF is set down. > Can we know easily in VF if the PF was set down? Thanks, Olivier