From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 867DF2C60 for ; Fri, 17 Feb 2017 20:28:36 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id e4so15505652pfg.1 for ; Fri, 17 Feb 2017 11:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1MINXy7Zwsfsu6iWWmtrhUdIJ+37TDsSCVlkWO3jbTM=; b=w0dGCECXHvH0ERe37v8p0nkJL429awIEJbXKf9dCkLjIIhr1fIKjfSmVuesuf98roU zYJQUb2Y5yuhOg3gWffls57v0l7PajAZKiqoExlgKmlNi3LubwWWmN8LEsDQrKqoT0DT NhyfdcpbCaavO8rXFatFUhTmnLobG1VvV6VF9WLzfrlZodvsn5RfDqQ5RAcRF9D9WKoi tsOHYtDlsnK+58g8QaFskZG6iREIknit78zocYAIe/uisgB62rvtVo21YiL7wg/BOcNE MDZpfwTUKoSe/WgFRLpxglwNwq2tJA4NqPBqvBC6PcW3dVBCVvIFRWpOT+SeXmM72qHq +ayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1MINXy7Zwsfsu6iWWmtrhUdIJ+37TDsSCVlkWO3jbTM=; b=H8kPkdnpxIUYYU3cJ+iy2yzkTOm1DXD5jytTZ8AkpZEnRFoUz9x+J3irFx6EXYTQ7P rk/YxjpNIawW+IsKfABwb8DIYd/j/Ysnvu4BYktXQ02a0GF13Y2JvXOHjnZvoc3swFTD fVUcZD+koSsWQ2g97pnMfXx44sVKjwBKXj0ZCRAeG9OdpRqugblh97LDqTJ+IF+bIVSx bg2XhLF1wW/mQ+SQGKc6DBjCj2liY6TKSMOvwpzqoweC0s0vqtvCif0dIfnT63yVo95I zqA+miD6frBjOo5J7fjlAao5463JyBRPlSkfWwMlAqbeBRI6VWP52dy5n7jir4G5HzKF uFPg== X-Gm-Message-State: AMke39nk1GzzvlXwa6FKnsW0lmGWbNr20boY1YaaZvSFX2MAkzUSVQ4N4FWGuDId0L8xBw== X-Received: by 10.99.66.193 with SMTP id p184mr12023858pga.213.1487359715626; Fri, 17 Feb 2017 11:28:35 -0800 (PST) Received: from plumbers-lap.home.lan ([12.139.153.2]) by smtp.gmail.com with ESMTPSA id p129sm20948479pfp.118.2017.02.17.11.28.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Feb 2017 11:28:35 -0800 (PST) Date: Fri, 17 Feb 2017 11:28:32 -0800 From: Stephen Hemminger To: Ben Walker Cc: dev@dpdk.org Message-ID: <20170217112832.1099e809@plumbers-lap.home.lan> In-Reply-To: <20170131174453.15796-1-benjamin.walker@intel.com> References: <20170131174054.15324-1-benjamin.walker@intel.com> <20170131174453.15796-1-benjamin.walker@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] eal: Support running as unprivileged user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 19:28:37 -0000 On Tue, 31 Jan 2017 10:44:53 -0700 Ben Walker wrote: > + if (physaddr == RTE_BAD_PHYS_ADDR) { > RTE_LOG(ERR, EAL, > - "Cannot open /proc/self/pagemap: %s. " > - "virt2phys address translation will not work\n", > + "Cannot obtain physical addresses: %s. " > + "Only vfio will function.\n", Please don't split a single error message across multiple lines. It makes it harder for user to find the source code lines with simple grep. Better to just have one long line for format string, or better yet be less wordy. Yes, the existing DPDK code has lots of these issues.