From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0068.outbound.protection.outlook.com [104.47.40.68]) by dpdk.org (Postfix) with ESMTP id A00F82C24 for ; Mon, 20 Feb 2017 13:35:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=40xRtwY8uoC6bmBfzMcL72DGQMg7RBWGzwltHlOlZjU=; b=brgfTcNfsz1ATZ/JBw7nriTkkthnvITfXNvNUhrCXIBfBnTyVtl/XHfYTKIYHL1HxHpovs8abCYMmO1GLkgyYfQIFmeCZ3z9h3S+WhV+UifWHgyuls/qOSTWGzyATg08F/IvO739ED9u62b7n93g5h0ZjXGV8d9O9moBR/NQoN8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (111.93.218.67) by CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Mon, 20 Feb 2017 12:35:07 +0000 Date: Mon, 20 Feb 2017 18:04:50 +0530 From: Jerin Jacob To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , "Richardson, Bruce" Message-ID: <20170220123449.GA28438@localhost.localdomain> References: <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com> <1487343252-16092-1-git-send-email-harry.van.haaren@intel.com> <1487343252-16092-5-git-send-email-harry.van.haaren@intel.com> <20170219123224.GC7400@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0091.INDPRD01.PROD.OUTLOOK.COM (10.174.56.31) To CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) X-MS-Office365-Filtering-Correlation-Id: 980b4bf3-c103-429f-1684-08d4598ce7c7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 3:WIQFkM1K5tBsmPjoDBDT/H/jxssYZ0TwB8w96mTwYlFMGlLiyPzdGNofT36nIM0dlSnslbNxVgWNE4c2TDgZsxViDrIARAKRLkz3joOh3NSSAbbVkMof2+q2+YU/3o9aumyYibKIosdKDCZR6dz3UKfWdsO2vYyE15vWFtSFS9yGnmQR/F4NqnLi7uIntgrcTU2rKW4Z9Kxp3h+WLo4TU1Ba/1VSemZERXY0tuCViwkz4PKYAQrVFud5K57KkeYxZ3Hks1gktMm15Vq9hXF7QA==; 25:azxXGpv6WToaF8aIge2DKFb46Wo9zgt9Jk472gssS4N0sqIFWbtBJqUJZ8zxD4ElBA5ZL3ZqD9H5GquxiSHwRh8ywsMNrBW5XE1+52phNiSsvLDEnxTQL+d29TQo29BSJcz9eN2utnQCgQBMcdAlm1fhQSG0YZhEuYKNTrc2YzoVU4KdF7N43LZxLxfjwzqWMhH3k9q0TmYTK7cNNQXHP7CN60XlmV6XOIcaVkCv3BENlFq1zOXEd+NXhKt2Se4JtsTmlBvONH9me8xXGBMW5+u6heyq5D8/xBg9ZVo7hB22A0DTd9S/g5QuOm/o00mgsS/6UI3aEVq2kH8OrqWItjpnDY/WxWYGbxtFnuKcto8qeoeodEcdGdyDKQJ5ImZBlrvAcCo76pTZ4B1jJKq6puv52x2Z5XjH8Fk3z07gkrKaBoVUMOsyjwAv/v3dAEJu5aGBnqJfVszMAUaG7TD90w== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 31:hIlqKyMKHnw7tx6vRdEljxlnJ4rUY/2aBS6KIg0f2Zv3iXAheZuSh9LsjU4wRVqzeSmYOQiXV96ejKOUFzoSK3RLsjQh+ut2orje2dwCv6SLV+28SvC69fF/OnhdUaRItOQi3K09kCE0e2gR+qxyXuqIYYqeSwA843qjuYpvJ7ZE32MSVoo4hnAxf6E9SQR0tJwjsJDKuAYFNKp8zk5J5byfobOx+QnoNF6ghr6khfISEB28RjnuALFmM/Uc0zPN; 20:D3Oa85LeHNsaKEY9Rm+LrPgNbWDeL/F3THSyW79tOETqymrR5oSrIhSq+TW9S1BBY17yOwi+VaaCcIdE3laAkTBY3dC24E6S4hBACowFg+K+H7uNHqtwzFETPlf1ph6ydoH/XxQjZx3bfJCeVPYG9F+CCIXxOGEsl9KjGg4AviHTMRaf5/fl+k0IcWPbSew4H2IZPmrh0QUUF4nPbSZH6ufwuPukwRT7CD5E0XQBnnmf0dPg1kHzFjWD9BPHGWJYx0GkmuDfAVWF7cgv44RXXBaG+eJKIn3Jm+tfd60uaXSRQP2nSSXzXhR3U2z2+ypE5wEa/khTiUDjOjYqiYEwiby2QN1UsPVoC54xKfcS90owv1vJ7VlBXpvk+SZpnJq+rbz+5PmPhpux991EXJIhIxZftnwUye7oTktP+D9wn+NOp+VV22HOhTGr8ssN4t4DIwjhWoKfXfl9PB2HkQOp0o9ro3SYs+aib4sKb12gXS7LWYVGSvB9naWHcI0IWZC0nZQlxY7nEgWmurPCJrGUoHzyIo4/iE/beb8SETmV6g3tNCbQuSt8qghd1bd5ojl9xDZ0ylOncyDeKVY9Dpt91SaU/ckywGPAxJ62DI2r1l0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(20161123558025)(6072148); SRVR:CY1PR0701MB1728; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 4:hKgAgxcOhM2Pzf7biqI05IOE1zIo67Rb6vM9hRgKT8rcmcTb2UkGUe0e2FmTXDOdXrZesdTTPk2NpuVSiq/4I+u9NlmOng8i21dekRLwHVBX6K/K6AnN4YCMKxT1In7ls/2gaIc/1S6bifMu0vnfAOz4911TgU9jqilFFuMDkkzPKBHje/H2phAG6SnA3tvcLVNfi7HygP53eyB8yw637FcZQFLNmO9S1SJNkO221eQpREebgfFdTqgJ9i06UZQML8sTUIzl1xWKcNKXNRhoqTNk/U27ISB64md2HoDy+2bvRZoEeTQKVJxBYG319rYulPW3pYHurceAaYGL308QbT5S5GIhXC/GEwM2hDoftcLLTAab8nCj44t5mW2p7Pg8MWHk/UvbQ4P6t+RPBrd6Bgo9F0nx6zuxLYXDGXoxBxMSDsnBfSDnCK6NGWxTJAzBjDrNldnhrgwYjZUDzVExMHtL0IVMNUCXCG4uFZ2hHW1o9NycUxLcKmbDdPAE+YivwqX1ddgrhPZ3m970kY/XBVbUGGQDHeH4tp0M0htXGfXNhUyirJX35Ugd/1UUcBwcZfWTlcsOG37TaDcysNA7ZKXbnrWzMbUAFairQLqfXwfEeF31ivDaYyWYVVzJnFZx87/T0qWPUpAlR743ZQnlQlpK2PJcas2I0YRGPlwb32plHrZX8nlDbeydXlgRZNja X-Forefront-PRVS: 02243C58C6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(199003)(377454003)(24454002)(189002)(13464003)(4326007)(54906002)(3846002)(42186005)(106356001)(23726003)(305945005)(5009440100003)(66066001)(7736002)(93886004)(9686003)(105586002)(61506002)(25786008)(92566002)(2906002)(1076002)(55016002)(50466002)(229853002)(47776003)(6506006)(33656002)(101416001)(53546006)(97736004)(53936002)(68736007)(6116002)(81166006)(83506001)(110136004)(38730400002)(81156014)(8676002)(6916009)(42882006)(5660300001)(6666003)(2950100002)(54356999)(189998001)(50986999)(76176999)(4001350100001)(6246003)(7099028)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1728; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1728; 23:h0gvnXLycpa8UGoA62eVyIiVLfoNp7MTnOA3Mvh?= =?us-ascii?Q?FZ0L+EBg5Zngo8lbm/vzndYP9YrM9cVMBd3Xfv8iFQbB/OwmVcdoEq9Fogz0?= =?us-ascii?Q?ZJaW63sf8k1EloHW1RiX6Tux67xMjCQkei543ITaqtntKp8UJiUlqby7xNVW?= =?us-ascii?Q?IFCpRWKZx10LlCeE4mI26fqql4uktRhyLjJNqB1Q/a7fcQENqzFOXd6hMF8y?= =?us-ascii?Q?MeF6OFpirIwYuVB0bcSIKKvTJMbsD+JslZaYdI+1tBGb50PIbxg/ELfkm44J?= =?us-ascii?Q?Jpp6A67TxRH+PdcqekmN0uIDuoI5jOz2oyj2efu/cUYmHCgqJ4bvWpZXEosB?= =?us-ascii?Q?s3QDKlQyT2wqxPGc3+sArmz0R9e/rt7ZQ0Qxg+QAqIFMYk55aa3UB3Jj/7Dm?= =?us-ascii?Q?lyaZLWinFpuUu57jhNlXI7uLZvImqa7f8IgctX896Lp2vpNVgFVgYaVsX0sB?= =?us-ascii?Q?wQebP900Uz0qJD3ngEaPyaNAvOPtmf36FBFlR0+ZT78z0YW/wv37KYyOFJuh?= =?us-ascii?Q?9iZRvjvUD+DNHBn391mBE7gatqlEEFigem4f4G2h1KP9fSRcNTKYCLvkv/eH?= =?us-ascii?Q?IrTjokfG9YQAx2trzMF+CfOYFPKeXOBNH8VqWbg3PLBiNdKfEyJfVMgw1eRn?= =?us-ascii?Q?1/qs0pHuyubYlfmSq4/gMXHeZEr88icROu50OQJ+iaq1eV+5K7kkB/+ZwQDc?= =?us-ascii?Q?Ixa7nzbme2/PkUKNzUdjWvFmFYZFDTY5uhbXbTcIjKIFGplO3QE2YOlefLjd?= =?us-ascii?Q?XwBTZeg6Wmcn/vhzu9aPDw28EXWYHxZ7FJldZMvacrLHQ/QceiRvJFFVqIJo?= =?us-ascii?Q?72FIvvbGmuR6xcPZz2gIhSxBKoWGSYeUWIN4xU+X6/lhRaFgqh/O9fSy+Okm?= =?us-ascii?Q?Cs4TNNKXP88pgt3IOcAg98HMKWTpOCUc4PYlf21qNicdghZi3ovpAOEnTwFz?= =?us-ascii?Q?hSzuRkqAbuQdq8Z/FM6qawRzLy4EHdex5nqE/mCSUmrRa2dOwygtdqBwLsu0?= =?us-ascii?Q?ADeJ1Opv2e3ahwtMxF7FF5w+igJzEKDzqYpoklzGkb6xSE2E7nCXYLIOklpa?= =?us-ascii?Q?+EmiohoSIeJ5Iit/DflmMTZI/5bkBVtFILbMA64R/SUrWqwQ1GXT1f7qqfpC?= =?us-ascii?Q?2Y8YVfRpD+9YZ7qh+528XznlhP9ZtF6Ax5kWmIDhEi8GFJ5izAspYPHSDNcY?= =?us-ascii?Q?9i/TBWRVowwDU8ayicWUidzQL3WjZAkfovtfUBgSQdXhG8drXfpNagI4bfSL?= =?us-ascii?Q?wSaxI9wkg9dbZ5C3p0gxELOAG0fhtYfksZp37W9bCxt0kCBUQbsQXvoc8o5g?= =?us-ascii?Q?xC6oBvIhzWw3ru7LBkXRechNRoXKFG8w76hG5VbXNyEdyjOqHoPwiPmJMpDQ?= =?us-ascii?Q?o4hcKvGC91yoboT5jVyFPYb1U6GEN6EEl/2dZzsr3oVbsGpxh?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 6:Lhm9TMcc++Gd8lyFXVJb2EkaY+nJfu6ogT8nQl19jFoxedu5l6xIABTxlSm8rIn+GRz2Hr/gjQBocAsgeSUS6c7thEMMiW4tINjStGNC8dIcsQzi8VuZmHv1esSYKqS9n2n/rbaIGgN/bWVVgdK21tIwFsZs9rOfX22QrCrE8irfhjtpNJ2eYNDKx9yoaaPfN680BLuIN20EIp98yBOXt4Cj3KwvgY6nebNXmzvcM5msUkiPyybFlhEr/T87Qzg5WzdPExKkqwbfG1KQJaUBbqlJH+AE7EoiSzhiUoGX3yy05awBtArV6rcFNExtrJqoxyqumLjfVxb+Cqx/B/eGYnMEp+CfxmnmSSoM0aYN+c6k791b/tUcC6CkCPMl7Jko+ictrk/mK+4xcLoFZs5x3g==; 5:R3Up4sX1o8iLyOG+SDoUc1w1kX+GC+DmTUd+X+tm7P+mE6Oug5hZLm+v+WIfXEvlL7esjW7nQXqiLI+u7u/y6+f+Pt+EeQezSFjUORZG2nE/v6StU5DNoVyUN5Gck6ZHdh17bZTrFHY/bbI0/puHQw==; 24:TNYh7zLx65X6EWpy7jCbV+815f+OnzTPnq9mjsWQOedLWH8px9v9rAX1d61GBAxb7rHSwz14XeqwJVDtdEmkP5RKCjYOfgtcnfoPhNXEbxA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 7:8eyv4xO6OaVKFMF2OB8q9eq0U4Kh4Tov+3iyrFVBCnXfUyDVclCh/uMijrhJNqxCz/bFHFy0FvPed58GKRjrwpAHgvh1qJY3x5+wu2pGnw7hqCuBDUmlUtjhiDHeLdbGow/CUu/cE/5CZAzbBHDGss+/GNJwVdjQHbqUgsXVtgjlaH8Egv10+S0t8CLA0P3CQfjgnFOC9RuUdG8kxk6mjsIhehTE/MPknCmWoBl1d46Vn0O9P7TkHX7jwekcu0Wv7kJx6Ivgs9sve69vF1hr/mGUZqs5xHRoHjHSjjYwcTfPgWRkQ8itB9Em8kULy3AhacExW9+HQC4f/1wUtRFz2w== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2017 12:35:07.2830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1728 Subject: Re: [dpdk-dev] [PATCH v3 04/17] eventdev: add APIs for extended stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2017 12:35:12 -0000 On Mon, Feb 20, 2017 at 12:12:35PM +0000, Van Haaren, Harry wrote: > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Sunday, February 19, 2017 12:32 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Richardson, Bruce > > Subject: Re: [PATCH v3 04/17] eventdev: add APIs for extended stats > > > > > > +/** > > > + * Reset the values of the xstats on the whole device. > > > + * > > > + * @param dev_id > > > + * The identifier of the device > > > + * @return > > > + * - zero: successfully reset the statistics to zero > > > + * - negative value: -EINVAL invalid dev_id, -ENOTSUP if not supported. > > > + */ > > > +int > > > +rte_event_dev_xstats_reset(uint8_t dev_id); > > > > I think it would be useful to selectively reset the specific counter if > > needed. > > > Ok - I like the simplicity of a single reset() covering the whole eventdev, so that the stats should be consistent. No objection to changing the API, as applications can do a full reset using the "partial" reset API if they require. > > > > something like below(Just to share my thought in C code) > > > > int > > rte_event_dev_xstats_reset(uint8_t dev_id, > > enum rte_event_dev_xstats_mode mode/* INT_MAX to specify all xstats on the whole device */ > > const unsigned int ids /* UINT_MAX to specify all the ids on the specific mode */ > > > The other functions that take a mode require a "queue_port_id" to select the component (port number or queue id number). I'll add the parameter. > > Also I don't like the INT_MAX solution, as the enum type doesn't have to be INT, it can be char or uintX_t - compiler and CFLAGS can be used to change the enum type IIRC. > > The ids parameter is an array in the xstats_get() functions, allowing multiple ids to be retrieved in one call. This also allows a NULL parameter to indicate all. I think this suits better than a single int id, and UINT_MAX for all. > > > TL;DR: I'm suggesting > > int > rte_event_dev_xstats_reset(uint8_t dev_id, > enum rte_event_dev_xstats_mode mode, /* device, port or queue */ > int16_t queue_port_id, /* Queue or Port to reset. -1 resets all of *mode* ports or queues. */ > const uint32_t ids[]); /* NULL array indicates to reset all stats */ > > Thoughts? looks good to me. > > > > Other than above comments, Its looks very good. > > Thanks for review!