From: Bruce Richardson <bruce.richardson@intel.com>
To: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lpm: extend IPv6 next hop field
Date: Tue, 21 Feb 2017 11:23:31 +0000 [thread overview]
Message-ID: <20170221112330.GA194104@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1487524499-9570-1-git-send-email-vladyslav.buslov@harmonicinc.com>
On Sun, Feb 19, 2017 at 07:14:59PM +0200, Vladyslav Buslov wrote:
> This patch extend next_hop field from 8-bits to 21-bits in LPM library
> for IPv6.
>
> Added versioning symbols to functions and updated
> library and applications that have a dependency on LPM library.
>
> Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
> ---
Looks good to me. There are a number of checkpatch errors flagged. Can
you perhaps do a V2 with those fixed. (You can use the checkpatches.sh
wrapper script in the devtools directory to help).
Once checkpatch errors are cleared:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Regards,
/Bruce
next prev parent reply other threads:[~2017-02-21 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 17:14 Vladyslav Buslov
2017-02-21 11:23 ` Bruce Richardson [this message]
2017-02-21 11:37 ` Vladyslav Buslov
2017-02-21 12:07 ` Bruce Richardson
2017-02-21 14:46 ` [dpdk-dev] [PATCH v2] " Vladyslav Buslov
2017-02-22 12:02 ` Bruce Richardson
2017-02-22 12:33 ` Vladyslav Buslov
2017-03-09 15:37 ` Thomas Monjalon
2017-03-14 17:17 ` [dpdk-dev] [PATCH v3] " Vladyslav Buslov
2017-03-15 17:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221112330.GA194104@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=vladyslav.buslov@harmonicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).