From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9B4AC2A5E for ; Tue, 21 Feb 2017 12:23:34 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 21 Feb 2017 03:23:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,189,1484035200"; d="scan'208";a="68320901" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga006.fm.intel.com with SMTP; 21 Feb 2017 03:23:31 -0800 Received: by (sSMTP sendmail emulation); Tue, 21 Feb 2017 11:23:31 +0000 Date: Tue, 21 Feb 2017 11:23:31 +0000 From: Bruce Richardson To: Vladyslav Buslov Cc: dev@dpdk.org Message-ID: <20170221112330.GA194104@bricha3-MOBL3.ger.corp.intel.com> References: <1487524499-9570-1-git-send-email-vladyslav.buslov@harmonicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487524499-9570-1-git-send-email-vladyslav.buslov@harmonicinc.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH] lpm: extend IPv6 next hop field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 11:23:35 -0000 On Sun, Feb 19, 2017 at 07:14:59PM +0200, Vladyslav Buslov wrote: > This patch extend next_hop field from 8-bits to 21-bits in LPM library > for IPv6. > > Added versioning symbols to functions and updated > library and applications that have a dependency on LPM library. > > Signed-off-by: Vladyslav Buslov > --- Looks good to me. There are a number of checkpatch errors flagged. Can you perhaps do a V2 with those fixed. (You can use the checkpatches.sh wrapper script in the devtools directory to help). Once checkpatch errors are cleared: Acked-by: Bruce Richardson Regards, /Bruce