From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 91DA45598
 for <dev@dpdk.org>; Thu, 23 Feb 2017 03:52:26 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 22 Feb 2017 18:52:24 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,197,1484035200"; d="scan'208";a="228646187"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga004.fm.intel.com with ESMTP; 22 Feb 2017 18:52:24 -0800
Date: Thu, 23 Feb 2017 10:54:36 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ami Sabo <amis@radware.com>
Cc: dev@dpdk.org
Message-ID: <20170223025436.GQ18844@yliu-dev.sh.intel.com>
References: <1487762487-21698-amis@radware.com>
 <1487778028-30090-1-git-send-email-amis@radware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1487778028-30090-1-git-send-email-amis@radware.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix multi-process issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Feb 2017 02:52:27 -0000

On Wed, Feb 22, 2017 at 05:40:28PM +0200, Ami Sabo wrote:
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index 5291294..9b3c266 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -418,25 +418,25 @@ virtio_user_pmd_probe(const char *name, const char *params)
>  		goto end;
>  	}
>  
> -        if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> -                eth_dev = virtio_user_eth_dev_alloc(name);
> -                if (!eth_dev) {
> -                        PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");
> -                        goto end;
> -                }
> -                hw = eth_dev->data->dev_private;
> -                if (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,
> -                                                                 queue_size, mac_addr) < 0) {
> -                        PMD_INIT_LOG(ERR, "virtio_user_dev_init fails");
> -                        virtio_user_eth_dev_free(eth_dev);
> -                        goto end;
> -                }
> -        } else {
> -                eth_dev = rte_eth_dev_attach_secondary(name);
> -                if (!eth_dev) {
> -                        goto end;
> -                }
> -        }

Were you making the patch based on some internal code base? The latest
virtio code doesn't have the above code.

> +	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> +		eth_dev = virtio_user_eth_dev_alloc(name);
> +		if (!eth_dev) {
> +			PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");
> +			goto end;
> +		}
> +		hw = eth_dev->data->dev_private;
> +		if (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,
> +			queue_size, mac_addr) < 0) {
> +		PMD_INIT_LOG(ERR, "virtio_user_dev_init fails");
> +		virtio_user_eth_dev_free(eth_dev);
> +		goto end;
> +		}
> +	} else {
> +		eth_dev = rte_eth_dev_attach_secondary(name);

We also don't have rte_eth_dev_attach_secondary exported, neither.

	--yliu