From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 03ED32A5E
for <dev@dpdk.org>; Fri, 24 Feb 2017 09:23:49 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
24 Feb 2017 00:23:48 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,200,1484035200"; d="scan'208";a="69654165"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
by fmsmga006.fm.intel.com with ESMTP; 24 Feb 2017 00:23:48 -0800
Date: Fri, 24 Feb 2017 16:22:55 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ami Sabo <amis@radware.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20170224082255.GC18844@yliu-dev.sh.intel.com>
References: <1487851096-32479-1-git-send-email-amis@radware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1487851096-32479-1-git-send-email-amis@radware.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multi-process issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2017 08:23:50 -0000
On Thu, Feb 23, 2017 at 01:58:16PM +0200, Ami Sabo wrote:
> Secondary process doesn't properly attach to the rte_eth_device
> initialized by the primary process.
>
> Accessing device from secondary process (e.g. via rte_eth_rx_burst),
> causes process to crash. because rte_eth_dev_data is not properly set.
>
> The issue was flood by
> 'commit 7f95f78a8aea ("ethdev: clear data when allocating device")'
> which now clears rte_eth_dev_data entry.
>
> So, most of the rte_eth_dev_data fields are not initialized.
> For pci devices these fields are initialized by rte_eth_dev_pci_probe
> ->eth_dev_attach_secondary().
> However, for virtio-user virtio_user_pmd_probe() is called instead of
> rte_eth_dev_pci_probe().
> To fix it: Allow non-pci drivers call to dev_attach_secondary() and
> call it (for secondary process) from virtio_user_pmd_probe.
>
> Signed-off-by: Ami Sabo <amis@radware.com>
Firstly, two minor comments:
- A fix path needs a fixline (check dpdk.org/dev for HOWTO)
- It fixes a bug in former releases, thus it need be picked into a stable
release. Then you need add following just before you Signed-off-by:
Cc: stable@dpdk.org
> /**
> * @internal
> + * Attach to the ethdev already initialized by the primary
> + * process.
> + *
> + * @param name Ethernet device's name.
> + @return
> + * - Slot in the rte_dev_devices array for attached device;
Yes, that's what it returns on success. You also need to add the case
when it fails.
> + */
> +struct rte_eth_dev *rte_eth_dev_attach_secondary(const char *name);
> +
> +/**
> + * @internal
> * Release the specified ethdev port.
> *
> * @param eth_dev
> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> index c6c9d0d..f8bf2ee 100644
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -152,5 +152,6 @@ DPDK_17.02 {
> rte_flow_flush;
> rte_flow_query;
> rte_flow_validate;
> + rte_eth_dev_attach_secondary;
>
> } DPDK_16.11;
17.02 is released, you should add a new table for 17.05 and add it there.
Besides, I would suggest you to split this patch into two:
- one for exporting rte_eth_dev_attach_secondary
- another for fixing the bug
--yliu