From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 826A92BB4 for ; Fri, 24 Feb 2017 15:03:54 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2017 06:03:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,201,1484035200"; d="scan'208";a="61821234" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga004.jf.intel.com with SMTP; 24 Feb 2017 06:03:51 -0800 Received: by (sSMTP sendmail emulation); Fri, 24 Feb 2017 14:03:50 +0000 Date: Fri, 24 Feb 2017 14:03:50 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170224140350.GB106392@bricha3-MOBL3.ger.corp.intel.com> References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-2-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487647073-129064-2-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v7 01/17] lib: rename legacy distributor lib files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:03:54 -0000 On Tue, Feb 21, 2017 at 03:17:37AM +0000, David Hunt wrote: > Move files out of the way so that we can replace with new > versions of the distributor libtrary. Files are named in > such a way as to match the symbol versioning that we will > apply for backward ABI compatibility. > > Signed-off-by: David Hunt > --- > app/test/test_distributor.c | 2 +- > app/test/test_distributor_perf.c | 2 +- > examples/distributor/main.c | 2 +- > lib/librte_distributor/Makefile | 4 +- > lib/librte_distributor/rte_distributor.c | 487 --------------------------- > lib/librte_distributor/rte_distributor.h | 247 -------------- > lib/librte_distributor/rte_distributor_v20.c | 487 +++++++++++++++++++++++++++ > lib/librte_distributor/rte_distributor_v20.h | 247 ++++++++++++++ Rather than changing the unit tests and example applications, I think this patch would be better with a new rte_distributor.h file which simply does "#include ". Alternatively, I recently upstreamed a patch, which went into 17.02, to allow symlinks in the folder so you could create a symlink to the renamed file. /Bruce