From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9DED72B88 for ; Fri, 24 Feb 2017 15:05:47 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2017 06:05:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,201,1484035200"; d="scan'208";a="61821928" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga004.jf.intel.com with SMTP; 24 Feb 2017 06:05:44 -0800 Received: by (sSMTP sendmail emulation); Fri, 24 Feb 2017 14:05:44 +0000 Date: Fri, 24 Feb 2017 14:05:44 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170224140543.GC106392@bricha3-MOBL3.ger.corp.intel.com> References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-3-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487647073-129064-3-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v7 02/17] lib: symbol versioning of functions in distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:05:48 -0000 On Tue, Feb 21, 2017 at 03:17:38AM +0000, David Hunt wrote: > we will start the symbol versioning by renaming all legacy functions > > Signed-off-by: David Hunt > --- > app/test/test_distributor.c | 104 +++++++++++---------- > app/test/test_distributor_perf.c | 28 +++--- > examples/distributor/main.c | 24 ++--- > lib/librte_distributor/rte_distributor_v20.c | 54 +++++------ > lib/librte_distributor/rte_distributor_v20.h | 33 +++---- > lib/librte_distributor/rte_distributor_version.map | 18 ++-- > 6 files changed, 132 insertions(+), 129 deletions(-) > > diff --git a/lib/librte_distributor/rte_distributor_version.map b/lib/librte_distributor/rte_distributor_version.map > index 73fdc43..414fdc3 100644 > --- a/lib/librte_distributor/rte_distributor_version.map > +++ b/lib/librte_distributor/rte_distributor_version.map > @@ -1,15 +1,15 @@ > DPDK_2.0 { > global: > > - rte_distributor_clear_returns; > - rte_distributor_create; > - rte_distributor_flush; > - rte_distributor_get_pkt; > - rte_distributor_poll_pkt; > - rte_distributor_process; > - rte_distributor_request_pkt; > - rte_distributor_return_pkt; > - rte_distributor_returned_pkts; > + rte_distributor_clear_returns_v20; > + rte_distributor_create_v20; > + rte_distributor_flush_v20; > + rte_distributor_get_pkt_v20; > + rte_distributor_poll_pkt_v20; > + rte_distributor_process_v20; > + rte_distributor_request_pk_v20t; > + rte_distributor_return_pkt_v20; > + rte_distributor_returned_pkts_v20; > > local: *; > }; > -- This looks the wrong thing to do - renaming the files in the history. Instead, I think you need to add in aliases for the renamed versions, thereby avoiding the need for apps, including tests and examples to update their code to use the _v20 functions. Those _v20 suffixes should never be externally visible. /Bruce