From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2D66A2BB4 for ; Fri, 24 Feb 2017 15:14:46 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2017 06:14:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,201,1484035200"; d="scan'208";a="61824396" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga004.jf.intel.com with SMTP; 24 Feb 2017 06:14:43 -0800 Received: by (sSMTP sendmail emulation); Fri, 24 Feb 2017 14:14:43 +0000 Date: Fri, 24 Feb 2017 14:14:42 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170224141442.GJ106392@bricha3-MOBL3.ger.corp.intel.com> References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-9-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487647073-129064-9-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v7 08/17] test: change params to distributor autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:14:46 -0000 On Tue, Feb 21, 2017 at 03:17:44AM +0000, David Hunt wrote: > In the next few patches, we'll want to test old and new API, > so here we're allowing different parameters to be passed to > the tests, instead of just a distributor struct. > > Signed-off-by: David Hunt > --- > app/test/test_distributor.c | 64 +++++++++++++++++++++++++++++---------------- > 1 file changed, 42 insertions(+), 22 deletions(-) > > diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c > index 6a4e20b..fdfa793 100644 > --- a/app/test/test_distributor.c > +++ b/app/test/test_distributor.c > @@ -45,6 +45,13 @@ > #define BURST 32 > #define BIG_BATCH 1024 > > +struct worker_params { > + char name[64]; > + struct rte_distributor_v20 *dist; > +}; > + > +struct worker_params worker_params; > + > /* statics - all zero-initialized by default */ > static volatile int quit; /**< general quit variable for all threads */ > static volatile int zero_quit; /**< var for when we just want thr0 to quit*/ > @@ -81,7 +88,8 @@ static int > handle_work(void *arg) > { > struct rte_mbuf *pkt = NULL; > - struct rte_distributor_v20 *d = arg; > + struct worker_params *wp = arg; > + struct rte_distributor_v20 *d = wp->dist; The cover letter indicated that using new vs old API was just a matter of passing a different parameter to create. I therefore would not expect to see references to v20 APIs or structures in any code outside the lib itself. Am I missing something? /Bruce