From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 26B03376C for ; Fri, 24 Feb 2017 15:18:36 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2017 06:18:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,201,1484035200"; d="scan'208";a="1115130457" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga001.fm.intel.com with SMTP; 24 Feb 2017 06:18:34 -0800 Received: by (sSMTP sendmail emulation); Fri, 24 Feb 2017 14:18:33 +0000 Date: Fri, 24 Feb 2017 14:18:33 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170224141833.GM106392@bricha3-MOBL3.ger.corp.intel.com> References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-16-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487647073-129064-16-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v7 15/17] lib: make v20 header file private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:18:37 -0000 On Tue, Feb 21, 2017 at 03:17:51AM +0000, David Hunt wrote: > Signed-off-by: David Hunt > --- > lib/librte_distributor/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile > index 5b599c6..3017398 100644 > --- a/lib/librte_distributor/Makefile > +++ b/lib/librte_distributor/Makefile > @@ -53,8 +53,7 @@ endif > > > # install this header file > -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor_v20.h > -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor.h > +SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h > Minor nits: 1/ I think this patch should go earlier in the set. 2/ you can keep the += in the assignment. It actually makes it less error prone for anyone changing/adding things later as they can copy-paste or reorder the lines without causing themselves problems. /Bruce