From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D19F72BAA; Tue, 28 Feb 2017 07:41:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2017 22:41:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,218,1484035200"; d="scan'208";a="829205428" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by FMSMGA003.fm.intel.com with ESMTP; 27 Feb 2017 22:41:20 -0800 Date: Tue, 28 Feb 2017 14:40:16 +0800 From: Yuanhan Liu To: Ami Sabo Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20170228064016.GL18844@yliu-dev.sh.intel.com> References: <1487851096-32479-1-git-send-email-amis@radware.com> <1488102926-24158-1-git-send-email-amis@radware.com> <1488102926-24158-3-git-send-email-amis@radware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488102926-24158-3-git-send-email-amis@radware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 06:41:22 -0000 On Sun, Feb 26, 2017 at 11:55:26AM +0200, Ami Sabo wrote: > Secondary process doesn't properly attach to the rte_eth_device > initialized by the primary process. > > ccessing device from secondary process (e.g. via rte_eth_rx_burst), > causes process to crash. because rte_eth_dev_data is not properly set. > > The issue was flood by > 'commit 7f95f78a8aea ("ethdev: clear data when allocating device")' > which now clears rte_eth_dev_data entry. > For pci devices the struct is initialized by rte_eth_dev_pci_probe > ->eth_dev_attach_secondary(). > However, for virtio-user virtio_user_pmd_probe() is called instead of > rte_eth_dev_pci_probe(). > > The fix is to call rte_eth_dev_attach_secondary(), for secondary > process, from virtio_user_pmd_probe. > > Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Are you sure that's the real culprit? As I'm aware of, virtio-user is not built with multiple process support in the beginning. That said, it's likely that the first commit introduces virtio-user is the "culprit" commit. Besides that, the code looks good to me. If Thomas is fine with your first patch, I could merge them to my tree. --yliu