From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 701B22B88 for ; Tue, 28 Feb 2017 11:27:16 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2017 02:27:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="1116530925" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by fmsmga001.fm.intel.com with SMTP; 28 Feb 2017 02:27:02 -0800 Received: by (sSMTP sendmail emulation); Tue, 28 Feb 2017 10:27:01 +0000 Date: Tue, 28 Feb 2017 10:27:01 +0000 From: Bruce Richardson To: "Legacy, Allain" Cc: Stephen Hemminger , "YIGIT, FERRUH" , "dev@dpdk.org" Message-ID: <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com> References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com> <1488136143-116389-1-git-send-email-allain.legacy@windriver.com> <1488136143-116389-12-git-send-email-allain.legacy@windriver.com> <20170227084615.7ff06316@xeon-e3> <70A7408C6E1BFB41B192A929744D85238A757FBC@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A757FBC@ALA-MBC.corp.ad.wrs.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 10:27:16 -0000 On Mon, Feb 27, 2017 at 05:06:24PM +0000, Legacy, Allain wrote: > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > On Sun, 26 Feb 2017 14:08:59 -0500 > > Allain Legacy wrote: > > > > Try not to break error messages onto two lines, it makes it harder when a > > user is trying to find the location of the error message with search tools > That's our normal practice, but checkpatches.sh flagged them as warnings. If these are acceptable exceptions to the tool then are there plans to publish an exhaustive list of checkpatches.sh errors/warnings/checks that can be ignored? Alternatively, are there plans to change the tools to ignore these automatically and not flag them as issues. As a contributor it is difficult to tell what will be deemed acceptable and what will not (in some cases) so the default position is to fix all issues before submission. > In my experience, checkpatch ignores long lines that are due to error messages. Perhaps you need to put the error message on a separate line, if other things before the message are of significant size. /Bruce