Re: [dpdk-dev] [PATCH v2 02/15] net/avp: public header files

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

On Sun, Feb 26, 2017 at 02:08:50PM -0500, Allain Legacy wrote:
> Adds public/exported header files for the AVP PMD.  The AVP device is a
> shared memory based device.  The structures and constants that define the
> method of operation of the device must be visible by both the PMD and the
> host DPDK application.  They must not change without proper version
> controls and updates to both the hypervisor DPDK application and the PMD.
> 
> The hypervisor DPDK application is a Wind River Systems proprietary
> virtual switch.
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> Signed-off-by: Matt Peters <matt.peters@windriver.com>
> ---
>  drivers/net/avp/rte_avp_common.h | 424 +++++++++++++++++++++++++++++++++++++++
>  drivers/net/avp/rte_avp_fifo.h   | 157 +++++++++++++++
>  2 files changed, 581 insertions(+)
>  create mode 100644 drivers/net/avp/rte_avp_common.h
>  create mode 100644 drivers/net/avp/rte_avp_fifo.h
> 
> diff --git a/drivers/net/avp/rte_avp_common.h b/drivers/net/avp/rte_avp_common.h
> new file mode 100644
> index 0000000..579d5ac
> --- /dev/null
> +++ b/drivers/net/avp/rte_avp_common.h
> @@ -0,0 +1,424 @@
> +/*-
> + *   This file is provided under a dual BSD/LGPLv2 license.  When using or
> + *   redistributing this file, you may do so under either license.
> + *
> + *   GNU LESSER GENERAL PUBLIC LICENSE
> + *
> + *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
> + *   Copyright(c) 2014-2015 Wind River Systems, Inc. All rights reserved.
> + *
> + *   This program is free software; you can redistribute it and/or modify
> + *   it under the terms of version 2.1 of the GNU Lesser General Public License
> + *   as published by the Free Software Foundation.
> + *
> + *   This program is distributed in the hope that it will be useful, but
> + *   WITHOUT ANY WARRANTY; without even the implied warranty of
> + *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + *   Lesser General Public License for more details.
> + *
> + *   Contact Information:
> + *   Wind River Systems, Inc.
> + *
> + *
> + *   BSD LICENSE
> + *
> + *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
> + *   Copyright(c) 2014-2016 Wind River Systems, Inc. All rights reserved.
> + *   All rights reserved.
> + *
> + *   Redistribution and use in source and binary forms, with or without
> + *   modification, are permitted provided that the following conditions
> + *   are met:
> + *
> + *   * Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + *   * Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in
> + *     the documentation and/or other materials provided with the
> + *     distribution.
> + *   * Neither the name of Intel Corporation nor the names of its
> + *     contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.
> + *
> + *    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + *    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + *    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> + *    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> + *    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> + *    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> + *    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + *    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + *    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + *    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + *    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + *
> + */
> +
> +#ifndef _RTE_AVP_COMMON_H_
> +#define _RTE_AVP_COMMON_H_
> +
> +#ifdef __KERNEL__
> +#include <linux/if.h>
> +#endif
> +
> +/**
> + * AVP name is part of network device name.
> + */
> +#define RTE_AVP_NAMESIZE 32
> +
> +/**
> + * AVP alias is a user-defined value used for lookups from secondary
> + * processes.  Typically, this is a UUID.
> + */
> +#define RTE_AVP_ALIASSIZE 128
> +
> +/**
> + * Memory aligment (cache aligned)
> + */
> +#ifndef RTE_AVP_ALIGNMENT
> +#define RTE_AVP_ALIGNMENT 64

I think we use RTE_CACHE_LINE_SIZE here? PPC and ThunderX1 targets are
cache line size of 128B

> +#endif
> +
> +/*
> + * Request id.
> + */