From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0047.outbound.protection.outlook.com [104.47.33.47]) by dpdk.org (Postfix) with ESMTP id 00EF22B86 for ; Tue, 28 Feb 2017 15:12:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=P5fSovOIo6niPnC8ywvcv8TKEwmoN99TZqEd8kANfHM=; b=FickVt9OdeNJLAjyzUrWCv+L8oKOA47DZyh9dlN/7O0U5SvtpVLeDpLx7ZkZwQAtkI6b0D5tRjhhxds/QOzxoYn0kNhf7H8xlx8Be3OtI14Sn8l/f6ObJI5nLulo+gFgIaaNQPoYwhq6X1ZhrU67Jman3WQTTt9bBGsSz0ta6Vo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (14.140.2.178) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12; Tue, 28 Feb 2017 14:12:43 +0000 Date: Tue, 28 Feb 2017 19:42:28 +0530 From: Jerin Jacob To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20170228141226.GA10110@localhost.localdomain> References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484642507-15952-1-git-send-email-jerin.jacob@caviumnetworks.com> <4940765.paEGL8zfci@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4940765.paEGL8zfci@xps13> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MA1PR01CA0012.INDPRD01.PROD.OUTLOOK.COM (10.164.117.19) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-Office365-Filtering-Correlation-Id: 18073eac-9574-44cd-4268-08d45fe3de9d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 3:K78mNFpZhfzVc322Q4fEPMyrYbakY8nGoIiF6EnFGi/zaNw2VPnnN0Ng9Q6FP5fdHwmGQhClsvU69FHa4nLG4ifwS3F4QRgBJAEw1whnmp27hP4oUuvxzS45HpcERRO002/VUZ64dStSfzVQSPqHBcaES35nwsB910B6OeyXQad1Ag/5ReIBmXC1UTRj3qVOPtdhMqXfex1LEax/tCbAb02OwGngaIUZSh7c71E9hrAkwXfFcL8cGZ6meYgDxeC7yT9JVc4gxAFQ/TfosJtJyg==; 25:0CnmN5jE6QKuOe+JZQCOK9isxkkjVTpAmMmSTd7aM5YoS8F4fXbij1GarvwY4nN2GgUjMeqQSjxsrPlxKj48vhPsFZq+3jXV5EHwajhgHDRDfksju/YRRkIm0xoaPF4SzqLoLbgVwnEWTJhDf+4J00rjfxIWaGW+K/2Bo2tKpSc7zYDljvUl77izOJHa5HOkTI6rPYXhYh5P06IaL/TPJmcq0i3QclUX90+140jCEU2EPNyC7KXf7P6tpIU3ylj+j+npU1EdIXWhuC7EfIox9PhxGZcjNFT7/sLFNVan8U0Iie/zrjRJC7Nckhs/6JhA4jLLEX/EA6XaV+h8FdPhhJ7/W3wvD64YyLE50HIJip6v/me03VUze/L5kIycQWNZf2zlX3/0VWq2k5BQplSy1jJFABIy28lUbr6jIneKPZbS/Nk5kgGHNQDFiSIMlyPSeCpBTMWTfuATi39iM1qQkg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:Hka3+B3ryuFuU83TkX6GDMgkj4FAF/pQ4GsL80EfrliJ+lFzGWuDQt+gZ8E+YAB/RjeKKyRi+yfv8qhb2TcnxpqTY/DxCxK847yE8+Or3Ptu8GvTrXNmWqOyCnq5ixP8n4IOaNZM/Zw5OJhRxmwWHpqHwCNoEKklxHZJs0bYjRt7vD0cLs97w5yKAlf2K0K+YdWB0SJdcz5TryEP+yHXK0Otj8+5HCsw2QlST55bgJj28NmmgraNz93XE5DQWk7065Bm6/9vDpptltwSvA/13o5v0Pf4iWSv3dXnvjyp0jM=; 20:lZXlEYn0Fw3W+/Vg6kXUpv9PnG+d4sCNx3Z+ENAiPjhKOowobhwAaz1E2ohItjmjEOH4q3FwIlOQhrY4wxq4+bPwKMv6ReDTHtHfVBNw9IANFVDHhJC7kPw79xAmOHsZVOsEJZOcER8C7tmZm8K95MPDucezFdLnyRjNkV1xiqge5E4NI5/LVR8Err2MhAPMxsdhxtlBP/E393h34kPazaOE4YntTA09Z1tDB3Kkny7uWZJjcuABI2qtbq5whxHM2vMPYKIoF/i4M4kR9RgKARxtREusecWH6VnjpcGCszkjv/QtMsth91OnyBnQPA3AXU+gxkBXpOkkgNp3iCfx3+CwD6linJ+hBqCqCx+BQiqr2f2fSnrcLk1nT5Xbdy3xNcxwhTHvoE7jpGmBzfaU8/kwTPoLGKTpDGq70EA3XI3rBsKdax/aImwEEgVidGneQCWfAkMfdd1koios6GV7vnoP7ZPcRuKnNiTNqL/GXaSLAiVBxOVHkCrkzrL1akJgIHKnqEqhTe/pZzBprPlnkngS8eQDUnAmQUIYADlOzPlmUVQIlhTqOQ3f7lm6I0XT0v3OrSID7cu8zABGE4+t1+ttaXWOSXMRxhxmJmONuhE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:PfHnHxwf910eg4t6TnFiovGZiGKWun8vEbVV/8nXBkKrvzRJEfdmiHdRT7ceE8gsOip7imbfgazDfxIeRIqUPcehbvS1VrYQhBneIIU1HZyl0cjksfbf0+3biI75uHahj4ishhl3EkgisXMVrqtSvU/eXI18kAvqENKVUfZDFpIVKoT2yJ+DWKu/pC9TmK9ko/3Og0FIRbYO6pAB6nLhRM2yL8SdSgboiBc3x5xJ4KbxzTIBHB1I/hgSddnQDdAIUIxIpxVH2D72P1m1YQNtZja3xahMn3/G8ject0orn5dWUE6XPo419jhpTLyX956lgjYm0+O4fMkI/eGW3fQ/nmPRdg+aTGjLsJekjNo/Hps0a22kGgvfi8NO0C3KLYYfZwIEjkS9GJYRNR1spDsYsYY6PM3sRHF1n1Hd5YrF0nOslbr+jNztrUfyJIACUYcw2OiiMRhyRcOUqi5EwX27T+c7EEWSU3DT8kFJT3WjwZklTFAIJfpteKh7aX9rLmHvSagSv754Yqd7chGDnb6URUkK7DFEwV206yNu4Q1bpm+RAfqnsrbTRR5p9Bb5lIlM+ZxFzoENv++suYNK9jVmsIqqBG9Md5MvG8wThLv1cvB9CVX1jtfRdIHO8uW2ULivCWFGogmSaSeSNLz05mWTjA== X-Forefront-PRVS: 0232B30BBC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(39450400003)(24454002)(189002)(377424004)(199003)(42186005)(53936002)(1076002)(47776003)(66066001)(189998001)(33656002)(105586002)(23726003)(76176999)(54356999)(42882006)(6916009)(38730400002)(92566002)(61506002)(2950100002)(7736002)(305945005)(106356001)(6246003)(110136004)(4001350100001)(2906002)(97736004)(83506001)(229853002)(6506006)(3846002)(6116002)(9686003)(50986999)(25786008)(8676002)(5009440100003)(50466002)(55016002)(81166006)(6666003)(68736007)(5660300001)(81156014)(101416001)(7099028)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:6VIr2YOBV2aX5sv+6r4RoG0pp9BYH9wsv3eZ46B?= =?us-ascii?Q?5sy2uANWDlCgGYGwdZxl8CHkFmG4PaXB0Q93kB0Jqm5u+3r8SgQHoeJzLYae?= =?us-ascii?Q?Zfw7CdznVdm9AUs2ImBvlxG90JMkkuG8Xpww1NThMf9T81PN73YvhR6+hy8q?= =?us-ascii?Q?pYL0pzw4bp6df4a9Vxhdz+rmxnKZG4TmI99gWARlH76d1UlijJqCj14IbKug?= =?us-ascii?Q?t+5nA0WJqo5ic8vkANHyuNoED5xROp26ZoIxRMnr86ry8eQr/U4VOu/EGH5U?= =?us-ascii?Q?aGXWZetQwyr9IuKdM47xI/9NObUW5+pIK1IglIHLTzuEGvoWiklx30JCdzId?= =?us-ascii?Q?pHz5GwzhEiqJcx1zoFwgQ88Qhz3yCpAbQgtGHedydtIjswjjXHiduC0g98tH?= =?us-ascii?Q?WrJTNPQDHUJ6Z/VQ+SX26UAZnTl2URo1F8BBglyYf6Xn1kZjzpT2dFoSCd8r?= =?us-ascii?Q?p7FHAYS8deLD+ko8351TCVUc/hQSdHmc9wjiXQVK4ABKo7+PPe7ANVUDvWF/?= =?us-ascii?Q?DFDFFndcXJwHXYY7YIMR1Xk2YuRJi5ft7Ll6Or184mM2cSl/h2xR8vsaYVVd?= =?us-ascii?Q?xLWmP5/oLaIdSnxMPm+0JHCVZu68yoatQt8tJi7vK67A9yibzXZwzq59XQ3j?= =?us-ascii?Q?fRfj7st605x7lj2jAXNcZCOPCeSYgeFy484hv/mu+9ZN3/2P+iNzTLK9t96P?= =?us-ascii?Q?FLbxCAsTT/Y754/UCMlgSbhuUZxcnBx4Aj/CGi+HwM76nr67gFl/DqbOTjq/?= =?us-ascii?Q?Tpzjm+Q0Uocum/76OVcQ4qLNAgJBcLxmR3uGLb81fjU4xgk0mlBG4JCnXvDv?= =?us-ascii?Q?3ALv2Gy6zeQUUBMMKIQl8ycJUT5nRTG3VMCiSJnmGSfmnv8CUAWP/oXr2vUp?= =?us-ascii?Q?mDOLaZGFAdDUVR3UFEm0BF0UTMAsrQ/DQj6PBqKelOpNHaHsWd6R5qok5cGS?= =?us-ascii?Q?Xo797EvreaIt1TaSdHL7jvnJAr/6tHuuo1vrVaS0+B6pZBaMtan+qVPiDvMS?= =?us-ascii?Q?GRvgHjnMafLQ/gYVN/2BS3BXHTbuNec9+QU4Y0x+XeAAkMnT2Xlz9tvnGUMC?= =?us-ascii?Q?Y5lzA113sRYM3oqsH9Mky4PGau6ojGrJHZ/gaojt+I2D9PkyTpIqIzPC/FgS?= =?us-ascii?Q?F3qPiz9HJUDCt5aqTNGD/GirG1YfQKnLuQE+BaJ5L8h/dNuab9q1TPNP0dqP?= =?us-ascii?Q?HMF9jB6BJcdNHXz9hGpJpn2PynrH8qBFRnQu+25FW0lKsLVfk6L4G467yq3Y?= =?us-ascii?Q?FISWl/Icd2z0Z+KRzfq37mMhSSBr7zk6YNHt7TIjzyh96tWoWrzimmKPDESy?= =?us-ascii?Q?Rxi01TPs/M95YtY93D6KNY5zfliE73TSlLi02i616th1H?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:770oWMsifBBR3QiEo43ub5bohhyR6j3hW4ZNfRKa475tkXqABJMTbU+e//1CFFzj4PtBwn4YFC0FjDKID/wyDDYENPYhLuhLafU2hR8kKmi/PpeEkJ5sm+TsPeeUPm7zSl3RMWmHcTz8NxSgX5PPxmb5PZ5dOsaOn0k46slTghnxQK9nULO+HQgLWQC7yOoavpWJWwz5SM9FhuZT0/nfcIJxhSv/DWXXYk7ftGxolpWNnhyWpbaJJSSis355AOUuRGRNi2GPj3zjcVFlGsdFzs9WPqzHJ1qIZj72U+P4/47uud2BQBzYdQOZZPu3KcoCoi4+pq4aVDcGjL7veVczXcdi8zIGpcQw2Bdr75X5eBXEUkDtsbCMS3CMrneEs3bqsjs3SJ4QDCqSNg42symw9Q==; 5:fu08Hs9cg3oXNTzqORtjH4qBCMpH8PzjF+BFGJsI/wYgQQIJOaWAn8DxRk6MaGNOJZ970sX1wX2/8LjsMO4Lf3eTLRAjBShoUfxWkTm69VE9GAQ87ZN16IxlsAA53T/SKw2bSvZgzqOd9JHU4J9CPQ==; 24:8LvfAuEw8L1redynFFwz2fwyqkdP4cnN6XnKvqwEoaIXDDFKhijwt/rNIgGXnrp/UyiJuIT3Y5NDX8B6291JPGE6exvOAQaJ46bge1ZV97E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:EKKy2zFsdy8qBhu+42iM8x2+WmUj+5eUec8nLKzxBl8q9ndc6R6vIYxVnbNQszv53dCQXA7cctJk5elgoWfd6sN3Y9vTstVClZ5wpipDXuUrVCYyxsAV7KVmd9D5GxQUgRXCXd+JoWnzBnsaxX00rSWXM9KVMAp0kyISuCzrioVYPioVpumVjT+BcJ1P0H1JInbxN2I7AHEYU8XcrwX9WqsDcmtwlxWrOX6+mPxc384VkjRi0jyCxlrch9iu5NYijnZYni3FVSWD5cr884zkQ1aHqPoGHtv9JSzzW6DxWVADy9XabsyND3eR6nvLeriUSykX0kUYsP/si9dlR2PNcA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2017 14:12:43.6894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH v2] tools: add tags and cscope index file generation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 14:12:48 -0000 On Mon, Feb 27, 2017 at 03:18:52PM +0100, Thomas Monjalon wrote: > 2017-01-17 14:11, Jerin Jacob: > > This script generates cscope, gtags, and tags > > index files based on EAL environment. > > (architecture and OS(linux/bsd)) > > > > Selection of the architecture and OS environment > > is based on dpdk configuration target(T=) > > What is the purpose of selecting a configuration? > Is it to go quicker in the implementation you are interested in? Yes. That is the hard part to do. > In that case, I think we need a catch-all option, because I like > being prompted by vim that several implementations exist and I can > choose one of them. OK. Then we can make T= as optional and if T= is not specified then script can take all the source files. Thoughts? > > > example usage: > > make tags T=x86_64-native-linuxapp-gcc > > make cscope T=x86_64-native-linuxapp-gcc > > make gtags T=x86_64-native-linuxapp-gcc > > > > Signed-off-by: Jerin Jacob > > Reviewed-by: Yuanhan Liu > > Reviewed-by: Ferruh Yigit > [...] > > .gitignore | 8 ++ > > devtools/tags.sh | 251 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > mk/rte.sdkroot.mk | 4 + > > 3 files changed, 263 insertions(+) > > I think build-tags.sh would be a better name. OK > > On the implementation, I have few comments: > - is there a way to re-use the skip list when including the related files? > - you can remove tile from this patch OK > And for the details: > - why a bash shebang where /bin/sh would be wider? I will change to /bin/sh > - verbose option should be -v (with getopts) OK > - please use $() instead of backquotes OK > - please avoid one-line functions used only once like doctags OK > > I can help you with this script if needed. OK. I can work on this next week, if you have time then feel free to take up this. >