From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 89CB42B86 for ; Tue, 28 Feb 2017 15:25:08 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2017 06:25:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="53968911" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga002.jf.intel.com with SMTP; 28 Feb 2017 06:25:05 -0800 Received: by (sSMTP sendmail emulation); Tue, 28 Feb 2017 14:25:04 +0000 Date: Tue, 28 Feb 2017 14:25:04 +0000 From: Bruce Richardson To: Aaron Conole Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20170228142504.GA15368@bricha3-MOBL3.ger.corp.intel.com> References: <20170225160309.31270-1-aconole@redhat.com> <20170227161811.12309-1-aconole@redhat.com> <20170227161811.12309-4-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227161811.12309-4-aconole@redhat.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v5 03/26] eal: No panic on hugepages info init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 14:25:08 -0000 On Mon, Feb 27, 2017 at 11:17:48AM -0500, Aaron Conole wrote: > When attempting to scan hugepages, signal to the eal.c that an error has > occurred, rather than performing a panic. > > Signed-off-by: Aaron Conole > --- > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > index 18858e2..4d47eaf 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > @@ -283,9 +283,11 @@ eal_hugepage_info_init(void) > struct dirent *dirent; > > dir = opendir(sys_dir_path); > - if (dir == NULL) > - rte_panic("Cannot open directory %s to read system hugepage " > + if (dir == NULL) { > + RTE_LOG(ERR, EAL, "Cannot open directory %s to read system hugepage " > "info\n", sys_dir_path); > + return -1; > + } Minor nit. The error message should go on a line on its own, without any breaks to make it easy to "grep". This should also eliminate the checkpatch complaint about it being too long. /Bruce