From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D67062BAA for ; Tue, 28 Feb 2017 15:27:43 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2017 06:27:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="53970034" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga002.jf.intel.com with SMTP; 28 Feb 2017 06:27:40 -0800 Received: by (sSMTP sendmail emulation); Tue, 28 Feb 2017 14:27:39 +0000 Date: Tue, 28 Feb 2017 14:27:39 +0000 From: Bruce Richardson To: Aaron Conole Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20170228142739.GB15368@bricha3-MOBL3.ger.corp.intel.com> References: <20170225160309.31270-1-aconole@redhat.com> <20170227161811.12309-1-aconole@redhat.com> <20170227161811.12309-9-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227161811.12309-9-aconole@redhat.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v5 08/26] eal: do not panic on memzone initialization fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 14:27:44 -0000 On Mon, Feb 27, 2017 at 11:17:53AM -0500, Aaron Conole wrote: > When memzone initialization fails, report the error to the calling > application rather than panic(). Without a good way of detaching / > releasing hugepages, at this point the application will have to restart. > > Signed-off-by: Aaron Conole > --- > lib/librte_eal/linuxapp/eal/eal.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c > index a671ed4..1e54ca1 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -839,8 +839,11 @@ rte_eal_init(int argc, char **argv) > /* the directories are locked during eal_hugepage_info_init */ > eal_hugedirs_unlock(); > > - if (rte_eal_memzone_init() < 0) > - rte_panic("Cannot init memzone\n"); > + if (rte_eal_memzone_init() < 0) { > + RTE_LOG(ERR, EAL, "Cannot init memzone\n"); Any particular reason why not "rte_eal_init_alert" as with the other cases? /Bruce