From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 11BCA2B86 for ; Tue, 28 Feb 2017 15:45:19 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2017 06:45:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="62913596" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga004.jf.intel.com with SMTP; 28 Feb 2017 06:45:13 -0800 Received: by (sSMTP sendmail emulation); Tue, 28 Feb 2017 14:45:12 +0000 Date: Tue, 28 Feb 2017 14:45:12 +0000 From: Bruce Richardson To: Aaron Conole Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20170228144512.GC15368@bricha3-MOBL3.ger.corp.intel.com> References: <20170225160309.31270-1-aconole@redhat.com> <20170227161811.12309-1-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227161811.12309-1-aconole@redhat.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v5 00/26] linux/eal: Remove most causes of panic on init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 14:45:20 -0000 On Mon, Feb 27, 2017 at 11:17:45AM -0500, Aaron Conole wrote: > In many cases, it's enough to simply let the application know that the > call to initialize DPDK has failed. A complete halt can then be > decided by the application based on error returned (and the app could > even attempt a possible re-attempt after some corrective action by the > user or application). > Set looks pretty good. Just a couple of minor issues, apart from the one checkpatch issue I flagged: * seems to be some inconsistency between using the "rte_eal_init_alert" function and RTE_LOG. If there is some reason why some cases use the function and others don't I think that might need to be called out somewhere. * check-git-log flags a number of minor errors with commit titles and messages - most common is commit titles starting with a capital letter. Otherwise: Series-Acked-by: Bruce Richardson