From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41]) by dpdk.org (Postfix) with ESMTP id CFB9C2B9D for ; Wed, 1 Mar 2017 19:08:53 +0100 (CET) Received: by mail-pg0-f41.google.com with SMTP id 25so22739416pgy.0 for ; Wed, 01 Mar 2017 10:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4R6ZA67K4MKxm0usp2RiV5wLulwuidj3mLhi4QfGEGs=; b=ERgLGJ/wSjr42QL0CvJoP75oSYZzPithv1V/viG+l1IBh6g2r81euxk2O8Mzy32vaz PrbqmuJJ7wAiuRT8sRX/JgD+R4YzcBXgIIl/TXJeMs03bj3gpKa5CTSmKhGvwN7yj3K+ N+EXt9qW6FEzpu/LU96wunVqUyDlWK8TI3iz8uLH2t1Q4z5DtsMTLTkIaGS5YtX5mq5/ 5CmEs1YQNmGo5VWQvWg7wiAUsH2JJnGqmypR1mN0wyo6hQ2BI5NTc17LkVciCpTPpXOi k+KvV6lGIu+f2BaD6goeKLCZfSFn310o/6XwlPUAg7r3amAj6eUYJiRcKHXZPODpQFCF GtQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4R6ZA67K4MKxm0usp2RiV5wLulwuidj3mLhi4QfGEGs=; b=BwzpLR0pMw8O3PNGEOTqdRHVQw2TMrE8tFC8jtoyVyiSd7PZv/ySjhFHz4n5upLRdA 6CFG7RHLBuciQ5/I+7DF7Cr38MrTmmyvQv+ujActAwyRu+cssUthBcC0c7JfwhNSEzuZ X9L/tK13vJ0LZTqMcLTUmL99PVv/KXUXscmHDOPVL/g3Pn+gw5rV704DbbhZ7L2n262T 6hV1YxEB6PHzylUBCIjRaPPVycYr0BNovI+/FIwBqFQefwzvPEAzi861stfetXbzm/CJ Yvbhf4zZS7M9GWB6Ht7pmrohKYzcZd2Z0mYR51GMIr/N91/cN7Pclg/9VUSEcRIBBE0X duXA== X-Gm-Message-State: AMke39mWmwkckLHPDw7h81xZubVybyE/RTmO/ANJc9ItFcXGTTWhpT3pQeH1uiX8eCwi5A== X-Received: by 10.99.164.18 with SMTP id c18mr10388744pgf.40.1488391732917; Wed, 01 Mar 2017 10:08:52 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id u14sm11928269pfg.18.2017.03.01.10.08.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Mar 2017 10:08:52 -0800 (PST) Date: Wed, 1 Mar 2017 10:08:51 -0800 From: Stephen Hemminger To: Allain Legacy Cc: , Message-ID: <20170301100851.60c3e46c@xeon-e3> In-Reply-To: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> References: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devtools: add long lines to the list of options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 18:08:54 -0000 On Wed, 1 Mar 2017 12:44:19 -0500 Allain Legacy wrote: > The checkpatch.pl tool is flagging warnings on long debug log strings. > Since splitting these strings makes it difficult to search for logs it is > preferred to allow these as exceptions to the long line rule. The addition > of the LONG_LINE_STRINGS to the list of exceptions will allow lines that > end with a string to exceed the maximum line length, but lines that end > with variables or other constructs will still be flagged as errors. Also, > lines that make use of PRIx64 with string concatenation will still be > flagged if the beginning of the last string fragment begins after the 80 > character threshold. > > Signed-off-by: Allain Legacy > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 78e155e..26ff419 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING" > > print_usage () { > cat <<- END_OF_HELP Maybe it is time to have our own DPDK version of checkpatch which knows about DPDK API's like logging functions?