From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 74199F8C0 for ; Thu, 2 Mar 2017 14:04:37 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n11so23578320wma.1 for ; Thu, 02 Mar 2017 05:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PMA+/PiB3yA7pHUgpls1KkZCgCd+ozrzZhwM+ePD/EA=; b=SgecFcd0Hc1ClS+AKSeKO/JZUWwz4NVx6fGbBZ3MWw50vyWI004mZKRAHCI1zIesEz fINQiUy3KlKfyjaVjIasO6JFFyVb1yZvkI80eJly4MhFeSHRKXdjCQFs5pljf8Obo4kZ 5YkDOdIwZ24bl2R+0FAIw+EpqplsRsudIDnE1oG6Vd30BBJw3Ma/ZcRRM+2bJ80rtdlO 2ZgW242PrGCFzhdv8Fc/9whsboEy59zWzG0K4FFo5bhjjkGZiBis4FI1jY5Hgx2XXfn2 5U+NWWT9BdmJfb5U82NuxKHNPxniEturAdY5DMcBlAKpB9QIROXvgCPe2OFt3ZqU48cK JpNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PMA+/PiB3yA7pHUgpls1KkZCgCd+ozrzZhwM+ePD/EA=; b=V0UHdE7MHMZf9py2RsYGe7KwrxcgsaKPDJgRmKZ0V6JLlq3TUchti/rFsJKe8l/j1k 4F2hkGe2cqTDWF84uyVuzR9HfHTWG0N3tlVUuWS3evYvNOzisUn1eW4Wwp/HWMCyg/ZG gDVAjiKEhzbFaOTgK9ZAo2zJd1cDDAczHmNWEoY58knwULbLIlZ3PN6OMFiLxx1co+Yz /vnx2DPdXtegREUQwe42CHVOuz9WEWWYKk5oroweJSsgvwDAfdC7EZD9fWL9cmu3+WUU g2PMw+WOWF8hbysSpfNI2YQkhyEGasuqveL+JjuktPmNQMPQWymqmXWu8g8EitQI1SUC DA7w== X-Gm-Message-State: AMke39m65VX8kmx8c4wgIa/EVoKq0V1699xsTR8u3gEGP8N8ChLqtnPiFHRj66qAlWNlKVDx X-Received: by 10.28.97.194 with SMTP id v185mr7993252wmb.117.1488459876948; Thu, 02 Mar 2017 05:04:36 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r195sm27141604wme.25.2017.03.02.05.04.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Mar 2017 05:04:36 -0800 (PST) Date: Thu, 2 Mar 2017 14:04:28 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Stephen Hemminger Cc: Allain Legacy , thomas.monjalon@6wind.com, dev@dpdk.org Message-ID: <20170302130428.GE1821@bidouze.vm.6wind.com> References: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> <20170301100851.60c3e46c@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170301100851.60c3e46c@xeon-e3> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] devtools: add long lines to the list of options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 13:04:37 -0000 On Wed, Mar 01, 2017 at 10:08:51AM -0800, Stephen Hemminger wrote: >On Wed, 1 Mar 2017 12:44:19 -0500 >Allain Legacy wrote: > >> The checkpatch.pl tool is flagging warnings on long debug log strings. >> Since splitting these strings makes it difficult to search for logs it is >> preferred to allow these as exceptions to the long line rule. The addition >> of the LONG_LINE_STRINGS to the list of exceptions will allow lines that >> end with a string to exceed the maximum line length, but lines that end >> with variables or other constructs will still be flagged as errors. Also, >> lines that make use of PRIx64 with string concatenation will still be >> flagged if the beginning of the last string fragment begins after the 80 >> character threshold. >> >> Signed-off-by: Allain Legacy >> --- >> devtools/checkpatches.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >> index 78e155e..26ff419 100755 >> --- a/devtools/checkpatches.sh >> +++ b/devtools/checkpatches.sh >> @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ >> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ >> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ >> SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ >> -NEW_TYPEDEFS,COMPARISON_TO_NULL" >> +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING" >> >> print_usage () { >> cat <<- END_OF_HELP > >Maybe it is time to have our own DPDK version of checkpatch which knows about >DPDK API's like logging functions? Additionally, accepting the format strings PRIu8 and consort would be nice, as they are currently flagged as CamelCase. Same as some EAL functions (like eal_parse_pci_DomBDF and eal_parse_pci_BDF), but renaming those could be a better solution. -- Gaëtan Rivet 6WIND