From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 0DDBC6787 for ; Thu, 2 Mar 2017 14:58:32 +0100 (CET) Received: by mail-wr0-f175.google.com with SMTP id g10so52689792wrg.2 for ; Thu, 02 Mar 2017 05:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=49BU4cFB+WZsSYyd4IBJQFnrIzzgVPFUulCubkNmIng=; b=z/Twx7LPedgY3Q+zX+S/PEkpS4krSobAaVursxUVGmCnpntkCFekB4WsxXYEEXLeve uT0QYRqvDNqZ8Q1gk1J2q+mC0gZkYU/vdmgEg7umb+bN+6pzldBVd5P0VLGVxzZ0N1eu 63nPPjLv24h/NjWL8EUr67az9YimR9K7naeUeqKDA0zowohM2/JWxfBwQfG0P3qN15Hx bOb+7c/eMR+njtrKWnfQ8+1ISrCQ3Jj3soIPzRBcns38sV3+0T5yRYkV6elJJxpgCMEy aGnWGTrjgEd4r0RYEIG94dmgXzC2pDoeylUI+f/Fn48/Du9dD6tgkGCXmycc9PoyeqdE C7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=49BU4cFB+WZsSYyd4IBJQFnrIzzgVPFUulCubkNmIng=; b=W2N0qxrrFChIuguyFv0Zes3MYwZVxvRc8wdKkpbCqzPYUGBCSCaZRZgbvPjZPOn2X/ Xmy6X+xqgkIBo1eo9lueNVaRu4y+a2shV3giyoenFycAQo/ZKx4wIo1b5V31NcYJYrNg Ojmd/Nk7xrufJZf2KWNNpSiznKNDi6Gh5SrVhva2C2xPTYpRmDdzDCWFrdoduERxSZun +Rww2Fzp/FNRlgI0oSkAtTfZ/zBnE8NxeVDGkE7XSfXIRSysWxivFGLNUPU2p79dcQgF hiclQ4QjmG0eDRBdz5BIP5nqroZ2YM5rBjySOZfsLdf3MyJyJyJ3RRrasbF20LWh4aAg +s8A== X-Gm-Message-State: AMke39mIJkOIW9zmvNwChc/UKKbtpWja2kClM0Zc75zSKUXRdt///zVXkPpJAX7YM4ermfvB X-Received: by 10.223.177.207 with SMTP id r15mr14105036wra.127.1488463111853; Thu, 02 Mar 2017 05:58:31 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id v201sm2088309wmv.0.2017.03.02.05.58.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2017 05:58:31 -0800 (PST) Date: Thu, 2 Mar 2017 14:58:29 +0100 From: Olivier Matz To: "Lu, Wenzhuo" Cc: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "Ananyev, Konstantin" , "Zhang, Helin" , "Wu, Jingjing" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "Yigit, Ferruh" , "Richardson, Bruce" Message-ID: <20170302145829.0238fe57@platinum> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B569F84@shsmsx102.ccr.corp.intel.com> References: <1479981261-19512-1-git-send-email-olivier.matz@6wind.com> <1488388752-1819-1-git-send-email-olivier.matz@6wind.com> <1488388752-1819-4-git-send-email-olivier.matz@6wind.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B569F84@shsmsx102.ccr.corp.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/6] net/e1000: implement descriptor status API (igb) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 13:58:32 -0000 Hi Wenzhuo, On Thu, 2 Mar 2017 01:28:21 +0000, "Lu, Wenzhuo" wrote: > Hi Olivier, > > > -----Original Message----- > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > Sent: Thursday, March 2, 2017 1:19 AM > > To: dev@dpdk.org; thomas.monjalon@6wind.com; Ananyev, Konstantin; Lu, > > Wenzhuo; Zhang, Helin; Wu, Jingjing; adrien.mazarguil@6wind.com; > > nelio.laranjeiro@6wind.com > > Cc: Yigit, Ferruh; Richardson, Bruce > > Subject: [PATCH 3/6] net/e1000: implement descriptor status API (igb) > > > > Signed-off-by: Olivier Matz > > + > > +int > > +eth_igb_tx_descriptor_status(struct rte_eth_dev *dev, uint16_t tx_queue_id, > > + uint16_t offset) > > +{ > > + volatile uint32_t *status; > > + struct igb_tx_queue *txq; > > + uint32_t desc; > > + > > + txq = dev->data->tx_queues[tx_queue_id]; > > + if (unlikely(offset >= txq->nb_tx_desc)) > > + return -EINVAL; > > + > > + desc = txq->tx_tail + offset; > Should we check nb_tx_desc here? The same for em. Correct, thanks. Olivier