From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com
 [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 7AC08FA43
 for <dev@dpdk.org>; Mon,  6 Mar 2017 17:46:22 +0100 (CET)
Received: by mail-pf0-f174.google.com with SMTP id w189so62532732pfb.0
 for <dev@dpdk.org>; Mon, 06 Mar 2017 08:46:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=KAnkLbClYKASR7u6oswn8oVfFsA99sEihA7hwEk4aEU=;
 b=bF/+ims+K7t5YRFilUuJkHmpDRn99m3oJc6zGLO0Xeaz3V6OHSq8WBVsMgpSYuJQJs
 1QbWIPJbzStD+HCKEsU5IX5gVgmgVlbURDtLeaxvA5lBGVaXbF9W/1vZBpEccCmg2tGH
 7M2KDugqPPOLsVL2rGCWgaaceny2IpiDgV7gmCwVeh6hjiXKjIS85yIgmFd8YO4GjuKQ
 Mrb7d5rcJpZKJqITVaMRVGbTFZ95eIiACY5ymWDOhnnb/fwKYOGI5jvlpl/DJHYwFOcf
 0PZ0d0EBPsqi8Jxe0rxWzAwMiLzeHZrmWbEbtGscF6Iy9GyhtsV6VtGSqsPjr9qZswZL
 rqyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=KAnkLbClYKASR7u6oswn8oVfFsA99sEihA7hwEk4aEU=;
 b=kkRFtwh9TBf6aEhjM8Sm4ifwTqEp2+gq3JkfPDVMqYSoQf0DWdW0MChb1ge0fVQuGo
 sgOFVZjTktFIfd6X2DQK8M+5r95LUQg1tGvxGdk1XYMYP26EZa3ZMfoy6u6uC3mfRZ2N
 AKP6//Qb/TwMum8aAXi1hNDqoJ5bc5JZL6eljy6Ti5l9FtAj+vjDSPg1lgrgoaNpTLdl
 raT9yG4PRksOM6erWHvQLYBWIwU+V6rZ7YrRTfjhsK4fQ7m8ldziSdwCnI83fuP8GB6L
 RKCelq4j2FlUxNgNP+B2rmKica6sC6PKpc/Er4FeYBaRJ6B214VOd6+miMovgXY1f7ka
 PebA==
X-Gm-Message-State: AMke39kO3ZO6FhL03gQ+poL8t37PGScJc81RU7LE0LDk1hduepnoVeEQxo6nyHl3hTJ2QQ==
X-Received: by 10.99.114.6 with SMTP id n6mr21698168pgc.14.1488818781794;
 Mon, 06 Mar 2017 08:46:21 -0800 (PST)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id m6sm40618577pfg.126.2017.03.06.08.46.21
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 06 Mar 2017 08:46:21 -0800 (PST)
Date: Mon, 6 Mar 2017 08:46:19 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com
Message-ID: <20170306084620.5bb094b5@xeon-e3>
In-Reply-To: <1488660259-6228-3-git-send-email-rkerur@gmail.com>
References: <1488660259-6228-1-git-send-email-rkerur@gmail.com>
 <1488660259-6228-3-git-send-email-rkerur@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [v3 2/3] LPM config file read option.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Mar 2017 16:46:22 -0000

On Sat,  4 Mar 2017 12:44:18 -0800
Ravi Kerur <rkerur@gmail.com> wrote:

> +/* Bypass comment and empty lines */
> +static inline int
> +is_bypass_line(char *buff)
> +{
> +	int i = 0;
> +
> +	/* comment line */
> +	if (buff[0] == COMMENT_LEAD_CHAR)
> +		return 1;
> +	/* empty line */
> +	while (buff[i] != '\0') {
> +		if (!isspace(buff[i]))
> +			return 0;
> +		i++;
> +	}
> +	return 1;
> +}

This is not performance crtitical should not be inline.
The argument is never modified and therefore should be "const char *buff"