Re: [dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue

Re: [dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue

[Van Haaren, Harry]

> -----Original Message-----
> From: Nipun Gupta [mailto:nipun.gupta@nxp.com]
> Sent: Friday, February 10, 2017 3:48 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; jerin.jacob@caviumnetworks.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Eads, Gage <gage.eads@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Nipun Gupta <nipun.gupta@nxp.com>
> Subject: [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

Comment inline

> ---
> Changes for v2:
>  - Fix errors reported by check-git-log.sh
> 
>  lib/librte_eventdev/rte_eventdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index c2f9310..49a4739 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1216,7 +1216,7 @@ struct rte_eventdev {
>   *   - 0 no-wait, returns immediately if there is no event.
>   *   - >0 wait for the event, if the device is configured with
>   *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will wait until
> - *   the event available or *timeout_ticks* time.
> + *   atleast one event is available or *timeout_ticks* time.

at least should have a space between the words.

Send v3 with

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>


>   *   if the device is not configured with RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
>   *   then this function will wait until the event available or
>   *   *dequeue_timeout_ns* ns which was previously supplied to
> --
> 1.9.1

[dpdk-dev] [PATCH] eventdev: amend comment for timeout_ticks in rte_event_dequeue_burst()

[Nipun Gupta]

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 lib/librte_eventdev/rte_eventdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index c2f9310..49a4739 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -1216,7 +1216,7 @@ struct rte_eventdev {
  *   - 0 no-wait, returns immediately if there is no event.
  *   - >0 wait for the event, if the device is configured with
  *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will wait until
- *   the event available or *timeout_ticks* time.
+ *   atleast one event is available or *timeout_ticks* time.
  *   if the device is not configured with RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
  *   then this function will wait until the event available or
  *   *dequeue_timeout_ns* ns which was previously supplied to
-- 
1.9.1

[dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue

[Nipun Gupta]

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
Changes for v2:
 - Fix errors reported by check-git-log.sh

 lib/librte_eventdev/rte_eventdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index c2f9310..49a4739 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -1216,7 +1216,7 @@ struct rte_eventdev {
  *   - 0 no-wait, returns immediately if there is no event.
  *   - >0 wait for the event, if the device is configured with
  *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will wait until
- *   the event available or *timeout_ticks* time.
+ *   atleast one event is available or *timeout_ticks* time.
  *   if the device is not configured with RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
  *   then this function will wait until the event available or
  *   *dequeue_timeout_ns* ns which was previously supplied to
-- 
1.9.1

[dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

[Nipun Gupta]

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Changes for v2:
 - Fix errors reported by check-git-log.sh
Changes for v3:
 - Corrected comment's language

 lib/librte_eventdev/rte_eventdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index c2f9310..29f0f46 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -1216,7 +1216,7 @@ struct rte_eventdev {
  *   - 0 no-wait, returns immediately if there is no event.
  *   - >0 wait for the event, if the device is configured with
  *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will wait until
- *   the event available or *timeout_ticks* time.
+ *   at least one event is available or *timeout_ticks* time.
  *   if the device is not configured with RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
  *   then this function will wait until the event available or
  *   *dequeue_timeout_ns* ns which was previously supplied to
-- 
1.9.1

Re: [dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

[Jerin Jacob]

On Fri, Feb 10, 2017 at 09:56:50PM +0530, Nipun Gupta wrote:
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.

> ---
> Changes for v2:
>  - Fix errors reported by check-git-log.sh
> Changes for v3:
>  - Corrected comment's language
> 
>  lib/librte_eventdev/rte_eventdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index c2f9310..29f0f46 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1216,7 +1216,7 @@ struct rte_eventdev {
>   *   - 0 no-wait, returns immediately if there is no event.
>   *   - >0 wait for the event, if the device is configured with
>   *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will wait until
> - *   the event available or *timeout_ticks* time.
> + *   at least one event is available or *timeout_ticks* time.
>   *   if the device is not configured with RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
>   *   then this function will wait until the event available or
>   *   *dequeue_timeout_ns* ns which was previously supplied to
> -- 
> 1.9.1
> 

Re: [dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

[Nipun Gupta]

Thanks Jerin. Patchwork still shows this patch in new state.
Does this matter or shall I move it to accepted state?

Regards,
Nipun

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Monday, March 06, 2017 18:52
> To: Nipun Gupta <nipun.gupta@nxp.com>
> Cc: dev@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>;
> bruce.richardson@intel.com; gage.eads@intel.com;
> harry.van.haaren@intel.com
> Subject: Re: [PATCH v3] eventdev: amend timeout criteria comment for burst
> dequeue
> 
> On Fri, Feb 10, 2017 at 09:56:50PM +0530, Nipun Gupta wrote:
> > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Applied to dpdk-next-eventdev/master. Thanks.
> 
> > ---
> > Changes for v2:
> >  - Fix errors reported by check-git-log.sh
> > Changes for v3:
> >  - Corrected comment's language
> >
> >  lib/librte_eventdev/rte_eventdev.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eventdev/rte_eventdev.h
> b/lib/librte_eventdev/rte_eventdev.h
> > index c2f9310..29f0f46 100644
> > --- a/lib/librte_eventdev/rte_eventdev.h
> > +++ b/lib/librte_eventdev/rte_eventdev.h
> > @@ -1216,7 +1216,7 @@ struct rte_eventdev {
> >   *   - 0 no-wait, returns immediately if there is no event.
> >   *   - >0 wait for the event, if the device is configured with
> >   *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will
> wait until
> > - *   the event available or *timeout_ticks* time.
> > + *   at least one event is available or *timeout_ticks* time.
> >   *   if the device is not configured with
> RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
> >   *   then this function will wait until the event available or
> >   *   *dequeue_timeout_ns* ns which was previously supplied to
> > --
> > 1.9.1
> >

Re: [dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

[Jerin Jacob]

On Wed, Mar 08, 2017 at 07:29:03AM +0000, Nipun Gupta wrote:
> Thanks Jerin. Patchwork still shows this patch in new state.
> Does this matter or shall I move it to accepted state?

I have moved to accepted state.
Thanks.

> 
> Regards,
> Nipun
> 
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Monday, March 06, 2017 18:52
> > To: Nipun Gupta <nipun.gupta@nxp.com>
> > Cc: dev@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>;
> > bruce.richardson@intel.com; gage.eads@intel.com;
> > harry.van.haaren@intel.com
> > Subject: Re: [PATCH v3] eventdev: amend timeout criteria comment for burst
> > dequeue
> > 
> > On Fri, Feb 10, 2017 at 09:56:50PM +0530, Nipun Gupta wrote:
> > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> > > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> > 
> > Applied to dpdk-next-eventdev/master. Thanks.
> > 
> > > ---
> > > Changes for v2:
> > >  - Fix errors reported by check-git-log.sh
> > > Changes for v3:
> > >  - Corrected comment's language
> > >
> > >  lib/librte_eventdev/rte_eventdev.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/librte_eventdev/rte_eventdev.h
> > b/lib/librte_eventdev/rte_eventdev.h
> > > index c2f9310..29f0f46 100644
> > > --- a/lib/librte_eventdev/rte_eventdev.h
> > > +++ b/lib/librte_eventdev/rte_eventdev.h
> > > @@ -1216,7 +1216,7 @@ struct rte_eventdev {
> > >   *   - 0 no-wait, returns immediately if there is no event.
> > >   *   - >0 wait for the event, if the device is configured with
> > >   *   RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will
> > wait until
> > > - *   the event available or *timeout_ticks* time.
> > > + *   at least one event is available or *timeout_ticks* time.
> > >   *   if the device is not configured with
> > RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
> > >   *   then this function will wait until the event available or
> > >   *   *dequeue_timeout_ns* ns which was previously supplied to
> > > --
> > > 1.9.1
> > >