From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0089.outbound.protection.outlook.com [104.47.33.89]) by dpdk.org (Postfix) with ESMTP id CD8AC2C35 for ; Tue, 7 Mar 2017 07:50:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GzXiM+WFcTAWOhp65l4lhsRXg/miZGh4ZsiONW0dl90=; b=co2WLjTfWBFKQX8R7rgZfm1DJh+e1VhCb1fvSYgwlONq/o1A3FKmmPT4pQDDDbHMQOca3yBn8fbu/WQ4mNI8qS2Fuo7sCZel8gn13qRd46Ky3ZLMCn2yMu+xC7jF+2AiqBH99XBU3md8nj07z5NsHPcTrTnUjEXiW1WblcxUDwU= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (106.200.230.99) by BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Tue, 7 Mar 2017 06:50:30 +0000 Date: Tue, 7 Mar 2017 12:20:18 +0530 From: Jerin Jacob To: Nipun Gupta Cc: dev@dpdk.org, hemant.agrawal@nxp.com, bruce.richardson@intel.com, gage.eads@intel.com, harry.van.haaren@intel.com, shreyansh.jain@nxp.com Message-ID: <20170307065016.GA6339@localhost.localdomain> References: <1488555182-17881-1-git-send-email-nipun.gupta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488555182-17881-1-git-send-email-nipun.gupta@nxp.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [106.200.230.99] X-ClientProxiedBy: MA1PR01CA0084.INDPRD01.PROD.OUTLOOK.COM (10.174.56.24) To BN3PR0701MB1717.namprd07.prod.outlook.com (10.163.39.16) X-MS-Office365-Filtering-Correlation-Id: 14155b9a-c941-466e-4e30-08d4652640c5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 3:FWvTJkZzkA+Nkq4zwpl/t6eNIMkwr31lppxxRz18atgVJlYpy50NdT/iNhxqdhg6jQgrPElf6iZBoeJDQ54ashTQtk21xvIG3tLP9jeZ4+NH/nlRNRYSg9S+89qZ71OwxqezkIvDybLwRqTmq+TNyFSwPeQA2Epw4Ascx22NMj+y+ChU/4X4H/1xlizSYNS7+/XuRGBIwxqXz5CjjjjLKYdO5DQh4OfKs0I7mqI7L5A/S6ch+9Vt+rZgeAeww2J2lKWgr/JFx+HUp1SBIjmW5Q==; 25:BM4C+0haZ3biXnYjjfYUF+Cj5G+PJ1GFx5/61pE53OTw73UQuYr5Mw0tQs+z48A776Yfdv45IJ1a3jFJZYUVoAEVGF2QGMs4tDE2cAW8yRUkm1Mf8QIJ20liHTmjFmn16Zb0rB+S7iWzqqAQtFTx24AvOzmuoDUhAKCqKu7m/o8lI28dylfwoPfwNs50nELsU2if92G5PUdEs7hQeH1coCbKuyt+1wEcqtgVEuXO4SBhW2KkrszuVlpB9a5lb+DfHfOILr4ZJ51+CWeEKwwOOE4c6lt0cEh7UzjEDV2W9Vi8kPBqIpQ+g2skCnROkqnxsB+/kxZvzgpAeJ49OIY25Umt7Q1229S6VE0+M5d24/JDg6w9a3vxwaEB/+QmxjCJhmBKGOPMw0QBmpVVGEQjq4JAM3++GGoeQIFr2e66EOgAuoIJogHD7B0Y+A+j4G7jyqYMVHGTzz6sEoniJkAyMA== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 31:s/lqQ7RBhSdKQaZEEYQv6HvaeurAW2lp+m0QPMaVyWVkF1K9zUT4ngagHJDPy9DgDmTWIugLDQ65BFGEApggYwa6GFd3V9AM0Dq78FADKArSeh5xHgsVxmnzpp7YGZNfs6zIUcwF6KuhbloGJfSwOvhBfReG2FTnaAOjk1DZLKv83ii3khuyshmIZUXY7wPQiyxMT0Qa8HHAWxTan6dkmfTblV1dPrGUSVVPjHT2FZI2PJTP+JFhmgAe+A8/ut3O4nNe6JWSgf2g1RNA+xBm/g==; 20:zFE26X+c5akBcBa7fNCsjCMFkVkEJLn1Dsx2+jMqAwRWiBaoTeafOA3xY+EVs2W0vzm0rskMr33bI5yozLDp1HK3CY9AO1nzbjfvV5cr1NyNa82ph45A/TznB/5SJYPWxuf21CrY2rL9XAaJZQL3pki9zP2b2h56PTaXT5cs4QlKHKp3w6dIWHYHmvkKdlL/Z/5L02a89B2rLfuC7ffetD+2NtjBu/HDuH/0XL+uQDn65vYwDJjm/y9q+PklIozZmRUaeI8Cl2+TyO+e6fiszZTuAL0NisSjW9L15Ec3FxlHbHbQ+YwLGTHxpfFxTl24ohGeJ1jRMcVfN0v6KOWW8yMRddFXGoP0tENjDk+E8IZQHo6mqCQPliutluZaOnFvIJmG06UqKsJ1eemTLac7EVXTBER7m8hZC8w/gtlKDlDBZ8zmTDh3B7mktKUteNx7i2V/UTXpII8r/4yqtkIeRLU5da5zU0To0HuezmzVtXSs3X/1Nhzrlx6/pPnE/df77gDFrqnCyemieHmHcS+NLDTOMR6q1xge0r0yGL7PkjmAzMqwDopWYFF9BvQAtYEuNkB/gswVbtLgUy1oFU0F0Zd2CkDwj0tfjJFGLfvy1gs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123558025)(20161123562025)(20161123560025)(20161123564025)(6072148); SRVR:BN3PR0701MB1717; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1717; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 4:eJXJg/wN7Np9vgTMSWDSyyAgYAn8ApxY1suK0nV/vDntffdk6oqu4mbeCj5AvY4fywSchsKN1CtCrlzqzlJZQjmj/Q7F7YBstYILmEvqu134L39oT1vSjxP2k6U7tpiRIXgWr9mlsnchH9wn5fSxFusLL6Pdapt37xhQKasablRN1a1ur3Gu+Y9wOAVp5imwTaC8swOBj/7wW3S1i6SST7+3CYMKV9Jj9icNGA/O+0HwK3Tb2LKrKdHjLfExqAASspYjnqc3izZdodTqEpx+DvubFkFzxushjHI2byLdRMHdKETCIjNTQa+nkkQy3ff5EZEG4pONdbnW6y9+czZfY2UgEOB3+E6rTIcX5w2iZPvDiKx9xmSiXOlJ3H/Mx7a3cAjQAQuLh9ZkuTqOSuI02fWxe0AmKoZcmCh7qCmE/rr2eaD6FhuC+Y1g2zWF1k5Sp4RA+AD88Xvk2IpYSEZh7z9A1o4e8XhKJzSs6PevRtvY2QsJSQ5JcZjaCAghWRHo2LFC+sslYGkM+g39DLW9aCQIz3ijOmheFvfTDsSRKAIYl4bb24uveakSow5DDN/rXCcsI/6Yvkr9wlzgxMz3b3FvKdJv8l/R+B6jZP+pOd16pnq/rmJxgVgAzuHUAieRJUdM6RSOAZjuHKS0idiYV8AP8v5p70vqm3KklPFz1zKBh/aQmQqDoksI1DoQTYzi X-Forefront-PRVS: 0239D46DB6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(24454002)(25786008)(81166006)(92566002)(83506001)(66066001)(2950100002)(8656002)(9686003)(55016002)(8676002)(6916009)(42882006)(575784001)(229853002)(5660300001)(6506006)(305945005)(7736002)(106356001)(42186005)(110136004)(1076002)(33656002)(4326008)(6666003)(50466002)(61506002)(6246003)(38730400002)(23726003)(6116002)(3846002)(53936002)(47776003)(4001350100001)(189998001)(54356999)(5009440100003)(2906002)(76176999)(50986999)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1717; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1717; 23:RW0tFXssQTNPBe/EnKzIA8KKx6sx4omu5ME6Ulg?= =?us-ascii?Q?dtIEx/5m5jVwmBmHrEGQdz0FI0fLJmEGVn3X/AYeH9ULxQHfaxTT3xY0hZ8Y?= =?us-ascii?Q?x6xJyIVO77LHL5rPZCadOF33QQgfQaSMuk4N5E4VjaKnmIHTyxa/u7aFwPEu?= =?us-ascii?Q?ux/tB4aX01URiof0Vm0hlQXaiS/Eyclu0z6MI+gLJDOn9DxIlClJD5Z5MNTs?= =?us-ascii?Q?AznJN313MWE7McXL3fe/kI8hGGcoQ0nPhg9kkeNUDuk5MBZg2mPo2Q2JnfJ6?= =?us-ascii?Q?D/PEbPP6HKKK++YApK35daP741j5kkmJjD7xGB3gKTZKYxUbj5SWRxMfugTJ?= =?us-ascii?Q?yv+6R7bz6Zqv51S7HMifO1tKNKDyH0df3uw5bihaOiSolHtYJW0L3OKjeTIu?= =?us-ascii?Q?rX888tuJKsyVsp3v+OuBhVzYRz4G48mspVON7pbOe3wkj6/OIZ2ICHPUbYu4?= =?us-ascii?Q?cyw+gP8R6I5P4zzSe7OL9VOZHVHvaGmUNj2vzWCNBZz3stJ0c/uYnzfjpWRq?= =?us-ascii?Q?ZTB+LZuM9xUAdfNJoaXpcoR1AN+HVT8zCfiqDdVd7EH1/qy9xRlX9RQWZxHf?= =?us-ascii?Q?ioOGo/PP0AWBmEqB3iMvN1sCc5YlmXo5zfvMXGGwaCWv4Xm9giuFw267hB3Z?= =?us-ascii?Q?0diWAN5v1GwlTtp/3ARRrOr2IhazNdrvUwr07ZE/CzGOzXPsSVcPZrz3wPnL?= =?us-ascii?Q?g1iUco6Njagk0+QbTCXatEGhp23kGLrFr7nh9ivFt+G3zD6wgZN5pUmwnKjC?= =?us-ascii?Q?WJHqLk3VW4ZQKsnzL/4mo5ySbmlYUJ8yAZQxYmbzbH4ASM8Vb8bcdzzyOUVq?= =?us-ascii?Q?YKIILlEWhHQqf9jM4AGZdS/+Ygb7IYlZ6+ku3qvgoRZ5GP6BoFBRIWndgdrT?= =?us-ascii?Q?9EW2vkqD35Fyc7IsOpA+hVx4PQ+ZNnwloFAPQvHSj0TKJqz/LifcAhrhK8gP?= =?us-ascii?Q?Kh6tQrJakwZvMTKa00hMH23zFiCeUzueiwi7n+0EqkvvRr7Wn2l/+cklFDje?= =?us-ascii?Q?03bj108dCfg1p57X4O8SB/QqMoWtOXfzJK6F37WV2/wfBYGzoCslLuZktC9e?= =?us-ascii?Q?48EFMA7N0Crv3Y1N4X4Vewwt+ym3Mbiw19hYlRNt3YOIk+AEfejaYD97M+6C?= =?us-ascii?Q?32CEM4UZd/Xld885je8gAxKBPJoV9cbaRCzZ0yp3g5iZCUvcgW4WWE0of4Z8?= =?us-ascii?Q?OjpH9Tk8hyLO0MQQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 6:rqvcJQ+A+bNxuRWSS16tsmWu2oXrFcISCNTF7r/V08LYghJln2kKl5SrHScScmeGuwLhEOEZV1yAKkBYKH6Jm7eur5wJ0Biv0niLTKfeLt02f0hqdZ2onSCOqeFDg0nNCDB7iO1Ow4YvCEr8QbX07ePeFfs7N3Wyzr3aU94NZvD8Oy+lDo6VywnDOEPD2tRKT/Imw7JMLmVSCP5KV5tm0+n3+Ny+CFcGluUUs7KbYA9HIoJfzg/7FPrgKPrClAm23NZfmiwtIY/9j4J1hswOUFnIBBuq1mmZQuV4EnNWLH7KHo1P2i6x5I60lP3cCNmoTfuoQru1/35ojZe2fStrLbslv2UW7eezQCo0gNRZf4cymizHwyCeNykUtvo/ueIRkI3thO4hxJGvGqx67rSqTA==; 5:kfV5V+UGiZ1MW5/MZK1KsQ51x8OQ0pMsjRumYh9s5VM73gPkmgSoJ1qVlKlGzg6awqqK5j0WN81RDcjdC2ivwqrqGe0wlCSLWKhCG38r7+GDWO68YhjVteBKH+EnT4gO8rPPdD2I7A3fs0019UoQ5decUgZa5+EkuyBwV0x+Y5Q=; 24:a6HAOGvcy2Z1FgBjdaRQc9BZ3A55J8qejaYX6bDlOWBrmvulpq8K8Whq1nrzoTiv+n5qvEwKOgwkg+Kco8KaOZhwkQm426hW37SnaATv6u0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1717; 7:Fko+aUZ8HnnoQzWg90REF3I3IVaOqvq0Cz0CLZ9JolLos5iM5JzD/4+u8jBoN2Yecko9TX1y32FVn+oVMwrkBhnXyAEesX+b8r/ydMkcSDsLpjgtp/NiimhcZlCQFb0fQMl/4MuUHYD1/4uKB6DZU6wC4Z1JBtJ+CzywSkdp4K6sOYpS6vjie6snoXoV/t6e1IRJc51NUlzPs89VWuUYobjTcLJwSjwyxKC2DXIAsU59jHoIOGbTwj881hSfnFzE4m2+6KKJISDMV5MK1YZ0R95qKxjBK0vQQo9yfZ1crLVAcLJlDcnnV4pqvz0byfo8NeAZoMBQaTILlsvTQKdKrA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2017 06:50:30.7947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1717 Subject: Re: [dpdk-dev] [PATCH v2] eventdev: event device to contain rte device holder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 06:50:36 -0000 On Fri, Mar 03, 2017 at 09:03:02PM +0530, Nipun Gupta wrote: > rte_device is a generic device which is available to the applications > and EAL. This patch replaces rte_pci_device in 'struct rte_eventdev' > and in 'struct rte_event_dev_info' with common rte_device. Does anyone have any objection on this patch? If not, I would like to apply this patch to next-eventdev tree > > Signed-off-by: Nipun Gupta > Acked-by: Shreyansh Jain Nipun, Looks like this patch is not sent with "--in-reply-to". Please check the same in future patches. > --- > drivers/event/skeleton/skeleton_eventdev.c | 2 +- > lib/librte_eventdev/rte_eventdev.c | 6 +++--- > lib/librte_eventdev/rte_eventdev.h | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c > index dee0faf..770dce3 100644 > --- a/drivers/event/skeleton/skeleton_eventdev.c > +++ b/drivers/event/skeleton/skeleton_eventdev.c > @@ -383,7 +383,7 @@ > if (rte_eal_process_type() != RTE_PROC_PRIMARY) > return 0; > > - pci_dev = eventdev->pci_dev; > + pci_dev = RTE_DEV_TO_PCI(eventdev->dev); > > skel->reg_base = (uintptr_t)pci_dev->mem_resource[0].addr; > if (!skel->reg_base) { > diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c > index 68bfc3b..b8be5da 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -125,7 +125,7 @@ > > dev_info->dequeue_timeout_ns = dev->data->dev_conf.dequeue_timeout_ns; > > - dev_info->pci_dev = dev->pci_dev; > + dev_info->dev = dev->dev; > if (dev->driver) > dev_info->driver_name = dev->driver->pci_drv.driver.name; > return 0; > @@ -1196,7 +1196,7 @@ struct rte_eventdev * > "device data"); > } > > - eventdev->pci_dev = pci_dev; > + eventdev->dev = &pci_dev->device; > eventdev->driver = eventdrv; > > /* Invoke PMD device initialization function */ > @@ -1250,7 +1250,7 @@ struct rte_eventdev * > /* Free event device */ > rte_event_pmd_release(eventdev); > > - eventdev->pci_dev = NULL; > + eventdev->dev = NULL; > eventdev->driver = NULL; > > return 0; > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 7073987..6140078 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -330,7 +330,7 @@ > */ > struct rte_event_dev_info { > const char *driver_name; /**< Event driver name */ > - struct rte_pci_device *pci_dev; /**< PCI information */ > + struct rte_device *dev; /**< Device information */ > uint32_t min_dequeue_timeout_ns; > /**< Minimum supported global dequeue timeout(ns) by this device */ > uint32_t max_dequeue_timeout_ns; > @@ -1059,8 +1059,8 @@ struct rte_eventdev { > /**< Pointer to device data */ > const struct rte_eventdev_ops *dev_ops; > /**< Functions exported by PMD */ > - struct rte_pci_device *pci_dev; > - /**< PCI info. supplied by probing */ > + struct rte_device *dev; > + /**< Device info. supplied by probing */ > const struct rte_eventdev_driver *driver; > /**< Driver for this device */ > > -- > 1.9.1 >