From: Stephen Hemminger <stephen@networkplumber.org>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: DPDK <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] New CLI for DPDK
Date: Fri, 10 Mar 2017 08:06:04 -0800 [thread overview]
Message-ID: <20170310080604.66c9f168@xeon-e3> (raw)
In-Reply-To: <A418976B-0C9D-46AD-9E72-DE5E1F4C3E63@intel.com>
On Fri, 10 Mar 2017 15:25:31 +0000
"Wiles, Keith" <keith.wiles@intel.com> wrote:
> I would like to request for comments on a new CLI design and get any feedback. I have attached the cli.rst text, which is still a work in progress for you review.
>
> I have also ported the CLI to a version of Pktgen on the ‘dev’ branch of the repo in DPDK.org.
>
> http://dpdk.org/browse/apps/pktgen-dpdk/refs/?h=dev
>
> I would like to submit the CLI library to be used in DPDK, if that seems reasonable to everyone. I need more testing of the API and Pktgen, but I feel it has a simpler design, easier to understand and hopefully make it easier for developers to add commands.
>
> As an example I quickly converted over testpmd from CMDLINE to CLI (I just add a -I option to select CLI instead) and reduced the test-pmd/cmdline.c file from 12.6K lines to about 4.5K lines. I did not fully test the code, but the ones I did test seem to work.
>
> I do not expect DPDK to convert to the new CLI only if it makes sense and I am not suggesting to replace CMDLINE library.
>
> If you play with the new CLI in pktgen and see any problems or want to suggest new features or changes please let me know.
>
> Comments on the cli.rst text is also welcome, but the cli.rst is not complete. I think this file needs to be broken into two one to explain the example and another to explain CLI internals.
>
It would be great if all DPDK examples used a similar architecture. And having a common
infrastructure would help.
But not sure it needs to be special. Why should this be DPDK specific?
What you are building really ends up being an application
framework at some point. Surely, there are lots of others already in open source.
Heck even VPP has its own CLI inside.
next prev parent reply other threads:[~2017-03-10 16:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 15:25 Wiles, Keith
2017-03-10 16:06 ` Stephen Hemminger [this message]
2017-03-10 16:22 ` Wiles, Keith
2017-03-10 16:41 ` Stephen Hemminger
2017-03-10 17:04 ` Wiles, Keith
2017-03-23 16:13 ` Wiles, Keith
2017-03-24 13:09 ` Olivier Matz
2017-03-24 14:48 ` Wiles, Keith
2017-03-28 10:06 ` Thomas Monjalon
2017-03-28 13:19 ` Wiles, Keith
2017-03-28 13:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310080604.66c9f168@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).