From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id F334537A6 for ; Fri, 10 Mar 2017 18:12:11 +0100 (CET) Received: by mail-wr0-f171.google.com with SMTP id u48so68987262wrc.0 for ; Fri, 10 Mar 2017 09:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TiCioQd1rY7g1OP9JoVT7SXBQwoCzofry0yV2td0Jpc=; b=0A/Daj9CLc5oKqUHSZqAnEBQMjF1zjpQ8PZBnj46y8eFIYipRoOv66D+Jqe42DqOCF 7cs30JXqWPMP03K8uEVgbSUl585DCx1UPXIzwLNLt8ohtzNeMyi6GmPvh6BHmDpuNbPt Me8m5CpQ6nYkeXaihgBFs2KL5nUcPFWjX4hbNVOUD8QWJJP9w2PGJ94vfNCrIyI67tai kEF8KBEZQPhySB/8DpjWOoR49kHbYy8cdovksvIylZDflMnQCSGjVTWuEjeq+s3kOa1Y jdLQ69L52Z1Q2eyK77IQMpqVoEqbGUIMCyf0N1ifcw2mC7bWBT6wsA5em0UiJT/j+VIu e5yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TiCioQd1rY7g1OP9JoVT7SXBQwoCzofry0yV2td0Jpc=; b=Hoj+fWSBZACkEx5lmnr/0QBP9vdCufoDWnzFztPJZ8WCqjhHmBQD6qmIOfGz1bhKy6 63i1MwISHnbXlG5ur5y+RRtDlpyZj+6m3E0+fBrnb9bmLDx0lwmBKt+GgXcjMn0cPx32 OSznO/PKPR11P+isfuIklYUF5llYw0OcBIH42Z53RoCiSsYW+jOA03jJom8tezrikfAn 78mryKCiPKdvM5IiNwhtGgRcCKm9PvlIbZXNGyBH83Ovuswrvwf/nHHIN/k6bBPGp8dh i0Ymly1fbOF79w0lu1+b7Bw8rdP3xUYuxCkiiQSsrMrQNV4UEyFig97hf47TE0NbnlIg NJyQ== X-Gm-Message-State: AMke39n4DMuzta/ilMY9Q3RMtCCDFLPe4mH8isfW1Z+Z0h58R1tZTMktwxSkMfyBVhowB069 X-Received: by 10.223.162.212 with SMTP id t20mr16080432wra.122.1489165928507; Fri, 10 Mar 2017 09:12:08 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w4sm4127629wmg.25.2017.03.10.09.12.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 09:12:07 -0800 (PST) Date: Fri, 10 Mar 2017 18:11:59 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: "Legacy, Allain" Cc: "dev@dpdk.org" , Adrien Mazarguil , Nelio Laranjeiro Message-ID: <20170310171159.GK908@bidouze.vm.6wind.com> References: <70A7408C6E1BFB41B192A929744D8523968EC82E@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <70A7408C6E1BFB41B192A929744D8523968EC82E@ALA-MBC.corp.ad.wrs.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 17:12:12 -0000 Hey, thanks for reading. On Fri, Mar 10, 2017 at 04:24:32PM +0000, Legacy, Allain wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet >> Sent: Friday, March 03, 2017 10:40 AM >... >> + errno = 0; >> + tmp = strtoul(val, NULL, 0); >The robustness of the strtoul() could be improved with something like the following to catch non-integer characters following the port number. > > char *end = NULL; > tmp = strtoull(val, &end, 0); > if ((val[0] == '\0') || (end == NULL) || (*end != '\0') || (errno != 0)) > > Thanks for the suggestion, I'd keep the strtoul though ;). I will see into it for the v2, keeping in mind Stephen's remarks as well. >> + if (errno) { >> + WARN("%s: \"%s\" is not a valid integer", key, val); >> + return -errno; >> + } >> + if (strcmp(MLX4_PMD_PORT_KVARG, key) == 0) { >> + if (tmp >= MLX4_PMD_MAX_PHYS_PORTS) { >> + ERROR("invalid port index %lu (max: %u)", >> + tmp, MLX4_PMD_MAX_PHYS_PORTS - 1); >> + return -EINVAL; >> + } >> + conf->active_ports |= 1 << tmp; >> + } else { >> + WARN("%s: unknown parameter", key); >> + return -EINVAL; >> + } >> + return 0; >> +} >The usage of strtoul() should be moved to be within the strcmp(MLX4_PMD_PORT_KVARG, key) IF statement. That way the "val" would only be parsed if "key" is "port" and it is expected that "val" is an integer. > > This function was aimed at being generic. If we consider that no other parameter would ever be added, then the strcmp should be scraped altogether, as this callback is only called upon parsing this parameter in the kvlist in the first place. But we are in the control path, avoiding a useless strtoul at the price of making the function less useful seems an unnecessary tradeoff to me. >> + if (mlx4_args(pci_dev->device.devargs, &conf)) { >> + ERROR("failed to process device arguments"); >> + goto error; >> + } >It would be helpful for debugging if the error message included the devargs so that we can see what is wrong with the input. > > Agreed. >> + /* Use all ports when none are defined */ >> + if (conf.active_ports == 0) { >> + for (i = 0; i < MLX4_PMD_MAX_PHYS_PORTS; i++) >> + conf.active_ports |= 1 << i; >> + } > >Rather than use a loop to populate all active fields would a #define with an all ports mask be better suited to this. Or alternatively just change the IF statement below to use the following and avoid the need for this loop altogether: > >if (conf.active_ports & !(conf.active_ports & (1 << i))) > continue; > > I do not agree with removing this loop. Your second solution will scatter the relevant bits concerning the default value of the active_port configuration option. While being slightly slicker it hides it unnecessarily from the reader. The first solution might be interesting, however it makes this option dependent on two defines instead of one. If one had to change the default MAX_PHYS_PORT value for mlx4 (however unlikely it might be), then they would have to change the valid ALL_PORTS mask as well. In principle this contradicts DRY[1]. [1]: https://en.wikipedia.org/wiki/Don't_repeat_yourself -- Gaëtan Rivet 6WIND