DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, bruce.richardson@intel.com,
	gage.eads@intel.com, harry.van.haaren@intel.com,
	shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: event device to contain rte device holder
Date: Mon, 13 Mar 2017 14:20:06 +0530	[thread overview]
Message-ID: <20170313085005.nwjzwh3ds2v5ty3h@localhost.localdomain> (raw)
In-Reply-To: <1488555182-17881-1-git-send-email-nipun.gupta@nxp.com>

On Fri, Mar 03, 2017 at 09:03:02PM +0530, Nipun Gupta wrote:
> rte_device is a generic device which is available to the applications
> and EAL. This patch replaces rte_pci_device in 'struct rte_eventdev'
> and in 'struct rte_event_dev_info' with common rte_device.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied to dpdk-next-eventdev/master. Thanks.

> ---
>  drivers/event/skeleton/skeleton_eventdev.c | 2 +-
>  lib/librte_eventdev/rte_eventdev.c         | 6 +++---
>  lib/librte_eventdev/rte_eventdev.h         | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c
> index dee0faf..770dce3 100644
> --- a/drivers/event/skeleton/skeleton_eventdev.c
> +++ b/drivers/event/skeleton/skeleton_eventdev.c
> @@ -383,7 +383,7 @@
>  	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
>  		return 0;
>  
> -	pci_dev = eventdev->pci_dev;
> +	pci_dev = RTE_DEV_TO_PCI(eventdev->dev);
>  
>  	skel->reg_base = (uintptr_t)pci_dev->mem_resource[0].addr;
>  	if (!skel->reg_base) {
> diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c
> index 68bfc3b..b8be5da 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -125,7 +125,7 @@
>  
>  	dev_info->dequeue_timeout_ns = dev->data->dev_conf.dequeue_timeout_ns;
>  
> -	dev_info->pci_dev = dev->pci_dev;
> +	dev_info->dev = dev->dev;
>  	if (dev->driver)
>  		dev_info->driver_name = dev->driver->pci_drv.driver.name;
>  	return 0;
> @@ -1196,7 +1196,7 @@ struct rte_eventdev *
>  					"device data");
>  	}
>  
> -	eventdev->pci_dev = pci_dev;
> +	eventdev->dev = &pci_dev->device;
>  	eventdev->driver = eventdrv;
>  
>  	/* Invoke PMD device initialization function */
> @@ -1250,7 +1250,7 @@ struct rte_eventdev *
>  	/* Free event device */
>  	rte_event_pmd_release(eventdev);
>  
> -	eventdev->pci_dev = NULL;
> +	eventdev->dev = NULL;
>  	eventdev->driver = NULL;
>  
>  	return 0;
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index 7073987..6140078 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -330,7 +330,7 @@
>   */
>  struct rte_event_dev_info {
>  	const char *driver_name;	/**< Event driver name */
> -	struct rte_pci_device *pci_dev;	/**< PCI information */
> +	struct rte_device *dev;	/**< Device information */
>  	uint32_t min_dequeue_timeout_ns;
>  	/**< Minimum supported global dequeue timeout(ns) by this device */
>  	uint32_t max_dequeue_timeout_ns;
> @@ -1059,8 +1059,8 @@ struct rte_eventdev {
>  	/**< Pointer to device data */
>  	const struct rte_eventdev_ops *dev_ops;
>  	/**< Functions exported by PMD */
> -	struct rte_pci_device *pci_dev;
> -	/**< PCI info. supplied by probing */
> +	struct rte_device *dev;
> +	/**< Device info. supplied by probing */
>  	const struct rte_eventdev_driver *driver;
>  	/**< Driver for this device */
>  
> -- 
> 1.9.1
> 

      parent reply	other threads:[~2017-03-13  8:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 15:33 Nipun Gupta
2017-03-07  6:50 ` Jerin Jacob
2017-03-13  8:50 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313085005.nwjzwh3ds2v5ty3h@localhost.localdomain \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=nipun.gupta@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).