From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id A5CA569F7 for ; Tue, 14 Mar 2017 10:46:42 +0100 (CET) Received: by mail-wr0-f180.google.com with SMTP id u108so119950324wrb.3 for ; Tue, 14 Mar 2017 02:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E090VOV6EelcTV9PW/Rv6um2V0/6qNXRAF0Ekm+l2wI=; b=Rkhpts6eqYF6myJ/QjnEk2UN9Yo3QomFKYArIlMBVwdEuUqWFmCwtXdF9eFUVOVciC VCa5cpE8vmu/nDZMRLDMTlqVh3G7YsiAeCu/YyfLRb6YnUNFw9FUU3kEGZSVvYRkBqHG pcZWcQ3r5nbbHfGbd3bVxrYWflsHVjKwNOzRH1wbxr4mrCJL+6KXVzRj5nFiKFTlwHAT NvNg+/FdzXBCv0Lnb2ewrrWcBvK7WJe+4SvxHE4gkE5+02lpxNjz0m66WoN8Yw/eo5xp u8YvCRoZ0uRSakO4WTfjL0KKt7YwjMXGUHG2scVjflYkqlg/5uixAQn0aL4TfmNhFDSF WPPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E090VOV6EelcTV9PW/Rv6um2V0/6qNXRAF0Ekm+l2wI=; b=YTGvFXvC4iSKA5FGni5LWrWlxbqJJeuc3iyxc5MzY0tCQCOoAARZ5cf5tf0jzN3QWo 0GzsBTbs9IyRhgezHZGX9lsQVokNXOfkEDcLxeg9TEI9EHUmdkeWnkto8zXxaa9EbmEe eMhP2X8ZGfq/mjM7oeqjKUhj7ieamPpz2OyakltGTSvYZ4FdZyLHgmK0kBymRRdCl+hT iNRiYF0Bjf7as7gpORJmxIdvJxsZx1SWZ+7Z1AscSVqXk2+MNWnq6S4+62xmFMduVYhH S2ZYK1OqBuWEOnxvli8fQwhOS7JqGzPn9+gDpBzcF30IdJGdCR9AdGLvEQUl5KmVTavT w9xw== X-Gm-Message-State: AMke39kV6dZyT4HErxxpciUZoPqi9umKQMJmITeHott8G0kQ4Knzvu9innfB2ZbK8L31JZye X-Received: by 10.223.133.182 with SMTP id 51mr33410775wrt.39.1489484802465; Tue, 14 Mar 2017 02:46:42 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id t30sm13317703wra.55.2017.03.14.02.46.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Mar 2017 02:46:42 -0700 (PDT) Date: Tue, 14 Mar 2017 10:46:40 +0100 From: Olivier Matz To: "Dai, Wei" Cc: "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" , Guo Fengtian , "stable@dpdk.org" Message-ID: <20170314104640.32b06adb@platinum> In-Reply-To: <20170216174922.720f83b9@platinum> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170206145858.41447b6e@platinum> <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com> <20170216174922.720f83b9@platinum> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 09:46:42 -0000 Hi Wei, On Thu, 16 Feb 2017 17:49:22 +0100, Olivier Matz wrote: > Hi Wei, > > On Thu, 9 Feb 2017 14:50:05 +0000, "Dai, Wei" wrote: > > > -----Original Message----- > > > From: Dai, Wei > > > Sent: Thursday, February 9, 2017 10:38 PM > > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > > Helin ; Ananyev, Konstantin > > > > > > Cc: Guo Fengtian ; stable@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after > > > a PF reset > > > > > > The stats register can rewind to zero when the port is running for > > > a long period. So I am afraid that this check is not always correct. > > > Why not introduce a variable to directly indicate whether the > > > resulted stats should be updated or not. > > > > Another way is to clear > > hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same > > time PF is set down. > > > > Can we know easily in VF if the PF was set down? Any guideline for this? Or is it something we cannot fix? Thanks, Olivier