From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 5F862A10 for ; Wed, 15 Mar 2017 14:45:31 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id n11so88040004wma.1 for ; Wed, 15 Mar 2017 06:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=UqAWD1rL4AcaRs1WjADH0RS8Z+RTH50v0PGvoDK21oc=; b=ibweSBa1XbLaSVMXMTkVPBngUAG1Jw72F7ysFUulNhGsOHjF2jMnFIqJCjuW7+B1GW AOErdLyMZIlxgxVSp6GVANAgWXF81aG0cxH5iKV5VFkKbsfcWzVuXlAanWmzcRQl0ArM J9yENI8n+hFHxtTSGJycuYJ1wI+0yaU6RALjhra1HMK4+LodVyNL4wl+z2P+3yQT2nRm Olc7ixgarh35IBf5s3H7iNt07Lu+qGDCmEb+9zNwqgA6yAwL8ZxjLzyFmtDfDBlnQxLF WbQdcFihvfCyUDoNGoVecZXMBXfGqQjZdCw+uA9yEOFmM7YJW46y8RMoHkr+yjT++D5N W42g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=UqAWD1rL4AcaRs1WjADH0RS8Z+RTH50v0PGvoDK21oc=; b=Lef8R3WIXEyvTGYr/jwZDDyRlOSm+FPzE/PdoG+a7kozqwmHSf09bqV+0LMiNlQzXd AI6rZYS37GFiD4iJzEUCkdadOl/9Zuus2LzUSBMc5xI1mXXM9LSPCOxiB41NaxvCT5b/ SovqcN8wo8Zv2L0sk2m/SUQ9m7vhIvw+yRwbM4Fg41MuKemvjHroIsdw5v/TOf0WGAHL Q0RwLSAKeyBTOnqoIlfg3BmnJxKQ905FMFv32Qp+E3F3lh3jvghzRsWvaVNUUuG3Xlbp dvpPgKfMLRRLnU9if4P5zokZNa6ZwMAFzf9+sRPfEhrACSG8akh1esQ48daIZPhh5Ck4 nQEQ== X-Gm-Message-State: AFeK/H3+Y7FFYbhWphYXLV2l3oZK595tgMaacGwAptzPSXJsHhhL2KXd7Igi7Nqm6YcKzpxk X-Received: by 10.28.54.89 with SMTP id d86mr18950609wma.137.1489585531177; Wed, 15 Mar 2017 06:45:31 -0700 (PDT) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t63sm557715wme.16.2017.03.15.06.45.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Mar 2017 06:45:30 -0700 (PDT) Date: Wed, 15 Mar 2017 14:44:12 +0100 From: Pascal Mazon To: Ferruh Yigit Cc: keith.wiles@intel.com, dev@dpdk.org Message-ID: <20170315144412.3a76d727@paques.dev.6wind.com> In-Reply-To: <725e6ac6-acc5-7adc-02a7-f1a6bf79f7bd@intel.com> References: <1488904298-31395-1-git-send-email-pascal.mazon@6wind.com> <972357ac96dcfa64ecd30bb2350f8282b858af03.1489479553.git.pascal.mazon@6wind.com> <725e6ac6-acc5-7adc-02a7-f1a6bf79f7bd@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 7/8] net/tap: add packet type management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 13:45:31 -0000 On Wed, 15 Mar 2017 13:35:44 +0000 Ferruh Yigit wrote: > On 3/14/2017 8:22 AM, Pascal Mazon wrote: > > Advertize packet types supported by the librte_net. > > > > Signed-off-by: Pascal Mazon > > <...> > > > > > #include > > #include > > @@ -228,6 +229,8 @@ pmd_rx_burst(void *queue, struct rte_mbuf > > **bufs, uint16_t nb_pkts) mbuf->data_len = len; > > mbuf->pkt_len = len; > > mbuf->port = rxq->in_port; > > + mbuf->packet_type = rte_net_get_ptype(mbuf, NULL, > > + > > RTE_PTYPE_ALL_MASK); > > This breaks shared library build [1], now librte_net also needs to be > linked against PMD, this can be done easily by adding library as > dependency [2] to PMD. > > > [1] > rte_eth_tap.o: In function `pmd_rx_burst': > .../drivers/net/tap/rte_eth_tap.c:(.text+0x863): undefined reference > to `rte_net_get_ptype' > > > [2] > --- a/drivers/net/tap/Makefile > +++ b/drivers/net/tap/Makefile > @@ -53,5 +53,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += > lib/librte_mbuf DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += > lib/librte_mempool DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += > lib/librte_ether DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += > lib/librte_kvargs +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += > lib/librte_net > > include $(RTE_SDK)/mk/rte.lib.mk Indeed! I'll fix that and send a new version (rebased on the latest next-net, following adrien's changes to tap PMD). Regards, Pascal