From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) by dpdk.org (Postfix) with ESMTP id A24D6CF66 for ; Fri, 17 Mar 2017 17:14:17 +0100 (CET) Received: by mail-pg0-f48.google.com with SMTP id b129so44628377pgc.2 for ; Fri, 17 Mar 2017 09:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1IJJGFNlO+rNI+P4zbSygQQ7r2ZWEO+lf/FMK6xL4II=; b=j0rtgGJBu5ic7PYvvhzuzz85WAZoTATDG75RZfP7qTLYkl4mcKZgYhkrDp1onGOAOg z46ovH+RcYgmNrhQFOMFh42IVXaquTCiwwXtwqrXfaevBfEzXhKeXP2DoSDQqHRi5Ifz ixeTWCGuFW3n7dO4Ba6trw6rwo9oeTs7DfqYySZyZoLWg7UkLBy9AHJjXVLiIxZVl7AW 1f/jIJwGJlpw3j2HbboPBk1Jx9tin4pZ5Dm72nxxkc47OEuOX6nq3hKm4jhPcBrGyqXY D2dP6BaKcuPMWhkyGQS0aoSCuWUKm+XMy5NLv4b8xN8ZTW02vWy8xdSx39PZQAO0ZUwx x0gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1IJJGFNlO+rNI+P4zbSygQQ7r2ZWEO+lf/FMK6xL4II=; b=G9xO3IRTkoHxkC6s8mJUV3PvwQQCv09jvTO7J6VJBfzDInPgChjblA70v2zauRjmWl AEWNxXv+E7ML741D2j7trJIR5gMvF5+qHXl3M41MCA7PTPLp6peG5AaGaSHvzjYBjSbY jRr70wbtFc7mlAyhicujaOmGnRuzLdiZVUMfnmYuyr7/5wrXwkg++LejajFe5y0ogdXI qVZOlp+fcXIU6AvqhYTBuMKa/KsmXeGlE3xmz89qa3083kAqwGO3aAnQsUBJhy/5+6eQ jSC1at9NIFzGySnlMIW1qYOmggpt73vS8zslPT1KrgRBN9T7df7LcCk3pkSW8I/joZ7B r3CA== X-Gm-Message-State: AFeK/H31iTBdOn+ExWpM2XMVYCbHuDzL49NDlX4Z0VVi4oiI47wwR7NhJkQ66DAJkN3IKg== X-Received: by 10.98.82.216 with SMTP id g207mr17798501pfb.139.1489767256999; Fri, 17 Mar 2017 09:14:16 -0700 (PDT) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id i15sm17759700pfj.0.2017.03.17.09.14.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Mar 2017 09:14:16 -0700 (PDT) Date: Fri, 17 Mar 2017 09:14:10 -0700 From: Stephen Hemminger To: Olivier Matz Cc: dev@dpdk.org, thomas.monjalon@6wind.com, david.marchand@6wind.com, bruce.richardson@intel.com, keith.wiles@intel.com Message-ID: <20170317091410.6b27f914@xeon-e3> In-Reply-To: <1489765882-30497-2-git-send-email-olivier.matz@6wind.com> References: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com> <1489765882-30497-1-git-send-email-olivier.matz@6wind.com> <1489765882-30497-2-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/8] eal: support dynamic log types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2017 16:14:18 -0000 On Fri, 17 Mar 2017 16:51:15 +0100 Olivier Matz wrote: > if (type < RTE_LOGTYPE_FIRST_EXT_ID) { > + if (enable) > + rte_logs.type |= type; > + else > + rte_logs.type &= (~type) No need for () around ~type