From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41])
 by dpdk.org (Postfix) with ESMTP id B0222CFA8
 for <dev@dpdk.org>; Fri, 17 Mar 2017 17:17:31 +0100 (CET)
Received: by mail-pg0-f41.google.com with SMTP id g2so44577812pge.3
 for <dev@dpdk.org>; Fri, 17 Mar 2017 09:17:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=tStGcJuWm1Bh5ev+kEOL+9clhJrdk99j4B2FwVqWVys=;
 b=H1mECXsgTZffueTvmz+TYzNsLZBURa6YzMCHnPUbigHQ9h3bU94nnFZJFAeVboQvRK
 MegD1PTeLuJE7HY0r0gzV23pB+M4gnSXl1Xwuv0QP2Yb0DHSRyBEXlAfsnOsnGi+2phy
 FM2ybc1xMmua+DhMsZ9nWpLG1BeXUBfF/xJz0ArVQx5SJrxr31ltR3VdSV0vcItgkDWV
 f3XzFXM/mnB8QzR1/hG9lMABLuGZ5Xy9Np1ic/DWYPrZIzreadwHKYqKHwJBaOiAjBK1
 mXQHq2cWFQWWA8AwDLLy3p7y1cv5hl5i8ZiKmqyB7ikx4zz9qVrhDg07K8hLBv0F8sdk
 4hvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=tStGcJuWm1Bh5ev+kEOL+9clhJrdk99j4B2FwVqWVys=;
 b=lKrLTORdW42DLKdc700j46BBPOCGVlk0sgV6ca3mTYCqy0QGmcKrfI4YvlYa39B0e2
 f+5NOfcqDkPR3lCueeT69r5c5W0eGxsmIk6xTUuGRaUaMSJtYKFrVh6OQ5udjMPY1XYJ
 uulelk186aLJqJPUOE+KlgMHYV9PwYdqfU7lZ/RbcEeHWoBdwh1J78fWWcG0vlB7jWrM
 Gkn/+Io+/96ClCh/7Vw/YnWwSM17XXxfXQ+Kicm+rWYx0oUvMO3XTY8R0WoMdIj7jRc4
 V7lE903pd2JocfgNmv5WJd03byUteyTb+RWW9mP1O5vE6A4I5VqxL2nLVk7vGDFObhPu
 Z9Og==
X-Gm-Message-State: AFeK/H2XRHN5opDWhcPaj2KA5w3jtl/GIxVldW/PTJ9V6xNSRRAtTyRvhyeolcWT6i9XRw==
X-Received: by 10.99.116.10 with SMTP id p10mr16923192pgc.74.1489767450684;
 Fri, 17 Mar 2017 09:17:30 -0700 (PDT)
Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65])
 by smtp.gmail.com with ESMTPSA id p16sm17722926pfl.97.2017.03.17.09.17.30
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 17 Mar 2017 09:17:30 -0700 (PDT)
Date: Fri, 17 Mar 2017 09:17:23 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, david.marchand@6wind.com,
 bruce.richardson@intel.com, keith.wiles@intel.com
Message-ID: <20170317091723.38cfc7dd@xeon-e3>
In-Reply-To: <1489765882-30497-2-git-send-email-olivier.matz@6wind.com>
References: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com>
 <1489765882-30497-1-git-send-email-olivier.matz@6wind.com>
 <1489765882-30497-2-git-send-email-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/8] eal: support dynamic log types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Mar 2017 16:17:31 -0000

On Fri, 17 Mar 2017 16:51:15 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> +static int
> +__rte_log_register(const char *name, int id)
> +{
> +	char *dup_name = NULL;
> +
> +	dup_name = strdup(name);

Useless initialization!

Many people were taught to always initialize variables. But that was before
compilers were smart enough to catch those errors.