From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yuanhan.liu@linux.intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0BFD7101B for <dev@dpdk.org>; Mon, 20 Mar 2017 06:37:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489988239; x=1521524239; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iV9XogTQasQb71vFF+/d7QYoz9urYS0Mdh9JQ4fiD1Q=; b=XUTQFcx3HL3P8XKhvbznCN44YBN6jTb1B1HP4RbuOV8SV6bnI9zqh+eZ cL/quNM+yMdpC9dJl/xKeaR3y8yaMg==; Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2017 22:37:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,191,1486454400"; d="scan'208";a="62518309" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 19 Mar 2017 22:37:16 -0700 Date: Mon, 20 Mar 2017 13:35:23 +0800 From: Yuanhan Liu <yuanhan.liu@linux.intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: dev@dpdk.org, Harris James R <james.r.harris@intel.com>, Liu Changpeng <changpeng.liu@intel.com> Message-ID: <20170320053523.GJ18844@yliu-dev.sh.intel.com> References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com> <1488534682-3494-17-git-send-email-yuanhan.liu@linux.intel.com> <ed42456d-288e-204f-b34e-36efd0991c4d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <ed42456d-288e-204f-b34e-36efd0991c4d@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 16/17] vhost: rename header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 20 Mar 2017 05:37:19 -0000 On Tue, Mar 14, 2017 at 01:59:49PM +0100, Maxime Coquelin wrote: > > > On 03/03/2017 10:51 AM, Yuanhan Liu wrote: > >Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio > >net specific. > > > >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > >--- > > doc/guides/rel_notes/deprecation.rst | 9 -- > > drivers/net/vhost/rte_eth_vhost.c | 2 +- > > drivers/net/vhost/rte_eth_vhost.h | 2 +- > > examples/tep_termination/main.c | 2 +- > > examples/tep_termination/vxlan_setup.c | 2 +- > > examples/vhost/main.c | 2 +- > > lib/librte_vhost/Makefile | 2 +- > > lib/librte_vhost/rte_vhost.h | 259 +++++++++++++++++++++++++++++++++ > > lib/librte_vhost/rte_virtio_net.h | 259 --------------------------------- > Did you perform the rename using git mv? Yes, and I forgot to add '-M' option while run "git format-patch". --yliu > > > lib/librte_vhost/vhost.c | 2 +- > > lib/librte_vhost/vhost.h | 2 +- > > lib/librte_vhost/vhost_user.h | 2 +- > > lib/librte_vhost/virtio_net.c | 2 +- > > 13 files changed, 269 insertions(+), 278 deletions(-) > > create mode 100644 lib/librte_vhost/rte_vhost.h > > delete mode 100644 lib/librte_vhost/rte_virtio_net.h > > Other than that, the change looks good to me: > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Thanks, > Maxime