Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies

[Olivier Matz <olivier.matz@6wind.com>]

Hi Robin,

On Fri, 17 Mar 2017 18:47:20 +0100, Robin Jarry <robin.jarry@6wind.com> wrote:
> Hi Olivier,
> 
> Thanks again for this. I only have minor cosmetic remarks:
> 
> Le 17 mars 2017 18:13, "Olivier Matz" <olivier.matz@6wind.com> a écrit:
> > diff --git a/app/pdump/Makefile b/app/pdump/Makefile
> > index 536198f..8ec6bd6 100644
> > --- a/app/pdump/Makefile
> > +++ b/app/pdump/Makefile
> > @@ -42,7 +42,6 @@ CFLAGS += $(WERROR_FLAGS)
> >  SRCS-y := main.c
> >
> >  # this application needs libraries first
> > -DEPDIRS-y += lib
> >
> >  include $(RTE_SDK)/mk/rte.app.mk  
> 
> Maybe remove the comment line too?
>
> > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> > index eec1ed0..3be1ae8 100644
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -82,7 +82,6 @@ endif
> >  CFLAGS_cmdline.o := -D_GNU_SOURCE
> >
> >  # this application needs libraries first
> > -DEPDIRS-y += lib drivers
> >
> >  include $(RTE_SDK)/mk/rte.app.mk  
> 
> Same here. There may be others.

Thanks, I'll check for other occurrences.


> > --- a/mk/rte.subdir.mk
> > +++ b/mk/rte.subdir.mk
> > @@ -59,8 +61,9 @@ build: _postbuild
> >  .PHONY: $(DIRS-y)
> >  $(DIRS-y):
> >         @[ -d $(CURDIR)/$@ ] || mkdir -p $(CURDIR)/$@
> > -       @echo "== Build $S/$@"
> > +       @echo "== Build $S/$@ "  
> 
> Why change this line ?

It's a typo, I'll remove it in v2.

Thanks for your review
Olivier