From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com
 [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 1E70211DE
 for <dev@dpdk.org>; Mon, 20 Mar 2017 09:31:56 +0100 (CET)
Received: by mail-wr0-f180.google.com with SMTP id g10so86932793wrg.2
 for <dev@dpdk.org>; Mon, 20 Mar 2017 01:31:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=6D7trJIlakezC05RhXzH4CFva4QfUIN3zXb73xmw9zw=;
 b=GbziPqbE2ovjWn+EoQAvNsFD4nCegdTZYqoAMdm5GDDbMg19PK7agcPHcT+3zN09mc
 nPAgLdEdAy8uVMTtY5/HYj1y2+efDTp1HJ6fadO5bjC71+Hy5CJAQVZfIwD4dc80s6SB
 KlcUZabpVlyXj0vhgcXVZkXIJDLViOW2Wmy6twTC47Hz38qzBWMtckS+1F0t7uwpsaIb
 vwsZUjxzQuNXA5H+jXZ6GjRcO3vNrVsJ82OYrYjLBOdzyUnXZiaeD/sdRzGiXMkiAQMn
 hXO0nuhCD5izExRbziSUrFUgwriq5MxYbsa5xxCE7Ofc3SDyTqKjLioQ3XYUCgcjWU/k
 jQeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=6D7trJIlakezC05RhXzH4CFva4QfUIN3zXb73xmw9zw=;
 b=JPDFSn0e+xaqSHZ09x2XaZFzxRDJyPIS0/Dzs46XBJg+QYKIsiAkZ5cM5nNhlClbHk
 elqQYO2uwpdTVGvhKgjAzsIomSiajj4jL6CtCvgBpZarm7mL779z9JwJ4FM+PhfnP33b
 ckIP0lI2qdTTp7yzQSZg8MGbV6eNFE6n40TtkRD26yDrcmiXqkw61dX/1CCCGjt14+ZF
 tGtSiPxZpZd72M9lK2bvr5x5bytX02yN/anduaeNjqmMqcjF+DYg3jf7L2A0ALfSOcPI
 JVdaA/RWKN2u7sPpu75IN2X1fyRi5fIKUsYNFHsPgGHoZF4qTPR9SEDh39hYglVPJHHe
 kcNw==
X-Gm-Message-State: AFeK/H2gSSr3/9Z5fdeflHv7piKflN+auR+TYXZXOGgaIV8RMMXyvWOFl9Au06AFi7RbZkd0
X-Received: by 10.223.166.7 with SMTP id k7mr22308578wrc.52.1489998716365;
 Mon, 20 Mar 2017 01:31:56 -0700 (PDT)
Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr.
 [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc])
 by smtp.gmail.com with ESMTPSA id 32sm19829069wrr.64.2017.03.20.01.31.55
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 20 Mar 2017 01:31:56 -0700 (PDT)
Date: Mon, 20 Mar 2017 09:31:53 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>, dev@dpdk.org, keith.wiles@intel.com,
 jerin.jacob@caviumnetworks.com
Message-ID: <20170320093153.2b6f6d99@platinum>
In-Reply-To: <CA+4wmqyu5Q2=KwBYXG-bHcBwTjRHEvj0YVZst5jnHwLGUnYqrQ@mail.gmail.com>
References: <1485191953-2613-1-git-send-email-olivier.matz@6wind.com>
 <1489770822-27539-1-git-send-email-olivier.matz@6wind.com>
 <CA+4wmqyu5Q2=KwBYXG-bHcBwTjRHEvj0YVZst5jnHwLGUnYqrQ@mail.gmail.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] mk: optimize directory dependencies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2017 08:31:57 -0000

Hi Robin,

On Fri, 17 Mar 2017 18:47:20 +0100, Robin Jarry <robin.jarry@6wind.com> wro=
te:
> Hi Olivier,
>=20
> Thanks again for this. I only have minor cosmetic remarks:
>=20
> Le 17 mars 2017 18:13, "Olivier Matz" <olivier.matz@6wind.com> a =C3=A9cr=
it:
> > diff --git a/app/pdump/Makefile b/app/pdump/Makefile
> > index 536198f..8ec6bd6 100644
> > --- a/app/pdump/Makefile
> > +++ b/app/pdump/Makefile
> > @@ -42,7 +42,6 @@ CFLAGS +=3D $(WERROR_FLAGS)
> >  SRCS-y :=3D main.c
> >
> >  # this application needs libraries first
> > -DEPDIRS-y +=3D lib
> >
> >  include $(RTE_SDK)/mk/rte.app.mk =20
>=20
> Maybe remove the comment line too?
>
> > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> > index eec1ed0..3be1ae8 100644
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -82,7 +82,6 @@ endif
> >  CFLAGS_cmdline.o :=3D -D_GNU_SOURCE
> >
> >  # this application needs libraries first
> > -DEPDIRS-y +=3D lib drivers
> >
> >  include $(RTE_SDK)/mk/rte.app.mk =20
>=20
> Same here. There may be others.

Thanks, I'll check for other occurrences.


> > --- a/mk/rte.subdir.mk
> > +++ b/mk/rte.subdir.mk
> > @@ -59,8 +61,9 @@ build: _postbuild
> >  .PHONY: $(DIRS-y)
> >  $(DIRS-y):
> >         @[ -d $(CURDIR)/$@ ] || mkdir -p $(CURDIR)/$@
> > -       @echo "=3D=3D Build $S/$@"
> > +       @echo "=3D=3D Build $S/$@ " =20
>=20
> Why change this line ?

It's a typo, I'll remove it in v2.

Thanks for your review
Olivier