From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 373C519F5 for ; Mon, 20 Mar 2017 14:57:08 +0100 (CET) Received: by mail-wr0-f177.google.com with SMTP id g10so92978563wrg.2 for ; Mon, 20 Mar 2017 06:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4H/4HKithRtW0e6JNYVWtCLUpf/bXK+SMCsgpXmU0eI=; b=RgZW/j6991SBvXJI+OagshkKAKaTvs95LD2tD6hZm67Yd57N8V4FgtG2QQn4IRRjBx +P5CSi4TnApsAk3YV37ftmohg79t109gXVq5E5PjFReY5VKoWzqU4DUEFJJo+ORmYQtF MtAmU96bjNbKn+VKnyE0MpbYx/QMa8hdlvxlGWhp/oUghiIvGQzYr443s0hf5nbVJQm2 JExSu9uHSJy1jDgXqy30JJQusWEIe1Srj4DQ7+Ely8SC5gQONDQuTHhZ+hBGaNugumu4 3lvWEdm9Iu/onqYVwUaDR4XIZDK8BYrwBo77Ou4cYWB1gKudL49VchgJTtJ4eBuLEJAs Bkvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4H/4HKithRtW0e6JNYVWtCLUpf/bXK+SMCsgpXmU0eI=; b=dSGoaP02yO1j0TzMF/VyTwT6Cvj05uzFcfdv0ydr3I0lAMUVC1emao3VW7fP4DA17n fsWj15xOhEAhaDVRyMR77sqnXe8EC+OBD5MoLbwiKENL78lmTVYOx/n5zuQNFMJ09t81 NtsKarOyVSfDkGTH7QCIQaddh8DiCEE+ANsFB8sCqfZFfjZw8MkXsKIm+yibqLMlEXGd S+LJmyjSwCmqdinEFGvxkPI3E72BbmbNPwlg/d5+fEcdX/4Xn0m5jurDxcxfO7GARI2v 4MhOi7jrz++XrrjvS6AekQnq7f1+xqWpkxbD+gfrAPnQZhhK29le+/zDAHUveQRUgRGA yiHw== X-Gm-Message-State: AFeK/H1l78bA8NGWXQwM4mIWhMGtbjw+ihRGK6thLr4/LgiOJZDU9JlkaYykTk823h2jLY5p X-Received: by 10.223.176.217 with SMTP id j25mr27578708wra.8.1490018227793; Mon, 20 Mar 2017 06:57:07 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v21sm16292183wrd.58.2017.03.20.06.57.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 06:57:06 -0700 (PDT) Date: Mon, 20 Mar 2017 14:56:58 +0100 From: Adrien Mazarguil To: Ferruh Yigit Cc: Gaetan Rivet , dev@dpdk.org, Nelio Laranjeiro , "Legacy, Allain" , Stephen Hemminger Message-ID: <20170320135658.GW3790@6wind.com> References: <20170316110409.GO3790@6wind.com> <8dfd3eff-5326-5561-396a-11482ba3cc87@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8dfd3eff-5326-5561-396a-11482ba3cc87@intel.com> Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 13:57:08 -0000 Hi Ferruh, On Mon, Mar 20, 2017 at 01:24:36PM +0000, Ferruh Yigit wrote: > On 3/16/2017 11:04 AM, Adrien Mazarguil wrote: > > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: > >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus > >> address. > >> > >> Add a new port parameter allowing the user to choose > >> either or both physical ports to be used by the application. > >> > >> This parameter is used as follows: > >> > >> Selecting only the second port: > >> -w 00:00.0,port=1 > >> > >> Selecting both ports: > >> -w 00:00.0,port=0,port=1 > >> > >> If no parameter is given, the default behavior is unchanged: all ports > >> are probed. > >> > >> Signed-off-by: Gaetan Rivet > > > > I think this patch is good as is. Whatever value results from users > > specifying random characters as argument to the port parameter is their > > problem, as long as the resulting value is verified to be within bounds, > > it's fine. > > > > I'm not saying that checking all possible failure modes of strtoul() is > > useless, just that it seems overkill in this specific case. Using atoi() > > without any error checking would have been perfectly fine as well. > > > > Acked-by: Adrien Mazarguil > > Hi Adrien, Gaetan, > > Are all comments addressed for this patch? It looks like discussion is > going on? I think it's over, no more comments will follow. -- Adrien Mazarguil 6WIND