Re: [dpdk-dev] [PATCH v4] devtools: add tags and cscope index file generation support

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

On Mon, Mar 20, 2017 at 10:15:45AM +0000, Dumitrescu, Cristian wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> > Sent: Sunday, March 19, 2017 10:52 AM
> > To: dev@dpdk.org
> > Cc: thomas.monjalon@6wind.com; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v4] devtools: add tags and cscope index file
> > generation support
> > 
> > This script generates cscope, gtags, and tags index files based on
> > EAL environment(architecture and OS(linux/bsd)).
> > 
> > If EAL environment(config) is not specified, the script generates tag
> > files based on available source code.
> > 
> > Usage: build-tags.sh [-h] [-v] tags|cscope|gtags|etags [config]
> > 
> > example usage:
> > ./devtools/build-tags.sh cscope
> > ./devtools/build-tags.sh tags x86_64-native-linuxapp-gcc
> > ./devtools/build-tags.sh gtags arm64-armv8a-linuxapp-gcc
> > 
> 
> This is great, Jerin, thank you!
> 
> IMO it would be even better to have this as one of the targets in the master makefile rather than a standalone script, what do you think?

I had it in v2 and then I removed it.
If there are no objection, I will add these targets in Makefile in next
revision.

Example usage:
make tags T=x86_64-native-linuxapp-gcc
make tags

➜ [master]laptop [dpdk-master] $ git diff
diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
index 7598bde..cee53ff 100644
--- a/mk/rte.sdkroot.mk
+++ b/mk/rte.sdkroot.mk
@@ -92,6 +92,15 @@ default: all
 config showconfigs showversion showversionum:
        $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@
 
+.PHONY: cscope gtags tags etags
+cscope gtags tags etags:
+ifdef T
+       $(Q)$(RTE_SDK)/devtools/build-tags.sh $@ ${T}
+else
+       $(Q)$(RTE_SDK)/devtools/build-tags.sh $@
+endif
+
+

>