From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0079.outbound.protection.outlook.com [104.47.32.79]) by dpdk.org (Postfix) with ESMTP id 856A71B53 for ; Wed, 22 Mar 2017 10:39:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=byFTJrf6OYSsSa1y/dlvlIN7OxwA1cZ1VZkBWelxZWg=; b=EysFgc7kXf1CF0keDeRFmmtZfc+Mv1AapJjpA09UxenTSxbrkFd4OGeyVuGa3kV8EOjXGSc7YByUrqggAPUvFDziVSzSYCiWZcLGZQ+K1xlH34iNW5Q9Siv4yep+OKpmoVJTGj69sjfjakPcr5neJVvR+8dUlbn4WaLwd7HUYds= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (111.93.218.67) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Wed, 22 Mar 2017 09:39:45 +0000 Date: Wed, 22 Mar 2017 15:09:33 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170322093931.2u5z3n645cnobi63@localhost.localdomain> References: <1490019040-6268-1-git-send-email-jerin.jacob@caviumnetworks.com> <20170321143832.swnf7xetxlxc3k5w@localhost.localdomain> <8059571c-9747-ca33-0d61-f453e43afa48@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8059571c-9747-ca33-0d61-f453e43afa48@intel.com> User-Agent: NeoMutt/20170306 (1.8.0) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0102.INDPRD01.PROD.OUTLOOK.COM (10.174.144.18) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-Office365-Filtering-Correlation-Id: 597af8a4-43b8-4134-783f-08d47107607f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 3:F9SrSGdzpPVgrXa5kdzDG1tRw3YNEgzraQZ24a6N/yc2et70/5F3iX2NJSAypPbNHvME+3ynMh6iMgC9hSm3nmcZqu4BgWjR6KnFxBtKI+P0PntYAkDKYfK+ljHhTioWekqvJd05MHJay06naW6PPG7zq1G/6XkYnjIeDLdzWqqGEVC8C0Hf0K9WV6vzB9YagZDfgzPEHtqcNMTism1QBXNbB1LDftINkNsNAAnRzeeYA/MS5e7MQ/oYKWD/rClRQvPN5Pr8CgGlq4N3UYVc3A==; 25:PJ8v4cNXC539gATFw+cbxhzEVq3jnVkLVyLdMYbw735YoqyRVzOmQN72rKXnFsL8ZznwHZrfFuSqODqLJEwKav+zRXSjG1vbZUR+1nA8x36Yfet9+YLN3Rd3/6o6gPsfFYVk/SdM6tzJNO0yHmU6bq8uPrh3u/L/Rnt3b9RICrbJ2dAPjIiPKQOviTqBFmeDnIf2gAyaSBKrK1ILPvy5Q52rv0/3ZeYmO5ioIugFkDvvHvJkuqMC99zjygdrW5enlLwS7UixGndGGuSgtWvhjR+UPeyIcyecTABZ5XMc4GcAVagtzRbTK2EaLb2XNlxmh1EBFH59NHOdJYODKU7tXyNiG0/p0Jokv5iU2JLI+LAh6de+zWIrlmjZ4XumW3uahJqSfCTuXKa7N3kcuYrw5njgdkBPo8hcTFxDqKdIPSiuvtI4DRFMZM7ls1h6/k7rnBkdS/zJLD4E7ZLGQukEjw== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:+TmbDPu7utIDXq3I6RxxUUXl3NzVB2upOtL6SUPPt2G65N1Kv+KDI14pWPjc35XsD90LtmNk0tsP67NC+QvlJLsCVnmsAQuysY9hSjpuKBlynrUsz96Fjwmmc01R8n1G3kwTP4hfuQ3CKLUVp3qlcUiGWWT50GGCV5Jtb8qnrq5/DItTVOL1WIHtndnLFGXKNsHq0A8D0C3X0v8St2ky6EVqqmaHhmWzuE1IyMEFOMHsvxaQECvFbZnHDuzmQmCmzfXSoiG2Xwq3l0hEMAGVqGZSan97Ui9xng6ZzMVoVQM=; 20:UAD2JMWsfAldsq5Q9EMfGQhk67SHmgOFeDkxawYFmctVqeVA5t/7NPdRTlJj6DS00REUqz6M9bJDt6hLslOz1xKc+7sDWFV/cHlVhRkg7wiPXWscN3hMdsT6b59dmsdLLozydH0WRGQHzuaFt8Pd60jfg1z+jSIyz8ANOe+s4xMZ43KSBqSvQGuIZNC3uN0pVclc/zgGJ0mjoJmeFHHP7uH5FWE3ue/77tlJCteWJFeJxKr1c6EYC5xvuV6syAnM0nrlXs1qnZLkAl1JMS4/tKstOpMCmLbf23vSnM1so6c+2UzwF5+Y4GaTQq//7CMc7LdJuGokR7ksYqQ+nKzFf2hXmLETseAl8Cay+SozTOtLPvtAD1MXFYfaCmIGT4bSj9r+CgmJEYeJGZdhDJNv18TUw5YY1C2Jb0QIaMS9Oqn/bkmCp5W5XTA4onVebYT7vNocPXjhLMQ/wto0B9NVs5ViJwqbBjq5SZXKJA/edve7bM0HrPImb3lHzCRBJZfhTyz63FqSLQqVtdZ4UebdFK18w/MwXHTLRoPwb2QM2rPAtJSm48wnsUOJWMrXy2WB923gwB+Z9adFq76abKOpsF9/7XuLnBytqu3iivV1ikQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123555025)(20161123558025)(20161123560025)(20161123562025)(6072148); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:AZ7JlXV+0efRTeWXYMq0dty0lgPnUcAwI4W+I0iPNX+KBTvOlEN0yDk8EWvbdK7SoElxi0XNMAj3eQVB37pqNsqM75b1HLIbaK62cwrooBuH+g531fZoUhrdbsAClz97x75NdV4o9Mn6d+BSfqclTQaFRzIi9XaBTYCRR/rGW3moLnxzjSWDxNx+3YKVse6csu6u3qxk0HvZOtyPKRyNLZGsHOW/gpr52MjR6SSGZP28lXKD2k0qNdHNfN79+1ijqKsori3PgthKR0v4c9Inaab8HGfIy75kxZpEW+IgjPpAHLbKSeZc1ZcanAy9mwMrVYfyyIoj4+BVbW1CIPNtKuL4NgA3ENZT+Zg183qGgKebx+7sJ8F6IXAJ6HrhFi1+iHf6YHdVOYDTR3SjoAI/BVgJp+roQDTv4EGSWUU1Kbr1CLYtrmVLlfAXEwUvurz5Y2vv1EBj84Mp8NB3uPzgYafgq9C8k8aMANeVidRUZkDDbErd7AYmx3VysOuBRIuBauH4R+49rE/fGRFKU+VbVQLOhjRKzk37aHHnPy6BAQybz/i5cae+xsa+35f6Yl/0I4xUNw/OOwbMDZD6GhNBN4QArMFShSCxjbTYsrzMQtg= X-Forefront-PRVS: 02543CD7CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39450400003)(39830400002)(377454003)(24454002)(42186005)(5009440100003)(2906002)(50986999)(9686003)(93886004)(4001350100001)(5660300001)(1076002)(50466002)(229853002)(6116002)(23726003)(6506006)(76176999)(54356999)(53546009)(3846002)(55016002)(53936002)(25786009)(33646002)(7736002)(61506002)(305945005)(66066001)(189998001)(6666003)(42882006)(2950100002)(4326008)(6916009)(8676002)(110136004)(38730400002)(81166006)(6246003)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:2xdDSFWkYvh7Q4HY0+67ioWWNtWGYf2OzJqFhPV?= =?us-ascii?Q?zMMbjk5mXqjynCd2BfcMms3oGnivzbzu6UvmfS/Wtb6G/HLgkx8/l2/SUKZz?= =?us-ascii?Q?jy77IKojijHG7Qew+TRB5N0wngR1TE2Jsfp6fwiPGF+tQi8xqpm5A62qufn8?= =?us-ascii?Q?aiwIoE1d34XI1esjfr2qBNMqh+IQkRvvWkA1Yn8IOgG3uIvgq4l8GL8aFHFX?= =?us-ascii?Q?y4Bo8s2IJjoTQxCbVYFUMvKWfpUzoXNzghVHNsp8FC+eXBnYef1rAUEfCZ2V?= =?us-ascii?Q?4RMlHDZLlr0tg04OINfrLH1CG91NtAtnT6uOEojazvuf6onTP5XcS40YJy3C?= =?us-ascii?Q?mWBrPDakuc3gIWQdoFnniivCBfcy6AErfLuX2W0vSKJ3sFJs9qfno28X0pSP?= =?us-ascii?Q?+fWgRmVcNrNLlHucWNAHJGF4Usp8vJS/NObCgPeJ7hyXx4UbgmyEaVfpFnuT?= =?us-ascii?Q?hG9S5K5qrCxoFsV2dmrL20HrJfvSTQKZUoM/lSGqrWOm2nqoU1VOzaq8jBFR?= =?us-ascii?Q?k6MJVb1sdJrBIo8Q4WqCet8v10N4BYOEZHSCjEs5I+p2WscV07Ia1ohFGBMw?= =?us-ascii?Q?pdG8Zapa8QAnFz99keH2fVRLqOVuv07zi92eybo2ljLDfpJuGttFia3NVhac?= =?us-ascii?Q?HHOdL9TE2oxkEw2fhChFcqRxi74Vx6Zo1gpCieFcS+rLLqzLo/3z+yKFPFvI?= =?us-ascii?Q?QJpHFZf9vhdmoRgcqzMrhY1bHO7mU+n15olLZ3Uod71/whW2s7xDsuoV+dwC?= =?us-ascii?Q?ffYja9KPESrvICj2hV9KFORjJEQEF03pcoGsR7UA3GQFwW1nzr4Ph24qKxnt?= =?us-ascii?Q?+7yAq0ORq/GSAua194CJvT2TU45hE1S5eytsljXPKUVhE8U+BzhPx6z4DmPs?= =?us-ascii?Q?ii67lkHsd2h0zLxQMUcP+paAgQ7/Am39r8OO76w0KgD4nbuK4DEPh86JMRvq?= =?us-ascii?Q?B+behO5YiNaiyR44ugQwF89voqLPcBy+8w08GPuu5XNpq8RahqiKSfbHGEaI?= =?us-ascii?Q?IyZPG/JBuQVzJSJFjl7ysijY5XU+vHGCgDbKTcGJgqqjofsUz/0EI2IGEptd?= =?us-ascii?Q?L/8S95RM2lSgR14Mz5y6pMcXymTm6MHtdkCRX4puLkeg7+1rOv5xv9mQzAKi?= =?us-ascii?Q?4pyNuG2C7S9IMqFXpRiow+Y4gUxhJMIyK?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:KkhomKYry/PQ72bgVpEYOtZgw9GGYKBGg3gHG8z9izv1u5dKWVJzF/0PXP8sNUzNRFFqDWy9A93SMQNBP4dn5hBYgXixVkYi0W+0IVWCgTsP+cIHDGh6a/d2Mg7SDe3Tmhg8HKQXhNpxHtgpza08YIq60laXzW6WbZoZZO/h5u15YcxGaG74Y/AE/EQgAv5nORFV7uL2ROgVBNn1I2tf99mUwPjbQbbHVNEFH7zP+byAccpEFjFD+XZarPH3F5Q+tNJbqli8WbEORmRYcn5IaE19dLZwBxarlcMM6ZpAKLCYzkx6xnFxLZIQNibVKJpWztEyEMc/trqGSXdXCUMCEI8twnJmYUhqaeHe5TF6UADapl5qtSRozAmUoB//mwZiZlpxKyzq9lNKh+oA3CY3DA==; 5:o/mfsH77y4l1xVj2R1NZDzuZhzXDSgvaO9AvMcOfDchcBE+FHtqvVsUF+2mGQjtN5+YaV98Tj2/8CPKBccpj/2F4gVgV6oxpP5Qzg8Piu3YRZYy33PNjx9G6XcntHRUSF/44SHPYotKZAJU8Q+17UA==; 24:yws4dgCMi+5dbHjGZilxNeENf1JoVLuTMD+GpDLpv+fmMA+LOrBoCCZr/30RsC3Vm4hbW2QTRNeznwaA2jNMQ5XTNe4O/v1zKto30Eqi0O8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:Gl21u7UuWn4pVAPKEviblGobbpIlmJ1cRDbRazEASW4YEbI9l34XC44w4dyIboHgLZtZlD8Gmb9ZQkE0Kh8hHFri7/E6K9qydfF5P8gxN2WX8JjaE44Trr8qaoMSGvW44aybkYss6//+vIZIVX9BI4cUrKgg4BRlGsUCXlCcvxw7+KyX1jkTCOLXPzctYH3rwXww6L280Z33hUs5JEzrXhP6uz89WNuqfhydA3EjKIUXotUm6Ec4FkZBzgVpqDsXYrfJzzx3WK7JkZuhI/+nU0TRcdnB42dSizY1/7SBSuLy2M/1zwHrOmANTPj65ehrv7yOOpjtgvqgxp0AbDmFnw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 09:39:45.4490 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 09:39:49 -0000 On Tue, Mar 21, 2017 at 02:53:29PM +0000, Ferruh Yigit wrote: > On 3/21/2017 2:38 PM, Jerin Jacob wrote: > > On Tue, Mar 21, 2017 at 02:31:41PM +0000, Ferruh Yigit wrote: > >> On 3/20/2017 2:10 PM, Jerin Jacob wrote: > >>> - bgx_link_status mbox definition was changed in Linux > >>> commit 1cc702591bae ("net: thunderx: Add ethtool support") > >>> - NIC_MBOX_MSG_RES_BIT related changes were never part of Linux PF driver > >>> > >>> Signed-off-by: Jerin Jacob > >> > >> <...> > >> > >>> @@ -157,6 +151,7 @@ struct rss_cfg_msg { > >>> /* Physical interface link status */ > >>> struct bgx_link_status { > >>> uint8_t msg; > >>> + uint8_t mac_type; > >> > >> Hi Jerin, > >> > >> Is this modification related to this patch? > > > > Yes Ferruh. > > > > This was related to the following section in git log comment. > > ---- > > - bgx_link_status mbox definition was changed in Linux > > commit 1cc702591bae ("net: thunderx: Add ethtool support") > > --- > > I see now, thanks. Since this is to sync with Linux PF, shouldn't it be > used in driver, perhaps something like in Linux driver: > "nic->mac_type = mbx.link_status.mac_type" > > What is the point of just adding definition without using it? That is to keep "link_up"(next element in the struct bgx_link_status) points to correct location after the kernel change. I thought about, the backward compatibility with older kernel, Is it OK to use linux/version.h in PMD drivers to detect the kernel version? drivers/net/mlx5/mlx5_ethdev.c has similar kernel detection mechanism to make it backward compatible. If there are no issue with such approach, I will roll out a new revision. > > > > > > >> > >>> uint8_t link_up; > >>> uint8_t duplex; > >>> uint32_t speed; > >>> > >> >