From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id E3A1ED49E for ; Fri, 24 Mar 2017 15:11:50 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id n11so14079621wma.1 for ; Fri, 24 Mar 2017 07:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x0DBvCfJgju/FlJ55HEywI7HBx3tHpD3jtdKKoYHHbc=; b=F9DWtTc5atuCk/3Eqdz2xozcVC25f1miQy9A0ams9Nyt2pxQGlXd2RFmhtj6VFFSAZ voJlkNesapai3Zs/qs8KG6HbEDpG07Q4/3L01flzAzPC8lGsn2VUAoT+xXLagcnxKdjB PF4qbVy/ciC8d42MTbE1kuq+UcWTJoWq1dR4YbdWOqetuiTQYXKy3r3CTyrcdeLqIc99 pwL76jdDDDuC8jLu3vxhW2gCudCc3tK6+vvCqIg2xkPCEJQwxPew+z+D58O62YYHQW/o t5xNzxt17MdZQEnLXQSuik5S8a8Fb250S6WvKgvynJw6NapPqIlDO82z1bAL1UqILYgF lgQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x0DBvCfJgju/FlJ55HEywI7HBx3tHpD3jtdKKoYHHbc=; b=DxmiXW+qusiZFvRlhcjg2CEu9eguU5lM2Qq2CoZ1M/9XjHKtDsV+9CjW9PD/LnsbLA OCVMeBnRtWDkQlCJMTqa2iqVWVJDYsqoa6IeBXknlrn63vfYOdIstzIrPNNoTT5apDWB yGMJ+4NjzVluqrFcP43VBlSBv7nmSEn/1m+cClr/isnpVn+qtXX0/TexWqAQdd5WR+mE dBSWnHbgbGVBiq5DQ2src+SeZ6hreq/Gac21pCdwjdBR9y2K5RFQEQLidsbSNqEd3Nve QAQDDBxIXIwjZkG+Z0ehSEZRvKNzhv5ECQtkY4Rj5dVGYknODhDacSNSz+JGdOgafEjY jdeA== X-Gm-Message-State: AFeK/H1L2g+HR9or9+zbG6FjGUSRDaMAybdNoJyISWlNWiWCHboldD7EnpjrqomuRDlNt3aS X-Received: by 10.28.167.203 with SMTP id q194mr3234086wme.111.1490364710385; Fri, 24 Mar 2017 07:11:50 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 127sm2601921wmt.20.2017.03.24.07.11.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Mar 2017 07:11:50 -0700 (PDT) Date: Fri, 24 Mar 2017 15:11:48 +0100 From: Olivier Matz To: "Dai, Wei" Cc: "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" , Guo Fengtian Message-ID: <20170324151148.5c3d9f9d@platinum> In-Reply-To: <20170314104640.32b06adb@platinum> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170206145858.41447b6e@platinum> <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com> <20170216174922.720f83b9@platinum> <20170314104640.32b06adb@platinum> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 14:11:51 -0000 Hi, (remove stable@dpdk.org) On Tue, 14 Mar 2017 10:46:40 +0100, Olivier Matz wrote: > Hi Wei, > > On Thu, 16 Feb 2017 17:49:22 +0100, Olivier Matz wrote: > > Hi Wei, > > > > On Thu, 9 Feb 2017 14:50:05 +0000, "Dai, Wei" wrote: > > > > -----Original Message----- > > > > From: Dai, Wei > > > > Sent: Thursday, February 9, 2017 10:38 PM > > > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > > > Helin ; Ananyev, Konstantin > > > > > > > > Cc: Guo Fengtian ; stable@dpdk.org > > > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after > > > > a PF reset > > > > > > > > The stats register can rewind to zero when the port is running for > > > > a long period. So I am afraid that this check is not always correct. > > > > Why not introduce a variable to directly indicate whether the > > > > resulted stats should be updated or not. > > > > > > Another way is to clear > > > hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same > > > time PF is set down. > > > > > > > Can we know easily in VF if the PF was set down? > > Any guideline for this? Or is it something we cannot fix? > Is any maintainer available to help to fix that? Unfortunately I don't have enough knowledge on this driver to do the fix by myself. It would be helpful to have some guidelines by a maintainer so I can understand what is the proper way to fix the issue. Thanks, Olivier