From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 6B7FE69A5 for ; Fri, 24 Mar 2017 17:31:49 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id n11so6621914wma.0 for ; Fri, 24 Mar 2017 09:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LnKS/Ad2c2BsFQqNCrG6cUUT9QEfAJQO+FnfYdJkjAY=; b=l+FqkplRlrkowmQjg5NqB76727nImODv/BB0AHOAW7W9nlL6IYoyhJzrk6j4guTCp0 pDQYkoFB+qLCUVwFOUAtW2MgAo7l39pH9ZGkgCI1Rh1KOYV/lBm5MkbEEWtp/2gkuFTn B7piLnAi8nOw9276q3QqdmCJTfNQfEJJJ22VQk4XtsnolJv6bFZ4CobopRSXo7rSzCD+ nhjPtJvd2fQlQHd7v6WR/m2Xv1qxheXmC4dr2amagcy95DHvktaN5yGBWiD2KbQdkBZC ZmOPMwsVEjFSuTPOxGqFlVqj6kqR1FHDBXc/qxDplJq/gOmRjKvAbCIxgFc7TEo1KMCl BbgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LnKS/Ad2c2BsFQqNCrG6cUUT9QEfAJQO+FnfYdJkjAY=; b=giZ+6Z1LI++tZJXyU7Th0suJWhXpncoZpN4MeR7eSTGeaOgHF4Fq8yfV74Xa2kR1Lc 3WGJn61MUfaj3T/ek9MKlJnRyBHEoTSkthffo31oOm26zq7oNTFGABYuX+I9ed5uoJsw x9XJ9x9o/JHA0G1C4sUtNJZ1gXg70hSDPw3luJVGHOHdKhyT2ftpQDyk5spXaijs9qMB /l/uXU9vza4PVX/0EYVQe+O1rhPJHZT2O+iJSbaopqHbpR/5efG7hESTNXHJkkVEONGb l56TNIQat82xUZCnnj78XAbGEeWKc5BYlW5PvkT7z8UC6zWzqoJPaVa7pZZhtqJSIh1f JhEQ== X-Gm-Message-State: AFeK/H1mx/nT7myH1Spf/9+OtcMjmnTtP4iSlEUAO826UYmrbG3xxavO5B8hD0qvQNP6SO4J X-Received: by 10.28.74.28 with SMTP id x28mr4000543wma.131.1490373109087; Fri, 24 Mar 2017 09:31:49 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 32sm3465812wrr.64.2017.03.24.09.31.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Mar 2017 09:31:48 -0700 (PDT) Date: Fri, 24 Mar 2017 17:31:46 +0100 From: Olivier Matz To: Ferruh Yigit Cc: Hemant Agrawal , dev@dpdk.org, thomas.monjalon@6wind.com, shreyansh.jain@nxp.com Message-ID: <20170324173146.477a5157@platinum> In-Reply-To: <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com> References: <1489754838-1455-1-git-send-email-hemant.agrawal@nxp.com> <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <7d898278-9331-0c72-cabd-9318c6d65f1e@intel.com> <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 16:31:49 -0000 Hi Ferruh, On Fri, 24 Mar 2017 15:59:50 +0000, Ferruh Yigit w= rote: > On 3/24/2017 2:57 PM, Ferruh Yigit wrote: > > On 3/17/2017 12:47 PM, Hemant Agrawal wrote: =20 > >> DPAA2 Hardware Mempool handlers allow enqueue/dequeue from NXP's > >> QBMAN hardware block. > >> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS is set to 'dpaa2', if the pool > >> is enabled. > >> > >> This memory pool currently supports packet mbuf type blocks only. > >> > >> Signed-off-by: Hemant Agrawal =20 > >=20 > > Applied to dpdk-next-net/master, thanks. =20 >=20 > Hi Olivier, >=20 > I get this to next-net, since dpaa2 net driver depends this one. >=20 > But were you planning any review on the code? Or is it good to go as it i= s? Yes, but I'm afraid I won't be able to do it today. =46rom high level, I'm still a little puzzled by the amount of references to mbuf in a mempool handler code, which should theorically handle any kind of objects. Is it planned to support other kind of objects? Does this driver passes the mempool autotest? Can the user be aware of these limitations? Thanks, Olivier