From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id A593136E for ; Fri, 24 Mar 2017 17:42:49 +0100 (CET) Received: by mail-wr0-f174.google.com with SMTP id u108so5333646wrb.3 for ; Fri, 24 Mar 2017 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8S7dyK6UexHjJewcxxN+J+pmcRLjst0aNFh8lXMhIM4=; b=XU0JBrxGDtqYBzw2Mp89MFkNJHMDEGTwCpjnhFbjfxLzXzA28WpUuU96dvKChQ/hDT HGyjKN4BoAzFM+UG17dyqRHkpwG+qJ5TALh0qlaA4UQGg0kWoYw2IOyAEdmLUxMliCO/ hPAUmT34MyIpkInpiqDzlV2xZGdpA+PDyM1EpfLyMZ8iOcWfBN/Duc3sAzymWQVAsX+R SPraOK0p4lNGFwJdAfAcyO2iJSJwOg0huRoaqiH9L5nxWcEk9KQo6lRONK+Gc9ePlfg5 2kY95QuuWAkzCPt4TujJxJMa54Kfe4tH/vZc8o2bq83mFov49RpHaQ4WcYhnJPOw20MV lDnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8S7dyK6UexHjJewcxxN+J+pmcRLjst0aNFh8lXMhIM4=; b=PEIBx89rFAqlwFgDagrP+8wEc02gdsJJsETUFuI43y8911043y0/sqMG1sIVkc1C9Z UbC2lsuhWIJ4QMAT60w5kszFOk0IisymLveQJHrUGtj8ry5MVeMX1o/ZPTuHg/l18NSf m3CMDPRnrcJSC9KbbKY7AbwVwuBp2JFXltN3UzyqFoC61fZR83qxtcnPIsRlLVbdq7NJ K1B5vYYGV3Vyz0E5YehORsjv7iETbh58KbuKrGrlJkSTCuS99ZnNYrj7uQb6+di8d6bZ fhyrhLYgzbadzBbfTbypWBBkgybeaP+6gQ+uBNNLd7KsWChnTURm4dpi3e3kg0PtmGnc 01JA== X-Gm-Message-State: AFeK/H3SZ/8twUz3NCEKkpZmDYmlOIN/nHxyRHXtOZaUrB6LUFURYCTN+A57cUsnnl6MMpbu X-Received: by 10.223.151.69 with SMTP id r63mr8641009wrb.6.1490373769063; Fri, 24 Mar 2017 09:42:49 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id k128sm3074769wmf.16.2017.03.24.09.42.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Mar 2017 09:42:48 -0700 (PDT) Date: Fri, 24 Mar 2017 17:42:46 +0100 From: Olivier Matz To: Ferruh Yigit Cc: Hemant Agrawal , dev@dpdk.org, thomas.monjalon@6wind.com, shreyansh.jain@nxp.com Message-ID: <20170324174246.4d04a21f@platinum> In-Reply-To: <434e5f68-430b-1676-fed8-3527f25f3081@intel.com> References: <1489754838-1455-1-git-send-email-hemant.agrawal@nxp.com> <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <7d898278-9331-0c72-cabd-9318c6d65f1e@intel.com> <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com> <20170324173146.477a5157@platinum> <434e5f68-430b-1676-fed8-3527f25f3081@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 16:42:49 -0000 On Fri, 24 Mar 2017 16:38:04 +0000, Ferruh Yigit wrote: > On 3/24/2017 4:31 PM, Olivier Matz wrote: > > Hi Ferruh, > > > > On Fri, 24 Mar 2017 15:59:50 +0000, Ferruh Yigit wrote: > >> On 3/24/2017 2:57 PM, Ferruh Yigit wrote: > >>> On 3/17/2017 12:47 PM, Hemant Agrawal wrote: > >>>> DPAA2 Hardware Mempool handlers allow enqueue/dequeue from NXP's > >>>> QBMAN hardware block. > >>>> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS is set to 'dpaa2', if the pool > >>>> is enabled. > >>>> > >>>> This memory pool currently supports packet mbuf type blocks only. > >>>> > >>>> Signed-off-by: Hemant Agrawal > >>> > >>> Applied to dpdk-next-net/master, thanks. > >> > >> Hi Olivier, > >> > >> I get this to next-net, since dpaa2 net driver depends this one. > >> > >> But were you planning any review on the code? Or is it good to go as it is? > > > > Yes, but I'm afraid I won't be able to do it today. > > OK, when you done your review, we can act according its result. > > I just want to remind the dependency chain, dpaa2 net depends this > patch, and dpaa2 crypto depends net one. > An early integration from next-net required so that next-crypto can > finish its work before integration deadline. Understood. Thanks. > > Thanks, > ferruh > > > > > From high level, I'm still a little puzzled by the amount of references > > to mbuf in a mempool handler code, which should theorically handle any > > kind of objects. > > > > Is it planned to support other kind of objects? > > Does this driver passes the mempool autotest? > > Can the user be aware of these limitations? > > > > > > Thanks, > > Olivier > > >