From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 6B01DFA72
for <dev@dpdk.org>; Mon, 27 Mar 2017 12:15:53 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga105.jf.intel.com with ESMTP; 27 Mar 2017 03:15:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,231,1486454400"; d="scan'208";a="948549413"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140])
by orsmga003.jf.intel.com with SMTP; 27 Mar 2017 03:15:50 -0700
Received: by (sSMTP sendmail emulation); Mon, 27 Mar 2017 11:15:49 +0100
Date: Mon, 27 Mar 2017 11:15:49 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com
Message-ID: <20170327101549.GB18148@bricha3-MOBL3.ger.corp.intel.com>
References: <20170307113217.11077-1-bruce.richardson@intel.com>
<20170324171008.29355-1-bruce.richardson@intel.com>
<20170324171008.29355-4-bruce.richardson@intel.com>
<2476675.J1ds0gYDs0@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2476675.J1ds0gYDs0@xps13>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
=?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.8.0 (2017-02-23)
Subject: Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size
and mask fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Mar 2017 10:15:53 -0000
On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote:
> 2017-03-24 17:09, Bruce Richardson:
> > The size and mask fields are duplicated in both the producer and
> > consumer data structures. Move them out of that into the top level
> > structure so they are not duplicated.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Sorry Bruce, I encounter this error:
>
> fatal error: no member named 'size' in 'struct rte_ring_headtail'
> if (r->prod.size >= ring_size) {
> ~~~~~~~ ^
>
Ok, I think I've found it now using git grep. I assume this is in the
crypto code which is disabled by default, right?
/Bruce